fix(editor): follow live terminal size in external editor #153

Open

jabber.developer2 wants to merge 1 commits from fix/editor-terminal-size into master

Author	SHA1	Message	Date
jabber.developer2	1ac58222b8	fix(editor): follow live terminal size in external editor All checks were successful CI Code / Check spelling (pull_request) Successful in 14s Details CI Code / Check coding style (pull_request) Successful in 23s Details CI Code / Code Coverage (pull_request) Successful in 3m26s Details CI Code / Linux (debian) (pull_request) Successful in 5m19s Details CI Code / Linux (ubuntu) (pull_request) Successful in 5m23s Details CI Code / Linux (arch) (pull_request) Successful in 7m17s Details The compose editor is spawned via fork+execvp and inherits profanity's LINES/COLUMNS, which hold the size captured at startup and are never refreshed on resize. A curses editor (nano, vim, ...) honors them over the real window, so it renders at the launch-time size after a resize. Drop LINES/COLUMNS from the child's environment before forking so its curses falls back to ioctl(TIOCGWINSZ). Assembling the env in the parent lets the child only reassign environ instead of calling unsetenv() between fork and exec, keeping it clear of unsetenv()'s allocator work in the multithreaded fork->exec window. profanity itself is unaffected.	2026-07-13 15:34:23 +03:00

Author

SHA1

Message

Date

jabber.developer2

1ac58222b8

fix(editor): follow live terminal size in external editor

CI Code / Check spelling (pull_request) Successful in 14s

Details

CI Code / Check coding style (pull_request) Successful in 23s

Details

CI Code / Code Coverage (pull_request) Successful in 3m26s

Details

CI Code / Linux (debian) (pull_request) Successful in 5m19s

Details

CI Code / Linux (ubuntu) (pull_request) Successful in 5m23s

Details

CI Code / Linux (arch) (pull_request) Successful in 7m17s

Details

The compose editor is spawned via fork+execvp and inherits profanity's
LINES/COLUMNS, which hold the size captured at startup and are never
refreshed on resize. A curses editor (nano, vim, ...) honors them over
the real window, so it renders at the launch-time size after a resize.

Drop LINES/COLUMNS from the child's environment before forking so its
curses falls back to ioctl(TIOCGWINSZ). Assembling the env in the parent
lets the child only reassign environ instead of calling unsetenv()
between fork and exec, keeping it clear of unsetenv()'s allocator work in
the multithreaded fork->exec window. profanity itself is unaffected.

2026-07-13 15:34:23 +03:00

fix(editor): follow live terminal size in external editor #153

1 Commits