Add asynchronous external editor support #17

Manually merged

jabber.developer merged 2 commits from feat/async-editor into master 2025-08-07 01:31:56 +00:00

Conversation 0 Commits 2 Files Changed 7 +251 -53

jabber.developer commented 2025-08-06 01:45:56 +00:00

Owner

Copy Link

• I ran valgrind when using my new feature

How to test the functionality

• step 1
• step 2

<!--- Make sure to read CONTRIBUTING.md --> <!--- It mentions the rules to follow and helpful tools --> <!-- For completed items, change [ ] to [x]. --> - [ ] I ran valgrind when using my new feature ### How to test the functionality - step 1 - step 2

jabber.developer added 1 commit 2025-08-06 01:45:56 +00:00

feat(editor): add asynchronous external editor support ... 66e5aea7ef

The synchronous `get_message_from_editor` blocked the main loop (`prof_run`) while launching an external editor like `vim`, halting network I/O in `session_process_events` and preventing incoming message reception.

Introduced `get_message_from_editor_async` for `cmd_editor` to run the editor asynchronously. It forks and execs the editor in a thread (`editor_thread`), suspending NCurses to free the terminal. The main loop skips `inp_readline` and `ui_update` via a new `background_mode` flag while the editor runs, allowing `session_process_events` to keep the connection alive.

On editor completion, `editor_process` (called per loop iteration) resumes NCurses with `ui_resize`, inserts the result into the readline buffer and clears `background_mode`.

Retained synchronous `get_message_from_editor` for ~20 existing code paths (e.g., `vcard_nickname`) to avoid breaking them.

Tested with `vim` and `nano`: confirms no rendering conflicts, messages received during editing, and seamless resume. Edge cases like editor crashes handled via error logging and seamless resume.

admin force-pushed feat/async-editor from 66e5aea7ef to c4e2e46636 2025-08-07 00:42:42 +00:00 Compare

admin force-pushed feat/async-editor from c4e2e46636 to ad294cdd6d 2025-08-07 01:03:50 +00:00 Compare

admin added 1 commit 2025-08-07 01:27:18 +00:00

Temporarily disable Fedora tests ... a3e23c3514

They are failing on our runners due to issues with dependency resolution.

jabber.developer manually merged commit a3e23c3514 into master 2025-08-07 01:31:56 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Low

4

The priority is low

Priority

Medium

3

The priority is medium

Reviewed

Confirmed

1

Issue has been confirmed

Reviewed

Duplicate

2

This issue or pull request already exists

Reviewed

Invalid

3

Invalid issue

Reviewed

Won't Fix

3

This issue won't be fixed

Status

Abandoned

3

Somebody has started to work on this but abandoned work

Status

Blocked

1

Something is blocking this issue or pull request

Status

Need More Info

2

Feedback is required to reproduce issue or to continue work

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

admin jabber.developer jabber.developer2

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: devs/cproof#17

No description provided.