devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Prevent crash with malformed JID in /sub command #23

Manually merged
jabber.developer merged 2 commits from fix/caps-crash into master 2025-09-01 22:32:20 +00:00
Conversation 0 Commits 2 Files Changed 5 +22 -1
jabber.developer commented 2025-09-01 21:03:45 +00:00
Owner
Copy Link

See commit messages.

  • (No need to) Run valgrind when using my new feature
  • Add unit tests

How to test the functionality

  • Try /sub request @example.com

Fixes #22

See commit messages. <!-- For completed items, change [ ] to [x]. --> - [x] (No need to) Run valgrind when using my new feature - [x] Add unit tests ### How to test the functionality - Try `/sub request @example.com` Fixes #22
jabber.developer added 2 commits 2025-09-01 21:03:46 +00:00
fix(cmd_sub): Prevent crash with malformed JID in /sub command ac2b6b9635 
Added null check for jidp in cmd_sub to handle jid_create returning NULL.

Crash occurred when processing malformed JID inputs like @example.com.

Ensures robust handling of invalid JIDs.

Fixes #23
Fix(ui.h): cons_show_qrcode declaration. Minor change
Some checks failed
CI / Check spelling (pull_request) Successful in 17s
Details
CI / Check coding style (pull_request) Successful in 32s
Details
CI / Linux (debian) (pull_request) Failing after 1m19s
Details
CI / Linux (ubuntu) (pull_request) Successful in 10m15s
Details
CI / Linux (arch) (pull_request) Successful in 12m3s
Details
4a5dd4dd69 
Prior to the change declaration did not include parameters, leading to errors in static analyzers and potential issues with compilation.
admin force-pushed fix/caps-crash from 4a5dd4dd69 to cf7b34acb5 2025-09-01 21:05:14 +00:00 Compare
admin force-pushed fix/caps-crash from cf7b34acb5 to 741dc4c275 2025-09-01 21:29:35 +00:00 Compare
jabber.developer added the
Kind/Bug
 label 2025-09-01 22:25:49 +00:00
jabber.developer changed title from fix(cmd_sub): Prevent crash with malformed JID in /sub command to Prevent crash with malformed JID in /sub command 2025-09-01 22:26:04 +00:00
jabber.developer manually merged commit 741dc4c275 into master 2025-09-01 22:32:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#23
No description provided.
Delete Branch "fix/caps-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?