devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

[#36] Use dynamic buffer size to prevent unnecessary buffer cleanups #37

Manually merged
jabber.developer merged 1 commits from fix/buffer-cleanup into master 2025-10-07 13:37:59 +00:00
Conversation 0 Commits 1 Files Changed 1 +25 -31
jabber.developer commented 2025-10-07 13:17:37 +00:00
Owner
Copy Link

Refactors buffer trimming to use dynamic line counts against PAD_SIZE (10k lines) instead of fixed entry limit (MAX_BUFFER_SIZE=200). This scales with rendered content, reducing unnecessary deletions that disrupt scrolling during history loads and mitigates stuck states.

Changes

  • Trim buffer only when total lines approach ncurses pad limit.
  • Remove unused MAX_BUFFER_SIZE variable

Header Updates (DX)

  • Detailed module overview: role (UI buffer vs. DB), features (trimming/metadata), NCurses integration.
  • Concise GPLv3 boilerplate with LICENSE pointer; add fork notice; preserve copyrights.

Partially addresses #36 (fewer cleanups); full scroll fix pending history queries.
See issue #36.

Refactors buffer trimming to use dynamic line counts against PAD_SIZE (10k lines) instead of fixed entry limit (MAX_BUFFER_SIZE=200). This scales with rendered content, reducing unnecessary deletions that disrupt scrolling during history loads and mitigates stuck states. ### Changes - Trim buffer only when total lines approach ncurses pad limit. - Remove unused MAX_BUFFER_SIZE variable ### Header Updates (DX) - Detailed module overview: role (UI buffer vs. DB), features (trimming/metadata), NCurses integration. - Concise GPLv3 boilerplate with LICENSE pointer; add fork notice; preserve copyrights. Partially addresses #36 (fewer cleanups); full scroll fix pending history queries. See issue #36.
jabber.developer added 1 commit 2025-10-07 13:17:38 +00:00
fix(buffer): use dynamic buffer size to prevent unnecessary buffer cleanups
All checks were successful
CI Code / Check spelling (pull_request) Successful in 22s
Details
CI Code / Check coding style (pull_request) Successful in 38s
Details
CI Code / Linux (arch) (pull_request) Successful in 13m4s
Details
CI Code / Linux (debian) (pull_request) Successful in 13m32s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 16m23s
Details
CI Code / Check spelling (push) Successful in 19s
Details
CI Code / Check coding style (push) Successful in 37s
Details
CI Code / Linux (arch) (push) Successful in 13m8s
Details
CI Code / Linux (ubuntu) (push) Successful in 16m2s
Details
CI Code / Linux (debian) (push) Successful in 16m26s
Details
6ad8a19053 
Refactor buffer trimming logic to use dynamic line counts (_lines per entry)
against PAD_SIZE (10k) instead of fixed entry count (MAX_BUFFER_SIZE=200). This
prevents premature cleanups for short messages, reduces scrolling disruptions
during history loads, and scales better with rendered content size.

Delete oldest/newest entry from opposite end only when total lines approach
ncurses pad limit, minimizing unnecessary deletions.
Simplify overflow warning log by removing unused MAX_BUFFER_SIZE reference.

Update buffer.c header for improved DX:
- Add detailed module overview explaining role (in-memory UI buffer vs. DB
persistence), key features (trimming, metadata), and integration (ncurses).
- Shorten copyright/license boilerplate to concise pointer (LICENSE ref).
- Add fork notice; preserve original copyrights per GPLv3.

Partially addresses #36 (stuck scroll mitigation via fewer cleanups)
Related to #36
jabber.developer manually merged commit 6ad8a19053 into master 2025-10-07 13:37:59 +00:00
jabber.developer changed title from [36] Use dynamic buffer size to prevent unnecessary buffer cleanups to [#36] Use dynamic buffer size to prevent unnecessary buffer cleanups 2025-11-10 06:58:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#37
No description provided.
Delete Branch "fix/buffer-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?