devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

fix(scroll): handle edge case of extremely long messages #38

Manually merged
jabber.developer merged 1 commits from fix/buffer-cleanup into master 2025-10-08 11:21:47 +00:00
Conversation 0 Commits 1 Files Changed 3 +20 -14
jabber.developer commented 2025-10-08 10:55:54 +00:00
Owner
Copy Link

Prior commit (6ad8a190) did not properly handle overflow by long (9000 lines) message,
to address this issue, multiple changes were made:

  • Add lines recalculation on win_redraw
  • Move prof_buff_t struct to header file so its lines could be externally changed
  • Call win_redraw once overflow is detected: it allows to recalculate sizes in lines and apply changes to the buffer
Prior commit (6ad8a190) did not properly handle overflow by long (9000 lines) message, to address this issue, multiple changes were made: - Add lines recalculation on win_redraw - Move `prof_buff_t` struct to header file so its lines could be externally changed - Call win_redraw once overflow is detected: it allows to recalculate sizes in lines and apply changes to the buffer
jabber.developer added 1 commit 2025-10-08 10:55:55 +00:00
fix(scroll): handle edge case of extremely long messages
Some checks failed
CI Code / Check spelling (pull_request) Successful in 19s
Details
CI Code / Check coding style (pull_request) Failing after 34s
Details
CI Code / Linux (arch) (pull_request) Has been cancelled
Details
CI Code / Linux (debian) (pull_request) Has been cancelled
Details
CI Code / Linux (ubuntu) (pull_request) Has been cancelled
Details
7c3f461677 
Prior commit (6ad8a190) did not properly handle overflow by long (9000 lines) message,
to address this issue, multiple changes were made:
- Add lines recalculation on win_redraw
- Move `prof_buff_t` struct to header file so its lines could be externally changed
- Call win_redraw once overflow is detected: it allows to recalculate sizes in lines and apply changes to the buffer
jabber.developer force-pushed fix/buffer-cleanup from 7c3f461677 to fac1e224bc 2025-10-08 11:00:49 +00:00 Compare
jabber.developer manually merged commit fac1e224bc into master 2025-10-08 11:21:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#38
No description provided.
Delete Branch "fix/buffer-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?