devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

fix(cmd): increase /connect max args from 7 to 9 #65

Manually merged
jabber.developer merged 1 commits from fix/connect_max_args into master 2026-01-07 09:14:51 +00:00
Conversation 1 Commits 1 Files Changed 1 +2 -1
jabber.developer2 commented 2026-01-06 14:28:46 +00:00
Collaborator
Copy Link

fix(cmd): increase /connect max args from 7 to 9

Description

The /connect command was configured to accept a maximum of 7 arguments, but the actual command syntax requires up to 9 arguments when fully specified:

Argument count: account + server + + port + + tls + <tls_value> + auth + <auth_value> = 9 args

Solution

Updated parse_args max argument count from 7 to 9 in /connect command definition.

Changes

cmd_defs.c: Changed max args from 7 to 9, added explanatory comment

Testing

Verified that /connect with all options now parses correctly
All unit tests pass
All functional tests pass

# fix(cmd): increase /connect max args from 7 to 9 ### Description The /connect command was configured to accept a maximum of 7 arguments, but the actual command syntax requires up to 9 arguments when fully specified: Argument count: account + server + <server> + port + <port> + tls + <tls_value> + auth + <auth_value> = 9 args ### Solution Updated parse_args max argument count from 7 to 9 in /connect command definition. ### Changes cmd_defs.c: Changed max args from 7 to 9, added explanatory comment ### Testing Verified that /connect with all options now parses correctly All unit tests pass All functional tests pass
jabber.developer2 added 1 commit 2026-01-06 14:28:47 +00:00
fix(cmd): increase /connect max args from 7 to 9
All checks were successful
CI Code / Check spelling (pull_request) Successful in 27s
Details
CI Code / Check coding style (pull_request) Successful in 36s
Details
CI Code / Linux (arch) (pull_request) Successful in 14m23s
Details
CI Code / Linux (debian) (pull_request) Successful in 15m33s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 15m46s
Details
88b48000f8 
The /connect command can take: account + server <s> + port <p> + tls <t> + auth <a>
which totals 9 arguments, not 7. This fixes argument parsing for full command usage.
jabber.developer approved these changes 2026-01-07 09:12:58 +00:00
jabber.developer left a comment
Owner
Copy Link

LGTM

LGTM
jabber.developer manually merged commit e31240a4be into master 2026-01-07 09:14:51 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
jabber.developer
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#65
No description provided.
Delete Branch "fix/connect_max_args"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?