Bug fix: when using tls, if a stanza is bigger than the buffer of 4096 in event.c, the stanza will not be read as select will return 0 on the ssl socket and the data will be in ssl buffers. Partial fix, only for Linux for now
This commit is contained in:
12
src/event.c
12
src/event.c
@@ -85,6 +85,7 @@ void xmpp_run_once(xmpp_ctx_t *ctx, const unsigned long timeout)
|
||||
char buf[4096];
|
||||
uint64_t next;
|
||||
long usec;
|
||||
int tls_read_bytes = 0;
|
||||
|
||||
if (ctx->loop_status == XMPP_LOOP_QUIT) return;
|
||||
ctx->loop_status = XMPP_LOOP_RUNNING;
|
||||
@@ -215,6 +216,11 @@ void xmpp_run_once(xmpp_ctx_t *ctx, const unsigned long timeout)
|
||||
break;
|
||||
}
|
||||
|
||||
/* Check if there is something in the SSL buffer. */
|
||||
if (conn->tls) {
|
||||
tls_read_bytes += tls_pending(conn->tls);
|
||||
}
|
||||
|
||||
if (conn->sock > max) max = conn->sock;
|
||||
|
||||
connitem = connitem->next;
|
||||
@@ -232,8 +238,8 @@ void xmpp_run_once(xmpp_ctx_t *ctx, const unsigned long timeout)
|
||||
}
|
||||
|
||||
/* no events happened */
|
||||
if (ret == 0) return;
|
||||
|
||||
if (ret == 0 && tls_read_bytes == 0) return;
|
||||
|
||||
/* process events */
|
||||
connitem = ctx->connlist;
|
||||
while (connitem) {
|
||||
@@ -262,7 +268,7 @@ void xmpp_run_once(xmpp_ctx_t *ctx, const unsigned long timeout)
|
||||
|
||||
break;
|
||||
case XMPP_STATE_CONNECTED:
|
||||
if (FD_ISSET(conn->sock, &rfds)) {
|
||||
if (FD_ISSET(conn->sock, &rfds) || (conn->tls && tls_pending(conn->tls))) {
|
||||
if (conn->tls) {
|
||||
ret = tls_read(conn->tls, buf, 4096);
|
||||
} else {
|
||||
|
||||
@@ -37,6 +37,7 @@ int tls_stop(tls_t *tls);
|
||||
|
||||
int tls_error(tls_t *tls);
|
||||
|
||||
int tls_pending(tls_t *tls);
|
||||
int tls_read(tls_t *tls, void * const buff, const size_t len);
|
||||
int tls_write(tls_t *tls, const void * const buff, const size_t len);
|
||||
|
||||
|
||||
@@ -68,6 +68,11 @@ int tls_error(tls_t *tls)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int tls_pending(tls_t *tls)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
int tls_read(tls_t *tls, void * const buff, const size_t len)
|
||||
{
|
||||
return -1;
|
||||
|
||||
@@ -107,6 +107,11 @@ int tls_error(tls_t *tls)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int tls_pending(tls_t *tls)
|
||||
{
|
||||
return gnutls_record_check_pending (tls->session);
|
||||
}
|
||||
|
||||
int tls_read(tls_t *tls, void * const buff, const size_t len)
|
||||
{
|
||||
int ret;
|
||||
|
||||
@@ -152,6 +152,11 @@ int tls_is_recoverable(int error)
|
||||
|| error == SSL_ERROR_WANT_ACCEPT);
|
||||
}
|
||||
|
||||
int tls_pending(tls_t *tls)
|
||||
{
|
||||
return SSL_pending(tls->ssl);
|
||||
}
|
||||
|
||||
int tls_read(tls_t *tls, void * const buff, const size_t len)
|
||||
{
|
||||
int ret = SSL_read(tls->ssl, buff, len);
|
||||
|
||||
Reference in New Issue
Block a user