devs/profanity
2
0
Fork 0
mirror of https://git.jabber.space/devs/cproof.git synced 2026-07-18 19:46:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: fix potential NULL dereference and leaks in cmd_sendfile

Browse Source 
* Add NULL checks for malloc and strdup calls in cmd_sendfile
* Ensure file handles and descriptors are closed on all error paths
This commit is contained in:
Michael Vetter
2026-02-26 20:33:13 +01:00
parent 5711671c99
commit 156b78adfa
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/command/cmd_funcs.c
View File

@@ -4869,6 +4869,11 @@ cmd_sendfile(ProfWin* window, const char* const command, gchar** args)
}
FILE* fh = fdopen(fd, "rb");
if (!fh) {
cons_show_error("Unable to open file descriptor for '%s'.", filename);
close(fd);
goto out;
}
if (omemo_enabled) {
#ifdef HAVE_OMEMO
@@ -4878,12 +4883,23 @@ cmd_sendfile(ProfWin* window, const char* const command, gchar** args)
if (err != NULL) {
cons_show_error(err);
win_println(window, THEME_ERROR, "-", err);
if (fh) {
fclose(fh);
}
goto out;
}
#endif
}
HTTPUpload* upload = malloc(sizeof(HTTPUpload));
if (!upload) {
cons_show_error("Memory allocation failed.");
if (fh) {
fclose(fh);
}
goto out;
}
upload->window = window;
upload->filename = strdup(filename);
@@ -4891,6 +4907,17 @@ cmd_sendfile(ProfWin* window, const char* const command, gchar** args)
upload->filesize = file_size(fd);
upload->mime_type = file_mime_type(filename);
if (!upload->filename || !upload->mime_type) {
cons_show_error("Memory allocation failed.");
if (fh) {
fclose(fh);
}
free(upload->filename);
free(upload->mime_type);
free(upload);
goto out;
}
if (alt_scheme != NULL) {
upload->alt_scheme = strdup(alt_scheme);
} else {