early exit here would lower the nesting and potentially improve readability
Here and in other places, can we return necessary documentation detailing DB fields, decisions, and other useful points?
We might want to also check integrity of the tables (whether they exist + maybe even their columns). But it would introduce further complexity and should be a subject of a separate issue.
This lines copies functionality of original database.c and shouldn't cause issues.
Checked cmd_funcs.c:6676:
if (g_strcmp0(arg, "on") == 0) {
cons_show("Logging enabled.");
prefs_set_string(PREF_DBLOG, arg);
prefs_set_boolea…
Acceptance criteria:
- basic functionality works
- OMEMO chat
- OTR chat
- PGP chat
- editor (incl.
alt+c) works in async without issues with nano, vim - OTR works with other CProof…
it wasn't addressed. The pointer still is not set to null, though with this function we can't actually do it, I guess. We need to pass pointer to pointer to actually do it. Instead, we can at…
If it wasn't changed, it might've lead to the bug, because previous assignment would've led to overflow of the pos, thus creating contradicting condition (pos < 0 always false).