We also clean it on line 138. Potential for double free. We need to set it to NULL in resource.c for safety. At least the resource itself.
Most of the messages will have this value as NULL. Luckily, SQLite treats them as unique values.
Nice job. I generally tried to make less comments to avoid unnecessary increase in the workload, but there are many places which are incompatible with our code style/approach.
Without (int) typecasting, _tabs_width always returns result > 0. And it's so hard to maintain such part since we need to keep in mind that result is unsigned. It's a hack rather than a normal implementation. I suggest we revert these changes: they decrease maintainability, and reduce compiler's ability to detect issues.
Notes:
After review by @jabber.developer2, it was decided to use source /etc/makepkg.conf method instead. It was also tested via the same method. Results:
- [without](https://git.jabber.space/…
As expected, build failed on Arch (only on Arch, confirming that Ubuntu and Debian are not affected). Code Coverage job has also failed due to the fact that it's also run on Arch. Collision and…
Last build should fail, indicating parity with Pikaur builds