jabber.developer
  • Joined on 2025-06-19
jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

the logic seemingly mirrors the one from _ff_state_build, creating repetition. I suggest extracting it to a different method to keep things DRYer and more maintainable

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

we should be careful with LMC, since it can be disabled by user, so this part needs further review and discussion.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

general note: LMC is an optional feature. If it's disabled and the log is refetched, it should not be applied.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Please, extract bom-check to a different method. it is violates DRY and SRP. database_flatfile_validate.c:123

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Same issue as earlier with copyright. We are not affiliated with Profanity.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

what if *(close + 1) overflows?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

please, consider reduction of nesting

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Instead of loop, we can do something like that:

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

note: is it null safe?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Please, extract bom-check to a different method. it is violates DRY and SRP. Repeated in database_flatfile.c:163

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Is it a wrong offset or is it gitea's UI bug? It appears that the line is overly offset to the right, violating general formatting

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

While the comment is useful, it violates general style of this example. I suggest moving documentation to more appropriate places.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

`on

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Does the switch automatically export/import? It is unclear from documentation.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

Typically, prefs are not autosaved and need manual saving via /save command. This place creates an exception, which needs to be discussed (e.g., later we might add /autosave command).

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

here and in other places: if the method does not exists, then it just passes. I think that we need to log this invalid state.

jabber.developer approved devs/cproof#94 2026-03-25 13:39:46 +00:00
no-DB mode implementation

While the code has a lot of merits, certain parts should be adjusted to follow the best practices, as well as to correct logic. Specific parts would require further discussion.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

why not auto_char instead of free'ing?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

O_APPEND won't execute since O_EXCL would throw an error if file already exists.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

will fail silently if no err is present.