jabber.developer
  • Joined on 2025-06-19
jabber.developer commented on pull request devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

100 is a magic number; it should be defined as a constant where explanation could be provided

jabber.developer commented on pull request devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

here and later magic numbers

jabber.developer commented on pull request devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

It was a useful explanation, I do not see a good reason to remove it.

jabber.developer commented on pull request devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

Again comment reflects the change rather then adding the context to the code. It would make more sense to write why we setup this specific value prior to firing the tests (e.g., to ensure consistent output)

jabber.developer commented on pull request devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

The comment again reflects the change, though it also provides the context. However, I am not sure if it needs to stay. This context could be moved to the git commit message, which could later be checked via blame by anyone who plans to change this part.

jabber.developer suggested changes for devs/cproof#103 2026-03-12 14:15:30 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

Generally good, but a few fixes later it's going to be much better

jabber.developer closed issue devs/cproof#85 2026-03-07 10:58:08 +00:00
Make security audit for CWE-134
jabber.developer merged pull request devs/cproof#98 2026-03-07 10:57:50 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit
jabber.developer commented on pull request devs/cproof#98 2026-03-07 10:23:58 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

I guess we can call is a defensive programming.

jabber.developer merged pull request devs/cproof#101 2026-03-05 17:36:22 +00:00
CI: Separate docker build and test steps
jabber.developer approved devs/cproof#101 2026-03-05 17:35:38 +00:00
CI: Separate docker build and test steps

The change improves observability, which is always nice to see. I don't see any issues with it, so it's getting merged ASAP.

jabber.developer commented on pull request devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

What about gchar?

jabber.developer commented on pull request devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

It doesn't make sense to do it this way. Condition is still duplicated.

jabber.developer commented on pull request devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

same as above

jabber.developer commented on pull request devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

Again comment style issue. Also I do not see a point in this scope

jabber.developer commented on pull request devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

Condition above if (g_slist_length(a) != g_slist_length(b)) { should normally prevent this scenario. It would be strange if one list is going to finish earlier than another one.

jabber.developer suggested changes for devs/cproof#98 2026-03-05 17:32:45 +00:00
fix: CWE-134 format string vulnerability and compiler flags audit

Really nice change overall. I have some question marks in certain places + wording of commit message ( (INT_MIN = -2147483648 needs 12 bytes including NUL) (instead of NULL-terminator) slightly confused me. Nonetheless, great job. Just fix the minor issues that were pointed out and it's ready to merge.

jabber.developer commented on issue devs/cproof#84 2026-03-04 11:53:00 +00:00
Add tests for XEP-0030 Service Discovery

Resolved by #88

jabber.developer closed issue devs/cproof#84 2026-03-04 11:53:00 +00:00
Add tests for XEP-0030 Service Discovery