jabber.developer
  • Joined on 2025-06-19
jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

why not auto_char instead of free'ing?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

nit: This method is quite fat. In some sense, it's needed for coherency, but I might've overlooked some potential issues with early returns. If possible, I suggest extracting at least body of the cycle.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

note to check: do we sort by timestamp when we fetch from the sqlite? Or is it default sorting by id which presumes that all messages are in order?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

total_skipped is unused variable

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

the issue doesn't appear to be pure debug level, but rather warn at the very least

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

why g_free if key is char? Normally, we do this:

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

We can't just print Exported %s... to user after this case. It's a error and should be handled as such.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

nit: this conversion is done twice (see l463: auto_gchar gchar* ts = msg->timestamp ? g_date_time_format_iso8601(msg->timestamp) : g_strdup("");).

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

Same issue as earlier with copyright. We are not affiliated with Profanity.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

O_APPEND won't execute since O_EXCL would throw an error if file already exists.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

again no overflow check

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

please add comment explaining purpose

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

Are !dt and !space cases ok to be ignored?

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

It future, this requirement should be removed as it doesn't make much sense. Offline capabilities are really lacking. But I see why it exists (local SQLite is getting disconnected on disconnect).

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

Nice nesting: everything is flat. Easy to read, easy to maintain.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

nit: It might be more readable if it's in the separate method. I suggest extraction of the error printing in a separate method.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

We are not affiliated with Profanity.

jabber.developer commented on pull request devs/cproof#94 2026-03-25 13:39:45 +00:00
no-DB mode implementation

will fail silently if no err is present.

jabber.developer commented on pull request devs/cproof#103 2026-03-12 15:33:52 +00:00
perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools

it feels like it could substituted with prof_timeout_reset to deduplicate code.