jabber.developer

jabber.developer commented on issue devs/cproof#112

2026-06-20 10:55:51 +00:00

Follow-up issues for PR #105

Fixed by #130

jabber.developer closed issue devs/cproof#112

2026-06-20 10:55:51 +00:00

Follow-up issues for PR #105

jabber.developer commented on issue devs/cproof#39

2026-06-20 10:54:47 +00:00

OMEMO issues

TODO: retest after merge

jabber.developer merged pull request devs/cproof#130

2026-06-20 10:30:41 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

jabber.developer closed issue devs/cproof#109

2026-06-20 10:30:41 +00:00

Reenable build flags

jabber.developer pushed to master at devs/cproof

2026-06-20 10:30:27 +00:00

830479cf20 fix: OTR/presence/OMEMO correctness, stanza-id disco gate, build hardening

jabber.developer approved devs/cproof#130

2026-06-20 10:01:50 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

LGTM

jabber.developer pushed to fix/pad-dead-space-reclaim at devs/cproof

2026-06-20 09:42:40 +00:00

5acd062c2d fix(ui): reclaim pad by dead space instead of absolute height

2d3d1ced71 ref(ui): use MAX utility method for code conciseness and clarity

adb078a3e2 fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

5b45b35b3e refactor: rename argument to avoid C++ keyword conflict

57d79ecf9c fix: add missing parameter types to function declarations

Compare 6 commits »

jabber.developer pushed to master at devs/cproof

2026-06-20 09:41:15 +00:00

2d3d1ced71 ref(ui): use MAX utility method for code conciseness and clarity

jabber.developer pushed to fix/multiline-pad-clip at devs/cproof

2026-06-20 09:40:34 +00:00

2d3d1ced71 ref(ui): use MAX utility method for code conciseness and clarity

jabber.developer pushed to fix/multiline-pad-clip at devs/cproof

2026-06-20 09:38:18 +00:00

b0e486367e ref(ui): use MIN utility method for code conciseness and clarity

adb078a3e2 fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

Compare 2 commits »

jabber.developer pushed to master at devs/cproof

2026-06-20 09:32:53 +00:00

adb078a3e2 fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

jabber.developer approved devs/cproof#136

2026-06-20 09:31:44 +00:00

fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

LGTM

jabber.developer commented on pull request devs/cproof#136

2026-06-20 09:20:03 +00:00

fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

There are guarantees that messages are null-terminated, right?

jabber.developer approved devs/cproof#136

2026-06-20 09:20:03 +00:00

fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

LGTM

jabber.developer commented on pull request devs/cproof#136

2026-06-20 09:20:02 +00:00

fix(ui): reserve pad height per message to prevent multi-line clip and scroll desync

We might also use MIN(1, ...) instead, but this variant is also fine.

jabber.developer commented on pull request devs/cproof#130

2026-06-16 12:02:42 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

That does not appear as an appropriate solution. In debug mode it would crash the app, while in prod it would be ignored. Both ways introduce additional point of failure, further discussion is needed.

jabber.developer commented on pull request devs/cproof#130

2026-06-16 12:02:42 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

The comment explains the nature of change, which is a known antipattern.

jabber.developer commented on pull request devs/cproof#130

2026-06-16 12:02:42 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

g_assert usage should be discussed.

jabber.developer commented on pull request devs/cproof#130

2026-06-16 12:02:42 +00:00

Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

Why is it even defined out of loop scope? We can move it inside of the for body for readability.