jabber.developer
  • Joined on 2025-06-19
jabber.developer commented on pull request devs/cproof#130 2026-06-16 12:02:42 +00:00
Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

nit: Ideally we want more concise 1-2 line comments instead. Further discussion is other required.

jabber.developer commented on pull request devs/cproof#130 2026-06-16 12:02:42 +00:00
Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

I think that cons_show_error would be more appropriate.

jabber.developer suggested changes for devs/cproof#130 2026-06-16 12:02:42 +00:00
Fix: issue #112 follow-ups — OTR strip, presence UAF, OMEMO load

Generally this PR introduces nice improvements. However, I'd like to discuss further the nature of multiple changes to ensure their necessity and alignment with our goals.

jabber.developer merged pull request devs/cproof#8 2026-06-16 11:33:10 +00:00
Light code cleanup
jabber.developer pushed to master at devs/cproof 2026-06-16 11:33:08 +00:00
5b45b35b3e refactor: rename argument to avoid C++ keyword conflict
57d79ecf9c fix: add missing parameter types to function declarations
bfd7064a40 build: add missing includes to header files
Compare 3 commits »
jabber.developer pushed to ref/light-cleanup at devs/cproof 2026-06-16 11:21:25 +00:00
5b45b35b3e refactor: rename argument to avoid C++ keyword conflict
57d79ecf9c fix: add missing parameter types to function declarations
bfd7064a40 build: add missing includes to header files
3f6b8f69fd fix(ui): raise pad redraw threshold above buffer cap to fix history scroll
a04a8948e1 fix(chatwin): only fire plugins_post_chat_message_display on incoming
Compare 16 commits »
jabber.developer pushed to master at devs/cproof 2026-06-08 13:05:09 +00:00
3f6b8f69fd fix(ui): raise pad redraw threshold above buffer cap to fix history scroll
jabber.developer commented on pull request devs/cproof#133 2026-06-08 12:54:25 +00:00
fix(ui): raise pad redraw threshold above buffer cap to fix history scroll

why not use MAX macro from GLib?

jabber.developer pushed to master at devs/cproof 2026-06-01 13:52:39 +00:00
a04a8948e1 fix(chatwin): only fire plugins_post_chat_message_display on incoming
jabber.developer deleted branch fix/editor-ui-suspend-redraw from devs/cproof 2026-06-01 12:22:04 +00:00
jabber.developer closed pull request devs/cproof#131 2026-06-01 12:22:04 +00:00
fix(ui): stop status bar / chat bleed-through over the external editor
jabber.developer pushed to master at devs/cproof 2026-06-01 12:22:02 +00:00
c1093db090 fix(editor): prevent UI redraw conflicts during editor suspend/resume
jabber.developer commented on pull request devs/cproof#131 2026-05-31 11:47:55 +00:00
fix(ui): stop status bar / chat bleed-through over the external editor

comments are still too verbose. Let's keep implementation details within commit messages.

jabber.developer commented on pull request devs/cproof#131 2026-05-31 11:47:55 +00:00
fix(ui): stop status bar / chat bleed-through over the external editor

Please extract this functionality to a different method if possible. Let's keep main loop minimal.

jabber.developer closed pull request devs/cproof#19 2026-05-30 13:02:43 +00:00
WIP: Reenable Fedora tests
jabber.developer commented on pull request devs/cproof#104 2026-05-30 13:01:58 +00:00
WIP: feat/upstream-sync

Merged in #105

jabber.developer closed pull request devs/cproof#104 2026-05-30 13:01:58 +00:00
WIP: feat/upstream-sync
jabber.developer commented on pull request devs/cproof#131 2026-05-29 19:11:36 +00:00
fix(ui): stop status bar / chat bleed-through over the external editor

is it safe from infinite looping?

jabber.developer commented on pull request devs/cproof#131 2026-05-29 19:11:36 +00:00
fix(ui): stop status bar / chat bleed-through over the external editor

excessive comment length