7623 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jabber Developer	0feacbc9da	ci: simulate Pikaur flag duplication in Arch Linux CI ... Inject system flags from /etc/makepkg.conf into the CI environment to detect build collisions caused by Pikaur's configuration bug. Pikaur's cascading logic causes flags from /etc/makepkg.conf to be merged into the build environment. This creates collisions with flags defined in the project's Makefile.am (e.g., duplicate -D_FORTIFY_SOURCE definitions), which can cause builds to fail for users. By exporting these flags in the CI environment, we ensure that any code change that is sensitive to flag duplication will trigger a failure in our Arch Linux CI matrix, preventing broken builds from reaching users. Implementation details: - Detects Arch Linux via /etc/os-release. - Uses a sed-based flattener to handle multi-line variables and trailing backslashes in makepkg.conf. - Exports the flags to the shell environment so that 'configure' and 'make' inherit them naturally, maintaining parity with a real Pikaur session.	2026-04-21 10:17:44 +00:00
jabber.developer	0722dc9e36	build(pikaur): Fix failure due to duplicated flag and warnings	2026-04-13 19:52:24 +00:00
jabber.developer2	f84ed1bf6a	perf(functests): speedup — profrc pre-baking, pty-close shutdown, parallel port pools ... Replace 16 interactive UI setup commands with pre-written profrc file containing [ui] and [notifications] sections (~1800ms saved per test). Replace sleep(1) + blocking waitpid with close(pty fd) → SIGHUP → polling waitpid(WNOHANG) → SIGTERM/SIGKILL fallback chain (~4900ms saved per test). Remove post-stbbr_start() and post-stbbr_stop() sleeps — bind+listen completes synchronously before stbbr_start() returns, and pthread_join() in stbbr_stop() guarantees socket cleanup (~200ms saved). Add PORTS_PER_GROUP=50 isolated port ranges per test group to enable safe parallel execution of 4 groups without port conflicts.	2026-03-12 18:20:35 +03:00
Jabber Developer	9ec01fa8cc	fix: CWE-134 format string audit and compiler hardening ... Security: Fix CWE-134 in iq.c: user-controlled string passed as format argument Add G_GNUC_PRINTF annotations to all variadic printf-like wrappers in ui.h, log.h and http_common.h Compiler flags (configure.ac): Replace basic -Wformat/-Wformat-nonliteral with -Wformat=2 Add -Wextra, -Wnull-dereference, -Wpointer-arith, -Wimplicit-function-declaration, -Wundef, -Wfloat-equal, -Wredundant-decls, -Walloc-zero Add -fstack-protector-strong, -fno-common, -D_FORTIFY_SOURCE=2 Add GCC-specific flags via AC_COMPILE_IFELSE: -Wlogical-op, -Wduplicated-cond, -Wduplicated-branches, -Wstringop-overflow, -Warray-bounds=2 Suppress noisy -Wextra sub-warnings: -Wno-unused-parameter, -Wno-missing-field-initializers, -Wno-sign-compare, -Wno-cast-function-type Remove AM_CFLAGS/CFLAGS duplication Bug fixes found by new warnings: chatlog.c: non-MUCPM redact path passed resourcepart instead of NULL rosterwin.c: merge duplicated if/else branches into single condition omemo.c: redundant else-if in omemo_automatic_start; remove unnecessary scope block and goto, use early return console.c: pointer compared to integer 0 instead of NULL stanza.c: increase pri_str/idle_str buffers from 10 to 12 bytes (INT_MIN = -2147483648 needs 12 bytes including NUL) vcard.c: NULL guard for filename before g_file_set_contents api.c: broken log_warning() calls with extra format argument Format mismatch fixes: chatwin.c: Jid* → char* for %s connection.c: %x → %lx for long flags cmd_funcs.c: %d → %zu for size_t; cast gpointer to char* for %s cmd_defs.c: %d → %u for g_list_length() return (guint) iq.c: barejid → fulljid for from_jid console.c, mucwin.c, privwin.c, account.c, omemo.c, presence.c: gpointer → (char*) casts for %s Const-correctness and cleanup: database.c: const for type, query, sort variables form.c/xmpp.h: const for form_set_value parameter files.c: refactor to early return, eliminating NULL logfile path muc.c/muc.h: remove meaningless top-level const on return type common.c: const for URL string literal Remove stale declarations: cons_show_desktop_prefs (ui.h), connection_set_priority (connection.h), omemo_devicelist_configure_and_request (omemo.h) test_common.c: add currb NULL check to silence -Wnull-dereference Tooling (check-cwe134.sh): Reduce from 5 checks to 2 (checks 1-3 redundant with -Wformat=2) Check 1: verify known wrappers have G_GNUC_PRINTF attribute Check 2: auto-detect unannotated variadic printf-like functions Match both const char* and const gchar* in variadic patterns Author: jabber.developer2 <jabber.developer2@jabber.space>	2026-03-07 11:55:50 +01:00
Jabber Developer	1508f27e73	Merge branch 'ci/separate-build-step'	2026-03-05 18:36:13 +01:00
jabber.developer2	d4254db814	CI: Separate build and test steps	2026-03-04 23:04:51 +03:00
jabber.developer2	9e1b95a814	test(disco): remove disco_items_error_handling test ... This test requires the fix from fix/xep-0030-disco-items-error-handling branch. Moved there along with the source code fix.	2026-03-03 16:57:35 +01:00
jabber.developer2	24e1dac354	test(disco): add comprehensive XEP-0030 functional tests ... Add 7 new tests for /disco command: - disco_items_to_jid: query items to specific JID - disco_info_empty_result: handle empty disco#info response - disco_info_multiple_identities: multiple identity elements - disco_info_without_name: identity without optional name attr - disco_items_without_name: items without optional name attr - disco_info_service_unavailable: error handling for info - disco_items_error_handling: error handling for items (XEP-0030 §7) The disco_items_error_handling test documents a bug where disco#items errors are silently ignored (unlike disco#info which handles them). This violates XEP-0030 Section 7 which requires error feedback to user.	2026-03-03 16:57:35 +01:00
jabber.developer2	f20a4da160	Add functional tests for /disco command (XEP-0030) ... - Add 8 tests for disco info and disco items commands - Fix XEP-0030 compliance bug: show message for empty disco#items results - Tests cover: identity display, features, server/jid queries, error handling, items display, empty results, and connection requirement	2026-03-03 16:57:35 +01:00
jabber.developer2	663a959f9c	test: add functional tests for autoping (XEP-0199) ... - autoping_set_interval: verify /autoping set command - autoping_set_zero_disables: verify disabling autoping - autoping_timeout_set: verify /autoping timeout command - autoping_timeout_zero_disables: verify disabling timeout - autoping_sends_ping_after_interval: verify automatic ping IQ - autoping_server_not_supporting_ping: verify error handling Fast tests (command parsing) in Group 1, slow tests (timer-based) in Group 3.	2026-03-03 16:57:35 +01:00
Jabber Developer	31538580fb	fix arch build	2026-02-18 17:39:25 +01:00
Jabber Developer	37ca2de308	ci: fix arch build	2026-02-17 16:30:52 +01:00
jabber.developer2	4fce333c9a	fix(xmpp): show message for empty disco#items results (XEP-0030) ... Per XEP-0030 section 3.1: 'if an entity has no associated items, it MUST return an empty <query/> element.' The client should display 'No service discovery items for X' when receiving an empty result, not silently ignore it. Previous version introduced in commit f28655c5c (2016-05-08) which added an early return when child == NULL, preventing the message from being shown.	2026-02-11 01:10:55 +03:00
Jabber Developer	467222d0ca	fix(ui,db): harden NULL handling, fix CWE-134, optimize iterations ... security(CWE-134): fix format string injections + add CI check fix(ui): subwindow lifecycle, newwin/newpad guards, fallback timestamps fix(db): sqlite cleanup on failures, sqlite3_close_v2 fix(xmpp): queued_messages loop, barejid leak perf(core): g_hash_table_iter_init instead of g_hash_table_get_keys refactor(ui): CLAMP macro in _check_subwin_width test: XEP-0012 and XEP-0045 functional tests Author: jabber.developer2 Closes #58, #85	2026-02-06 19:27:40 +01:00
Jabber Developer	f8826b7c79	ci: improve CI stability with parallel builds and Valgrind ... Major changes: Run 4 build configurations in parallel with Valgrind on Linux Add test failure detection verification (meta-test) Port allocation per build to prevent conflicts in parallel runs Add --coverage-only flag for dedicated coverage builds Code quality: Add TEST_GROUPS constant, CMOCKA patterns, helper functions Organize ci-build.sh into sections	2026-02-02 17:47:05 +01:00
Jabber Developer	8353a29b4f	fix(ci): remove insecure git clone flag, add ca-certificates ... Remove -c http.sslverify=false from all git clones (enables proper TLS verification, closes MITM risk). Explicitly install ca-certificates in every CI Docker image.	2026-01-21 17:10:37 +01:00
Jabber Developer	85c817ee8c	ci: speed up builds 4x with parallel tests, coverage, and ccache ... Split functional tests into 4 parallel groups and add check-functional-parallel target (~3x faster CI runs). Add branch-aware LCOV coverage reporting with new --enable-coverage option and lcov summary in CI pipeline. Enable ccache via -C configure flag for faster recompilations. Install lcov in all Docker images and use --depth 1 git clones + parallel make -j$(nproc) for quicker container builds. Update CONTRIBUTING.md with instructions for parallel test groups and adding new ones. All changes are tightly related CI/performance improvements developed in sequence. No external service uploads (e.g. Codecov skipped due to Gitea incompatibility).	2026-01-21 16:35:17 +01:00
jabber.developer2	a90eef1cb2	docs: update CONTRIBUTING.md to clarify functional test guidelines	2026-01-07 11:46:40 +01:00
jabber.developer2	48ab4b9360	feat: add Valgrind suppressions and update CI/docs ... - Add prof.supp with pthread TLS suppressions - Update ci-build.sh with test configurations - Document functional test best practices in CONTRIBUTING.md	2026-01-07 11:46:40 +01:00
jabber.developer2	8f580f91a8	refactor(tests): migrate to content-based stubbing ... - Replace stbbr_for_id() with stbbr_for_query()/stbbr_send() - Content-based stubbing matches stanzas by namespace instead of ID - Use regex assertions for flexible output matching - Fix timing issues in chat_session and presence tests	2026-01-07 11:46:40 +01:00
jabber.developer2	2d7de2caf6	refactor(tests): replace libexpect with forkpty() for PTY handling ... - Remove dependency on libexpect/tcl - Implement native PTY handling with forkpty() - Add prof_output_exact/regex for flexible output matching - Improve timeout handling and synchronization	2026-01-07 11:46:40 +01:00
jabber.developer2	889a6e2b63	build: enable functional tests unconditionally ... - Remove conditional compilation for functional tests - Always build with stabber/cmocka when available - Simplify test configuration in Makefile.am	2026-01-07 11:46:40 +01:00
jabber.developer2	44de29a199	build(docker): add TERM env, fix SSL and reflector handling ... - Add TERM=xterm-256color for PTY support in functional tests - Disable SSL verification for git clone in restricted networks - Add error handling for Arch reflector installation	2026-01-07 11:46:40 +01:00
Jabber Developer	e31240a4be	Merge branch 'fix/connect_max_args'	2026-01-07 10:14:38 +01:00
jabber.developer2	88b48000f8	fix(cmd): increase /connect max args from 7 to 9 ... The /connect command can take: account + server <s> + port <p> + tls <t> + auth <a> which totals 9 arguments, not 7. This fixes argument parsing for full command usage.	2026-01-06 17:22:53 +03:00
Jabber Developer	f446f48d07	feat(ui,window): add accurate unread indicators and history paging support ... - Track unread message indicators and paging state in the window component - Clear and restore unread markers correctly when navigating between conversations - Suppress buffer updates and message printing while viewing history to prevent unwanted scroll jumps and viewport lock Also includes minor code-style, whitespace, and comment cleanups as well as updated documentation for metrics and buffer handling.	2025-12-02 17:59:25 +01:00
jabber.developer2	20af44196b	fix(cmd): cmd_time: Avoid extra loop iterations for single option	2025-11-27 11:38:49 +01:00
Jabber Developer	84d6253561	fix(xmpp): format debug logging statements for consistency ... Add debug output tracking connection lifecycle. - Track disconnects and reconnects - Record session login, logout, and reconnection attempts - Use [CONNDBG] tag for easy log filtering	2025-11-21 10:03:50 +01:00
Jabber Developer	74cfd32c1e	Improve arch build: sort mirrors by speed in reflector	2025-10-29 20:45:37 +01:00
Jabber Developer	fe6912a30c	Fix arch build by adding pacman-key --init and updating gtk2 to gtk3	2025-10-29 20:27:55 +01:00
Jabber Developer	266f5aa046	feat(api): add get_current_window call ... Add prof_get_current_window API to retrieve the title of the currently active window, matching the titlebar display. The feature is especially useful to track currently used plugin window.	2025-10-20 19:00:48 +02:00
Jabber Developer	3738be4af1	fix: prevent autoping disable on false negative ping support check ... Remove autodisable logic (prefs_set_autoping(0)) and early return in autoping to treat intermittent false negatives from connection_supports(XMPP_FEATURE_PING). Add one-time error display with debug features print for monitoring; warn on first failing check without aborting to maintain functionality while investigating root cause.	2025-10-14 12:42:00 +02:00
Jabber Developer	ad95edb2b9	feat: make /log level work with non-default files	2025-10-13 20:47:34 +02:00
Jabber Developer	fac1e224bc	fix(scroll): handle edge case of extremely long messages ... Prior commit (6ad8a190) did not properly handle overflow by long (9000 lines) message, to address this issue, multiple changes were made: - Add lines recalculation on win_redraw - Move `prof_buff_t` struct to header file so its lines could be externally changed - Call win_redraw once overflow is detected: it allows to recalculate sizes in lines and apply changes to the buffer	2025-10-08 13:00:32 +02:00
Jabber Developer	6ad8a19053	fix(buffer): use dynamic buffer size to prevent unnecessary buffer cleanups ... Refactor buffer trimming logic to use dynamic line counts (_lines per entry) against PAD_SIZE (10k) instead of fixed entry count (MAX_BUFFER_SIZE=200). This prevents premature cleanups for short messages, reduces scrolling disruptions during history loads, and scales better with rendered content size. Delete oldest/newest entry from opposite end only when total lines approach ncurses pad limit, minimizing unnecessary deletions. Simplify overflow warning log by removing unused MAX_BUFFER_SIZE reference. Update buffer.c header for improved DX: - Add detailed module overview explaining role (in-memory UI buffer vs. DB persistence), key features (trimming, metadata), and integration (ncurses). - Shorten copyright/license boilerplate to concise pointer (LICENSE ref). - Add fork notice; preserve original copyrights per GPLv3. Partially addresses #36 (stuck scroll mitigation via fewer cleanups) Related to #36	2025-10-07 15:12:20 +02:00
Jabber Developer	40dd773c6a	docs(apidocs/c): improve profapi.h and profhooks.h comments ... - Enhanced file-level comments with concise descriptions - Added usage examples and aligned with Python prof module style - Updated function comments to remove tables, improve clarity - Replaced Profanity with CProof, preserved paths and method names	2025-09-23 14:07:32 +02:00
Jabber Developer	8849d9b79e	docs: move callbacks down ... To improve readability of the docs	2025-09-22 23:05:45 +02:00
Jabber Developer	92cb930810	docs: Fix indentation	2025-09-17 01:37:10 +02:00
Jabber Developer	9fd62e2304	ci: restructure and optimize execution conditions ... - The code tests will ignore doc changes and vice versa. - The CI is split in 2 parts for clarity	2025-09-17 01:00:30 +02:00
Jabber Developer	c94263486f	docs(python): fix formatting to ensure correct parsing ... Fixes issues introduced in 052e168, 4cdcf9a, and other commits from PR #31.	2025-09-17 00:34:37 +02:00
Jabber Developer	353b6bdb11	Merge branch 'build/add-api-docs-gen-tests'	2025-09-15 16:54:33 +02:00
Jabber Developer	105c496ab1	docs(sphinx): fix conf.py and index.rst to resolve warnings ... - Removed unnecessary list item (*) from :ref:`genindex`. - Added blank line after :ref:`genindex` to terminate markup block. - Rebranded configs	2025-09-15 16:12:47 +02:00
Jabber Developer	cb6f302208	docs(prof.py): add CommandCallback, TimedCallback, WindowCallback protocols ... - Defined callback protocols for register_command, register_timed, win_create. - Fixed Sphinx callable warnings with proper type hints. - Align docs with the code	2025-09-15 15:47:10 +02:00
Jabber Developer	4cdcf9a8eb	docs(plugin): update plugin.py to align with formatting required by Sphinx ... - Replace Profanity with CProof in all docstrings and examples. - Remove Python 2 and unicode references, using Python 3 str types. - Add type hints for all parameters and return types. - Use :: for code blocks with blank lines to fix Sphinx errors. - Improve wording for clarity and integrated examples into docstrings. - Organize functions into logical sections with RST comments. - Use double backticks for inline literals to resolve Sphinx warnings.	2025-09-15 11:53:49 +02:00
Jabber Developer	7e4c60e2c3	ci(Doxygen): Enable warning as error ... To ensure that CI builds fails to reflect issues within the documentations	2025-09-10 19:38:24 +02:00
Jabber Developer	e998d5e7ef	docs: fix C API documentation ... `barejid` parameter was used instead of the intended `roomjid`, leading to warnings during compilation.	2025-09-10 19:35:21 +02:00
Jabber Developer	3ffeda1531	ci: Disable Doxygen HTML generation ... Since only XML is being used during website build process, generation of HTML involves unnecessary computations.	2025-09-10 19:32:34 +02:00
Jabber Developer	a4cead7fe8	ci: Update doxygen config file via doxygen -u	2025-09-10 19:30:24 +02:00
Jabber Developer	052e168e9b	docs(prof.py): overhaul documentation to align with Google Python Style Guide ... - Updated project references from Profanity to CProof. - Removed Python 2 and unicode references. - Added type hints for all parameters and return types. - Organized functions into logical sections with RST comments for Sphinx. - Improved wording for clarity and precision based on source code analysis. - Ensured compliance with Google Python Style Guide for readable docstrings. Related to #30	2025-09-10 19:05:33 +02:00
Jabber Developer	c94cd0b549	ci: add GitHub Actions workflow to test C and Python API doc generation ... Introduce separate jobs to test C (Doxygen) and Python (Sphinx) API documentation generation. Ensures build failures are caught early, as API changes often produce warnings that developers miss without automated checks.	2025-09-10 19:05:32 +02:00