tests: add functional tests for DB message persistence, rebalance groups

Add backend-agnostic functional tests for database message persistence.
All tests work with both SQLite and flat-file backends.

New tests in test_history.c:
- message_db_history_on_reopen: basic incoming write+read round-trip
- message_db_history_multiple: 3 messages from different resources
- message_db_history_contact_isolation: buddy1 msg absent from buddy2
- message_db_history_special_chars: XML entities survive decode+DB
- message_db_history_outgoing: sent message persists across reopen
- message_db_history_dialog: outgoing + incoming both in history
- message_db_history_empty: no crash on contact with no history
- message_db_history_long_message: 1000+ char body not truncated
- message_db_history_newline: embedded LF stored correctly
- message_db_history_service_chars: backslash pipe percent braces etc
- message_db_history_verify: /history verify (ifdef HAVE_HISTORY_VERIFY)
- message_db_history_lmc: XEP-0308 correction replaces original in DB

Rebalance test groups for parallel execution (19/22/22/21):
- Group 1: Connect, Ping, Rooms, Software, LastActivity
- Group 2: Message, Receipts, Roster, DB History
- Group 3: Chat Session, Presence, Disconnect
- Group 4: MUC, Carbons

.github/workflows/ci-code.yml

@@ -50,6 +50,9 @@ jobs:
         run: |
           grep -P 'auto_(char|gchar|gcharv|guchar|jid|sqlite|gfd|FILE)[\w *]*;$' -r src && exit -1 || true
 
+      - name: Check CWE-134 format string vulnerabilities
+        run: ./check-cwe134.sh
+
       - name: Install clang-format
         run: |
           sudo apt-get update
@@ -106,20 +109,5 @@ jobs:
       - uses: actions/checkout@v4
       - name: Build and run coverage
         run: |
-          docker build -f Dockerfile.debian -t profanity-cov .
-          docker run -v ${{ github.workspace }}/coverage:/coverage profanity-cov bash -c '
-            ./bootstrap.sh
-            ./configure --enable-coverage --enable-otr --enable-pgp --enable-omemo --enable-plugins
-            make -j$(nproc)
-            make check || true
-            make check-functional-parallel || true
-            lcov --capture --directory . --output-file /coverage/coverage.info \
-              --rc branch_coverage=1 \
-              --ignore-errors inconsistent
-            lcov --remove /coverage/coverage.info \
-              "/usr/include/*" "*/tests/*" \
-              --output-file /coverage/coverage.info \
-              --rc branch_coverage=1 \
-              --ignore-errors inconsistent,empty,unused
-            lcov --summary /coverage/coverage.info
-          '
+          docker build -f Dockerfile.arch -t profanity-cov .
+          docker run profanity-cov ./ci-build.sh --coverage-only

.gitignore

@@ -62,6 +62,8 @@ tests/unittests/unittests
 tests/unittests/unittests.log
 tests/unittests/unittests.trs
 test-suite.log
+test-files/
+test-logs/
 
 # valgrind output
 profval*
@@ -108,3 +110,7 @@ breaks
 *.zip
 *.log*
 coverage/
+*.gcno
+*.gcda
+*.gcov
+coverage.info

CONTRIBUTING.md

@@ -90,6 +90,24 @@ set -e
 ```
 
 This will run the same tests that the CI runs and refuse the push if it fails.
+The CI script runs 4 parallel builds with different configurations:
+- **Full** — all features enabled (+ coverage in `--coverage-only` mode)
+- **Minimal** — all optional features disabled
+- **NoEncrypt** — no encryption (OTR, PGP, OMEMO disabled)
+- **Default** — default ./configure options
+
+Each build runs Valgrind and functional tests on Linux.
+Use `./ci-build.sh --coverage-only` to run only the Full build with coverage collection.
+
+Output shows test results per build:
+```
+✓ Full PASSED
+  Unit tests:       437 passed, 0 failed
+  Functional tests: 69 passed, 0 failed
+  Coverage:         Lines: 27.5% | Functions: 36.2% | Branches: 18.1%
+  Duration:         5m39s
+```
+
 Note that it will run on the actual content of the repository directory and not
 what may have been staged/committed.
 
@@ -126,6 +144,16 @@ scan-build make
 scan-view ...
 ```
 
+### Security checks
+
+We have a static analyzer `check-cwe134.sh` that detects CWE-134 format string vulnerabilities. It runs automatically in CI but you can also run it locally:
+
+```bash
+./check-cwe134.sh
+```
+
+This checks for unsafe patterns where data could be passed directly as a format string to functions like `printf`, `cons_show`, etc. Never pass a raw string for formatting; use `"%s"` format specifier instead.
+
 ### Finding typos
 
 We include a `.codespellrc` configuration file for `codespell` in the root directory.

Dockerfile.arch

@@ -1,9 +1,10 @@
-FROM archlinux
+FROM archlinux:latest
 
 ENV TERM=xterm
 ENV CC="ccache gcc"
 
-RUN pacman -Syu --noconfirm
+RUN pacman -Syyu --noconfirm
+
 # reflector is optional - if it fails due to network issues, continue with default mirrorlist
 RUN pacman -S --needed --noconfirm reflector && \
     (reflector --latest 20 --protocol https --sort rate --save /etc/pacman.d/mirrorlist || true)

Makefile.am

@@ -185,6 +185,8 @@ functionaltest_sources = \
 	tests/functionaltests/test_software.c tests/functionaltests/test_software.h \
 	tests/functionaltests/test_muc.c tests/functionaltests/test_muc.h \
 	tests/functionaltests/test_disconnect.c tests/functionaltests/test_disconnect.h \
+	tests/functionaltests/test_history.c tests/functionaltests/test_history.h \
+	tests/functionaltests/test_lastactivity.c tests/functionaltests/test_lastactivity.h \
 	tests/functionaltests/functionaltests.c
 
 main_source = src/main.c
@@ -313,7 +315,7 @@ FUNC_TEST_GROUPS = 1 2 3 4
 
 check-functional-parallel: tests/functionaltests/functionaltests
 	@echo "Running functional tests in parallel ($(words $(FUNC_TEST_GROUPS)) groups)..."
-	@mkdir -p $(builddir)/test-logs
+	@mkdir -p $(builddir)/test-logs $(builddir)/test-files
 	@pids=""; \
 	for g in $(FUNC_TEST_GROUPS); do \
 		./tests/functionaltests/functionaltests $$g > $(builddir)/test-logs/group$$g.log 2>&1 & \
@@ -372,7 +374,10 @@ clean-local:
 	rm -f $(git_include) $(git_include).in
 endif
 
-.PHONY: my-prof.supp
+clean-functional-tests:
+	rm -rf $(builddir)/test-files $(builddir)/test-logs
+
+.PHONY: my-prof.supp clean-functional-tests
 my-prof.supp:
 	@sed '/^# AUTO-GENERATED START/q' prof.supp > $@
 	@printf "\n\n# glib\n" >> $@
@@ -388,7 +393,7 @@ check-unit: tests/unittests/unittests
 	tests/unittests/unittests
 
 @VALGRIND_CHECK_RULES@
-VALGRIND_SUPPRESSIONS_FILES=prof.supp
+VALGRIND_SUPPRESSIONS_FILES=$(srcdir)/prof.supp
 
 # Code coverage targets (requires --enable-coverage)
 coverage-clean:

check-cwe134.sh

@@ -0,0 +1,69 @@
+#!/bin/bash
+# check-cwe134.sh - Static analysis for CWE-134 format string vulnerabilities
+#
+# This script detects potentially unsafe usage of format string functions
+# where user-controlled data may be passed without "%s" wrapper.
+#
+# Usage: ./check-cwe134.sh [directory]
+
+set -e
+
+DIR="${1:-src}"
+
+echo "=== CWE-134 Format String Vulnerability Check ==="
+echo "Scanning: $DIR"
+echo ""
+
+# Functions that accept format strings
+FORMAT_FUNCS="cons_show|cons_debug|cons_show_error|log_info|log_error|log_warning|log_debug|win_println|win_print"
+
+ERRORS=0
+
+echo "Checking for unsafe format string usage..."
+echo ""
+
+# Pattern 1: function call with single variable argument (no format string)
+# Example: cons_show(variable);  - BAD
+# Example: cons_show("%s", variable);  - OK
+# Matches: func(identifier) or func(identifier->member) or func(identifier[index])
+RESULTS=$(grep -rn --include="*.c" -P "($FORMAT_FUNCS)\s*\(\s*[a-zA-Z_][a-zA-Z0-9_]*(\s*->\s*\w+|\s*\[\s*\w+\s*\])?\s*\)\s*;" "$DIR" 2>/dev/null || true)
+
+# Filter out function definitions, declarations, and safe api_* wrappers
+RESULTS=$(echo "$RESULTS" | grep -v "const char\|void \|^[^:]*:[0-9]*:[a-z_]*(\|api_cons_show\|api_log_" || true)
+
+if [ -n "$RESULTS" ]; then
+    echo "❌ POTENTIAL CWE-134 VULNERABILITIES FOUND:"
+    echo ""
+    echo "$RESULTS"
+    echo ""
+    ERRORS=$(echo "$RESULTS" | wc -l)
+else
+    echo "✅ No obvious CWE-134 issues found."
+fi
+
+# Additional check: GString->str passed directly (not as %s argument)
+echo ""
+echo "Checking for GString->str passed to format functions..."
+
+GSTRING_RESULTS=$(grep -rn --include="*.c" -P "($FORMAT_FUNCS)\s*\([^)]*->str\s*\)" "$DIR" 2>/dev/null | grep -v '"%s"' || true)
+
+if [ -n "$GSTRING_RESULTS" ]; then
+    echo "⚠️  GString->str passed without \"%s\" (review manually):"
+    echo ""
+    echo "$GSTRING_RESULTS"
+    echo ""
+fi
+
+echo ""
+echo "=== Summary ==="
+echo "Critical issues: $ERRORS"
+
+if [ "$ERRORS" -gt 0 ]; then
+    echo ""
+    echo "Fix by adding \"%s\" format specifier:"
+    echo "  BAD:  cons_show(variable);"
+    echo "  GOOD: cons_show(\"%s\", variable);"
+    exit 1
+fi
+
+exit 0

ci-build.sh

@@ -15,14 +15,72 @@ error_handler()
     log_content ./test-suite.log
     log_content ./test-suite-memcheck.log
 
-    echo
-    echo "Error ${ERR_CODE} with command '${BASH_COMMAND}' on line ${BASH_LINENO[0]}. Exiting."
-    echo
+    echo >&2
+    echo "Error ${ERR_CODE} with command '${BASH_COMMAND}' on line ${BASH_LINENO[0]}. Exiting." >&2
+    echo >&2
     exit ${ERR_CODE}
 }
 
 trap error_handler ERR
 
+# =============================================================================
+# Constants
+# =============================================================================
+
+# Number of parallel build configurations
+readonly TEST_BUILDS=4
+
+# Human-readable names for each build configuration
+readonly BUILD_NAMES=(
+    "Full"      # 1. All features enabled
+    "Minimal"   # 2. All optional features disabled
+    "NoEncrypt" # 3. No encryption (otr, pgp, omemo disabled)
+    "Default"   # 4. Default ./configure options
+)
+
+# Regex patterns for parsing test output
+readonly CMOCKA_PASSED_PATTERN='^\[  PASSED  \] [0-9]+ test'
+readonly CMOCKA_FAILED_PATTERN='^\[  FAILED  \] [0-9]+ test'
+
+# Coverage extraction patterns (matches both Docker and CI paths)
+readonly COVERAGE_PATTERNS='*/profanity/src/* */src/src/*'
+
+# =============================================================================
+# Helper Functions
+# =============================================================================
+
+# Parse STATS line from build log and set global variables
+# Usage: parse_build_stats <log_file>
+parse_build_stats() {
+    local log_file="$1"
+    local stats_line
+    stats_line=$(grep "^STATS:" "$log_file" 2>/dev/null | tail -1)
+    
+    STAT_UNIT_P=$(echo "$stats_line" | grep -oE "unit_passed=[0-9]+" | cut -d= -f2)
+    STAT_UNIT_F=$(echo "$stats_line" | grep -oE "unit_failed=[0-9]+" | cut -d= -f2)
+    STAT_FUNC_P=$(echo "$stats_line" | grep -oE "func_passed=[0-9]+" | cut -d= -f2)
+    STAT_FUNC_F=$(echo "$stats_line" | grep -oE "func_failed=[0-9]+" | cut -d= -f2)
+    STAT_COV_LINES=$(echo "$stats_line" | grep -oE "cov_lines=[0-9.]+%|cov_lines=n/a" | cut -d= -f2)
+    STAT_COV_FUNCS=$(echo "$stats_line" | grep -oE "cov_funcs=[0-9.]+%|cov_funcs=n/a" | cut -d= -f2)
+    STAT_COV_BRANCHES=$(echo "$stats_line" | grep -oE "cov_branches=[0-9.]+%|cov_branches=n/a" | cut -d= -f2)
+    STAT_TIME=$(echo "$stats_line" | grep -oE "time=[0-9]+m[0-9]+s" | cut -d= -f2)
+    
+    : "${STAT_UNIT_P:=0}"
+    : "${STAT_UNIT_F:=0}"
+    : "${STAT_FUNC_P:=0}"
+    : "${STAT_FUNC_F:=0}"
+}
+
+# Extract test count from log file
+# Usage: extract_test_count <log_file> <pattern>
+extract_test_count() {
+    grep -E "$2" "$1" 2>/dev/null | grep -oE "[0-9]+" | head -1
+}
+
+# =============================================================================
+# Test Verification
+# =============================================================================
+
 # Verify that test failures are properly detected
 # This is a meta-test: it runs a deliberately failing test
 # and checks that the test framework reports the failure correctly
@@ -61,11 +119,11 @@ EOF
     # Test 1: Single failing test detection
     echo "  Testing single test failure detection..."
     if /tmp/test_must_fail > /tmp/test_must_fail.log 2>&1; then
-        echo "ERROR: Test that should fail returned success (exit code 0)"
-        echo "This means the test framework is NOT detecting failures correctly!"
-        echo "--- Test output ---"
-        cat /tmp/test_must_fail.log
-        echo "--- End output ---"
+        echo "ERROR: Test that should fail returned success (exit code 0)" >&2
+        echo "This means the test framework is NOT detecting failures correctly!" >&2
+        echo "--- Test output ---" >&2
+        cat /tmp/test_must_fail.log >&2
+        echo "--- End output ---" >&2
         rm -f /tmp/test_must_fail /tmp/test_must_fail.c /tmp/test_must_fail.log
         exit 1
     fi
@@ -85,8 +143,8 @@ EOF
     wait $pid4 || failed=$((failed + 1))
     
     if [ $failed -ne 2 ]; then
-        echo "ERROR: Expected 2 failures in parallel tests, got $failed"
-        echo "Parallel failure detection is broken!"
+        echo "ERROR: Expected 2 failures in parallel tests, got $failed" >&2
+        echo "Parallel failure detection is broken!" >&2
         rm -f /tmp/test_must_fail /tmp/test_must_fail.c /tmp/test_must_fail.log /tmp/p?.log
         exit 1
     fi
@@ -110,6 +168,17 @@ num_cores()
 # Run test failure detection verification first
 verify_test_failure_detection
 
+# Parse arguments
+COVERAGE_ONLY=no
+for arg in "$@"; do
+    case "$arg" in
+        --coverage-only)
+            COVERAGE_ONLY=yes
+            shift
+            ;;
+    esac
+done
+
 ./bootstrap.sh
 
 tests=()
@@ -180,30 +249,13 @@ case "$ARCH" in
         ;;
 esac
 
-case "$ARCH" in
-    linux*)
-         echo
-         echo "--> Building with ./configure -C ${tests[0]} --enable-valgrind $*"
-         echo
-
-         # shellcheck disable=SC2086
-        ./configure -C ${tests[0]} --enable-valgrind $*
-
-        $MAKE CC="${CC}"
-        if grep '^ID=' /etc/os-release | grep -q -e debian; then
-            $MAKE check-valgrind
-        else
-            $MAKE check-valgrind || log_content ./test-suite-memcheck.log
-        fi
-        $MAKE distclean
-        ;;
-esac
-
 # Function to build and test a single configuration
 build_and_test() {
     local features="$1"
     local extra_args="$2"
     local idx="$3"
+    local run_valgrind="$4"
+    local run_coverage="$5"
     local build_dir="build-$idx"
     local log_file="build-$idx.log"
 
@@ -211,61 +263,210 @@ build_and_test() {
         echo "=== Build $idx started at $(date) ==="
         echo "--> Building in $build_dir with ./configure -C $features $extra_args"
 
+        local start_time=$SECONDS
+
         mkdir -p "$build_dir"
         cd "$build_dir"
 
         # shellcheck disable=SC2086
-        ../configure -C $features $extra_args
+        if ! ../configure -C $features $extra_args; then
+            echo "ERROR: configure failed"
+            exit 1
+        fi
 
-        $MAKE CC="${CC}"
-        $MAKE check-functional-parallel
+        if ! $MAKE CC="${CC}"; then
+            echo "ERROR: make failed"
+            exit 1
+        fi
+
+        # Run unit tests
+        local unit_passed=0 unit_failed=0
+        if [ "$run_valgrind" = "yes" ]; then
+            echo "--> Running unit tests under Valgrind..."
+            # Build unit tests first
+            $MAKE tests/unittests/unittests
+            # Run valgrind directly to capture cmocka output
+            valgrind --error-exitcode=1 --leak-check=full \
+                --suppressions=../prof.supp \
+                tests/unittests/unittests 2>&1 | tee unit-tests-output.log
+            valgrind_exit=${PIPESTATUS[0]}
+            if [ $valgrind_exit -ne 0 ]; then
+                echo "ERROR: Valgrind unit tests failed (exit code $valgrind_exit)"
+                exit 1
+            fi
+        else
+            echo "--> Running unit tests..."
+            $MAKE tests/unittests/unittests
+            tests/unittests/unittests 2>&1 | tee unit-tests-output.log
+            if [ ${PIPESTATUS[0]} -ne 0 ]; then
+                echo "ERROR: Unit tests failed"
+                exit 1
+            fi
+        fi
+        # Extract unit test counts from cmocka output
+        unit_passed=$(extract_test_count unit-tests-output.log "$CMOCKA_PASSED_PATTERN")
+        unit_failed=$(extract_test_count unit-tests-output.log "$CMOCKA_FAILED_PATTERN")
+        : "${unit_passed:=0}" "${unit_failed:=0}"
+        echo "UNIT_TESTS: passed=$unit_passed failed=$unit_failed"
+
+        # Set build index for port allocation: build 1 uses ports 5230-5233,
+        # build 2 uses 5234-5237, etc. This prevents port conflicts in parallel builds.
+        export PROF_BUILD_INDEX=$idx
+        local func_passed=0 func_failed=0
+        if ! $MAKE check-functional-parallel; then
+            echo "ERROR: functional tests failed"
+            exit 1
+        fi
+        # Extract functional test counts from group logs
+        echo "=== Functional test results ==="
+        for glog in ./test-logs/group*.log; do
+            if [ -f "$glog" ]; then
+                cnt=$(extract_test_count "$glog" "$CMOCKA_PASSED_PATTERN")
+                [ -n "$cnt" ] && func_passed=$((func_passed + cnt))
+                cnt=$(extract_test_count "$glog" "$CMOCKA_FAILED_PATTERN")
+                [ -n "$cnt" ] && func_failed=$((func_failed + cnt))
+            fi
+        done
+        echo "FUNC_TESTS: passed=$func_passed failed=$func_failed"
+
+        # Collect coverage data if enabled (lines, functions, branches)
+        # Must be done BEFORE make clean which removes .gcda files
+        local cov_lines="n/a" cov_funcs="n/a" cov_branches="n/a"
+        if [ "$run_coverage" = "yes" ]; then
+            echo "--> Collecting coverage data..."
+            if command -v lcov >/dev/null 2>&1; then
+                lcov --capture --directory . --output-file coverage-full.info \
+                    --rc lcov_branch_coverage=1 --ignore-errors inconsistent 2>&1 || true
+                # Extract only production code from src/ directory, exclude tests
+                # shellcheck disable=SC2086
+                lcov --extract coverage-full.info $COVERAGE_PATTERNS \
+                    --output-file coverage.info \
+                    --rc lcov_branch_coverage=1 --ignore-errors inconsistent 2>&1 || true
+                if [ -f coverage.info ] && [ -s coverage.info ]; then
+                    local summary
+                    summary=$(lcov --summary coverage.info \
+                        --rc lcov_branch_coverage=1 --ignore-errors inconsistent 2>&1 || true)
+                    cov_lines=$(echo "$summary" | grep -E "lines\.*:" | grep -oE "[0-9]+\.[0-9]+%" | head -1)
+                    cov_funcs=$(echo "$summary" | grep -E "functions\.*:" | grep -oE "[0-9]+\.[0-9]+%" | head -1)
+                    cov_branches=$(echo "$summary" | grep -E "branches\.*:" | grep -oE "[0-9]+\.[0-9]+%" | head -1)
+                    [ -z "$cov_lines" ] && cov_lines="n/a"
+                    [ -z "$cov_funcs" ] && cov_funcs="n/a"
+                    [ -z "$cov_branches" ] && cov_branches="n/a"
+                else
+                    echo "WARNING: coverage.info is empty or not created"
+                fi
+            else
+                echo "WARNING: lcov not found"
+            fi
+            echo "COVERAGE: lines=$cov_lines funcs=$cov_funcs branches=$cov_branches"
+        fi
 
         ./profanity -v
+
+        # Save coverage.info before cleanup (for CI artifact)
+        # Only copy in CI environment to avoid leaving artifacts during local runs
+        if [ "$run_coverage" = "yes" ] && [ -f coverage.info ] && [ -n "$CI" ]; then
+            cp coverage.info ../coverage.info
+            echo "Coverage report saved to coverage.info"
+        fi
+
         $MAKE clean
 
         cd ..
         rm -rf "$build_dir"
 
+        local elapsed=$((SECONDS - start_time))
+        local mins=$((elapsed / 60))
+        local secs=$((elapsed % 60))
+
         echo "=== Build $idx completed at $(date) ==="
+        echo "STATS: unit_passed=$unit_passed unit_failed=$unit_failed func_passed=$func_passed func_failed=$func_failed cov_lines=$cov_lines cov_funcs=$cov_funcs cov_branches=$cov_branches time=${mins}m${secs}s"
     } > "$log_file" 2>&1
 }
 
-# Run all 4 configurations in parallel
-echo "Starting parallel builds..."
-pids=()
-for idx in 1 2 3 4; do
-    if [ $idx -le ${#tests[@]} ]; then
-        build_and_test "${tests[$((idx-1))]}" "$*" "$idx" &
-        pids+=("$!")
-        echo "Started build $idx (PID: $!)" 
-    fi
-done
+# Run configurations
+# Coverage enabled only for build 1 (Full) - it has most code paths
+echo
+echo "=== Start build ==="
+echo
+
+if [ "$COVERAGE_ONLY" = "yes" ]; then
+    echo "Running coverage-only mode (${BUILD_NAMES[0]} build)..."
+    echo
+    run_valgrind="no"
+    run_coverage="yes"
+    extra_flags="--enable-coverage"
+    build_and_test "${tests[0]}" "$* $extra_flags" "1" "$run_valgrind" "$run_coverage" &
+    pids=("$!")
+    echo "  → ${BUILD_NAMES[0]}: ${tests[0]} [+Coverage]"
+else
+    echo "Starting $TEST_BUILDS parallel build configurations..."
+    echo
+    pids=()
+    for idx in $(seq 1 $TEST_BUILDS); do
+        if [ $idx -le ${#tests[@]} ]; then
+            # All builds run Valgrind on Linux
+            if [ "$ARCH" = "linux" ]; then
+                run_valgrind="yes"
+                extra_flags="--enable-valgrind"
+            else
+                run_valgrind="no"
+                extra_flags=""
+            fi
+            run_coverage="no"
+            build_and_test "${tests[$((idx-1))]}" "$* $extra_flags" "$idx" "$run_valgrind" "$run_coverage" &
+            pids+=("$!")
+            flags_desc=""
+            [ "$run_valgrind" = "yes" ] && flags_desc=" [+Valgrind]"
+            echo "  → ${BUILD_NAMES[$((idx-1))]}: ${tests[$((idx-1))]}$flags_desc"
+        fi
+    done
+fi
+echo
 
 # Wait for all builds and check exit codes
-failed=0
+echo "Waiting for builds to complete..."
+echo
+failed_builds=()
 for i in "${!pids[@]}"; do
     idx=$((i + 1))
     if wait "${pids[$i]}"; then
-        echo "✓ Build $idx passed"
+        if [ -f "build-$idx.log" ]; then
+            parse_build_stats "build-$idx.log"
+            
+            echo "✓ ${BUILD_NAMES[$i]} PASSED"
+            echo "  Unit tests:       $STAT_UNIT_P passed, $STAT_UNIT_F failed"
+            echo "  Functional tests: $STAT_FUNC_P passed, $STAT_FUNC_F failed"
+            if [ "$STAT_COV_LINES" != "n/a" ] && [ -n "$STAT_COV_LINES" ]; then
+                echo "  Coverage:         Lines: $STAT_COV_LINES | Functions: $STAT_COV_FUNCS | Branches: $STAT_COV_BRANCHES"
+            fi
+            echo "  Duration:         ${STAT_TIME:-?}"
+        else
+            echo "✓ ${BUILD_NAMES[$i]} passed (no stats available)"
+        fi
     else
-        echo "✗ Build $idx failed"
-        echo "--- Log for build $idx ---"
-        cat "build-$idx.log"
-        echo "--- End log ---"
-        failed=1
+        echo "✗ ${BUILD_NAMES[$i]} FAILED" >&2
+        failed_builds+=("$idx")
+    fi
+    echo
+done
+
+# Show failed builds full logs
+for idx in "${failed_builds[@]}"; do
+    if [ -f "build-$idx.log" ]; then
+        echo "=== ${BUILD_NAMES[$((idx-1))]} FAILURE LOG ===" >&2
+        cat "build-$idx.log" >&2
+        echo >&2
     fi
 done
 
-# Show all logs on success too
-if [ $failed -eq 0 ]; then
-    echo
-    echo "All builds passed!"
-    for idx in 1 2 3 4; do
-        if [ -f "build-$idx.log" ]; then
-            echo "--- Log for build $idx ---"
-            cat "build-$idx.log"
-        fi
-    done
-else
+if [ ${#failed_builds[@]} -gt 0 ]; then
+    echo "RESULT: FAILED (builds ${failed_builds[*]})" >&2
     exit 1
+else
+    if [ "$COVERAGE_ONLY" = "yes" ]; then
+        echo "RESULT: COVERAGE BUILD PASSED ✓"
+    else
+        echo "RESULT: ALL $TEST_BUILDS BUILDS PASSED ✓"
+    fi
 fi

prof.supp

@@ -8,6 +8,29 @@
 # * python suppressions file from https://github.com/python/cpython/blob/main/Misc/valgrind-python.supp
 #
 
+# ============================================
+# glibc AVX2 optimizations (false positives)
+# See: https://sourceware.org/bugzilla/show_bug.cgi?id=19796
+# ============================================
+
+{
+  glibc_wcpncpy_avx2
+  Memcheck:Addr32
+  fun:__wcpncpy_avx2
+  fun:wcsxfrm_l
+  fun:g_utf8_collate_key
+  ...
+}
+
+{
+  glibc_wcsxfrm_avx2
+  Memcheck:Addr32
+  ...
+  fun:wcsxfrm_l
+  fun:g_utf8_collate_key
+  ...
+}
+
 # ============================================
 # Functional tests suppressions (stabber/pthread)
 # ============================================

src/command/cmd_defs.c

@@ -2825,16 +2825,15 @@ cmd_search_index_any(char* term)
     int terms_len = g_strv_length(processed_terms);
 
     for (int i = 0; i < terms_len; i++) {
-        GList* index_keys = g_hash_table_get_keys(search_index);
-        GList* curr = index_keys;
-        while (curr) {
-            char* index_entry = g_hash_table_lookup(search_index, curr->data);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, search_index);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            char* index_entry = (char*)value;
             if (g_str_match_string(processed_terms[i], index_entry, FALSE)) {
-                results = g_list_append(results, curr->data);
+                results = g_list_append(results, key);
             }
-            curr = g_list_next(curr);
         }
-        g_list_free(index_keys);
     }
 
     return results;
@@ -2848,13 +2847,14 @@ cmd_search_index_all(char* term)
     auto_gcharv gchar** terms = g_str_tokenize_and_fold(term, NULL, NULL);
     int terms_len = g_strv_length(terms);
 
-    GList* commands = g_hash_table_get_keys(search_index);
-    GList* curr = commands;
-    while (curr) {
-        char* command = curr->data;
+    GHashTableIter iter;
+    gpointer key, value;
+    g_hash_table_iter_init(&iter, search_index);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        char* command = (char*)key;
+        char* command_index = (char*)value;
         int matches = 0;
         for (int i = 0; i < terms_len; i++) {
-            char* command_index = g_hash_table_lookup(search_index, command);
             if (g_str_match_string(terms[i], command_index, FALSE)) {
                 matches++;
             }
@@ -2862,11 +2862,8 @@ cmd_search_index_all(char* term)
         if (matches == terms_len) {
             results = g_list_append(results, command);
         }
-        curr = g_list_next(curr);
     }
 
-    g_list_free(commands);
-
     return results;
 }
 
@@ -2989,7 +2986,18 @@ command_docgen(void)
     }
 
     FILE* toc_fragment = fopen("toc_fragment.html", "w");
+    if (!toc_fragment) {
+        log_error("command_docgen(): unable to open toc_fragment.html for writing: %s", g_strerror(errno));
+        g_list_free(cmds);
+        return;
+    }
     FILE* main_fragment = fopen("main_fragment.html", "w");
+    if (!main_fragment) {
+        log_error("command_docgen(): unable to open main_fragment.html for writing: %s", g_strerror(errno));
+        fclose(toc_fragment);
+        g_list_free(cmds);
+        return;
+    }
 
     fputs("<ul><li><ul><li>\n", toc_fragment);
     fputs("<hr>\n", main_fragment);
@@ -3094,6 +3102,11 @@ command_mangen(void)
             return;
         }
         FILE* manpage = fopen(filename, "w");
+        if (!manpage) {
+            log_error("command_mangen(): unable to open %s for writing: %s", filename, g_strerror(errno));
+            curr = g_list_next(curr);
+            continue;
+        }
 
         fprintf(manpage, "%s\n", header);
         fputs(".SH NAME\n", manpage);

src/command/cmd_funcs.c

@@ -184,7 +184,7 @@ _string_matches_one_of(const char* what, const char* is, bool is_can_be_null, co
         }
         va_end(ap);
         if (s > 0)
-            cons_show(errmsg);
+            cons_show("%s", errmsg);
     }
     return ret;
 }
@@ -418,7 +418,7 @@ cmd_connect(ProfWin* window, const char* const command, gchar** args)
         auto_char char* err_msg = NULL;
         gboolean res = strtoi_range(port_str, &port, 1, 65535, &err_msg);
         if (!res) {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_show("");
             port = 0;
             options_destroy(options);
@@ -711,7 +711,7 @@ _account_set_port(char* account_name, char* port)
     auto_char char* err_msg = NULL;
     gboolean res = strtoi_range(port, &porti, 1, 65535, &err_msg);
     if (!res) {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
         cons_show("");
     } else {
         accounts_set_port(account_name, porti);
@@ -903,7 +903,7 @@ _account_set_max_sessions(char* account_name, char* max_sessions_raw)
     auto_char char* err_msg = NULL;
     gboolean res = strtoi_range(max_sessions_raw, &max_sessions, 0, INT_MAX, &err_msg);
     if (!res) {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
         cons_show("");
         return TRUE;
     }
@@ -924,7 +924,7 @@ _account_set_presence_priority(char* account_name, char* presence, char* priorit
     auto_char char* err_msg = NULL;
     gboolean res = strtoi_range(priority, &intval, -128, 127, &err_msg);
     if (!res) {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
         return TRUE;
     }
 
@@ -1580,7 +1580,7 @@ _cmd_list_commands(GList* commands)
     while (curr) {
         gchar* cmd = curr->data;
         if (count == 5) {
-            cons_show(cmds->str);
+            cons_show("%s", cmds->str);
             g_string_free(cmds, TRUE);
             cmds = g_string_new("");
             count = 0;
@@ -1589,7 +1589,7 @@ _cmd_list_commands(GList* commands)
         curr = g_list_next(curr);
         count++;
     }
-    cons_show(cmds->str);
+    cons_show("%s", cmds->str);
     g_string_free(cmds, TRUE);
     g_list_free(curr);
 
@@ -2407,7 +2407,7 @@ cmd_roster(ProfWin* window, const char* const command, gchar** args)
             }
             return TRUE;
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             return TRUE;
         }
 
@@ -2467,7 +2467,7 @@ cmd_roster(ProfWin* window, const char* const command, gchar** args)
                     cons_show("Roster contact indent set to: %d", intval);
                     rosterwin_roster();
                 } else {
-                    cons_show(err_msg);
+                    cons_show("%s", err_msg);
                 }
             }
         } else {
@@ -2501,7 +2501,7 @@ cmd_roster(ProfWin* window, const char* const command, gchar** args)
                     cons_show("Roster resource indent set to: %d", intval);
                     rosterwin_roster();
                 } else {
-                    cons_show(err_msg);
+                    cons_show("%s", err_msg);
                 }
             }
         } else if (g_strcmp0(args[1], "join") == 0) {
@@ -2527,7 +2527,7 @@ cmd_roster(ProfWin* window, const char* const command, gchar** args)
                     cons_show("Roster presence indent set to: %d", intval);
                     rosterwin_roster();
                 } else {
-                    cons_show(err_msg);
+                    cons_show("%s", err_msg);
                 }
             }
         } else {
@@ -4371,7 +4371,7 @@ cmd_occupants(ProfWin* window, const char* const command, gchar** args)
                 wins_resize_all();
                 return TRUE;
             } else {
-                cons_show(err_msg);
+                cons_show("%s", err_msg);
                 return TRUE;
             }
         }
@@ -4391,7 +4391,7 @@ cmd_occupants(ProfWin* window, const char* const command, gchar** args)
 
                 occupantswin_occupants_all();
             } else {
-                cons_show(err_msg);
+                cons_show("%s", err_msg);
             }
             return TRUE;
         }
@@ -4970,8 +4970,8 @@ cmd_sendfile(ProfWin* window, const char* const command, gchar** args)
         alt_scheme = OMEMO_AESGCM_URL_SCHEME;
         alt_fragment = _add_omemo_stream(&fd, &fh, &err);
         if (err != NULL) {
-            cons_show_error(err);
-            win_println(window, THEME_ERROR, "-", err);
+            cons_show_error("%s", err);
+            win_println(window, THEME_ERROR, "-", "%s", err);
             goto out;
         }
 #endif
@@ -5836,7 +5836,7 @@ cmd_inpblock(ProfWin* window, const char* const command, gchar** args)
             prefs_set_inpblock(intval);
             inp_nonblocking(FALSE);
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
         }
 
         return TRUE;
@@ -6063,7 +6063,7 @@ cmd_statusbar(ProfWin* window, const char* const command, gchar** args)
             ui_resize();
             return TRUE;
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_bad_cmd_usage(command);
             return TRUE;
         }
@@ -6094,7 +6094,7 @@ cmd_statusbar(ProfWin* window, const char* const command, gchar** args)
             ui_resize();
             return TRUE;
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_bad_cmd_usage(command);
             return TRUE;
         }
@@ -6254,7 +6254,7 @@ cmd_log(ProfWin* window, const char* const command, gchar** args)
             prefs_set_max_log_size(intval);
             cons_show("Log maximum size set to %d bytes", intval);
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
         }
         return TRUE;
     }
@@ -6304,7 +6304,7 @@ cmd_reconnect(ProfWin* window, const char* const command, gchar** args)
             cons_show("Reconnect interval set to %d seconds.", intval);
         }
     } else {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
         cons_bad_cmd_usage(command);
     }
 
@@ -6330,7 +6330,7 @@ cmd_autoping(ProfWin* window, const char* const command, gchar** args)
                 cons_show("Autoping interval set to %d seconds.", intval);
             }
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_bad_cmd_usage(command);
         }
 
@@ -6346,7 +6346,7 @@ cmd_autoping(ProfWin* window, const char* const command, gchar** args)
                 cons_show("Autoping timeout set to %d seconds.", intval);
             }
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_bad_cmd_usage(command);
         }
 
@@ -6416,7 +6416,7 @@ cmd_autoaway(ProfWin* window, const char* const command, gchar** args)
                     cons_show("Auto away time set to: %d minutes.", minutesval);
                 }
             } else {
-                cons_show(err_msg);
+                cons_show("%s", err_msg);
             }
 
             return TRUE;
@@ -6439,7 +6439,7 @@ cmd_autoaway(ProfWin* window, const char* const command, gchar** args)
                     }
                 }
             } else {
-                cons_show(err_msg);
+                cons_show("%s", err_msg);
             }
 
             return TRUE;
@@ -6506,7 +6506,7 @@ cmd_priority(ProfWin* window, const char* const command, gchar** args)
         cl_ev_presence_send(last_presence, 0);
         cons_show("Priority set to %d.", intval);
     } else {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
     }
 
     return TRUE;
@@ -6576,7 +6576,7 @@ cmd_tray(ProfWin* window, const char* const command, gchar** args)
                 tray_set_timer(intval);
             }
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
         }
 
         return TRUE;
@@ -7181,22 +7181,21 @@ cmd_pgp(ProfWin* window, const char* const command, gchar** args)
         }
 
         cons_show("PGP keys:");
-        GList* keylist = g_hash_table_get_keys(keys);
-        GList* curr = keylist;
-        while (curr) {
-            ProfPGPKey* key = g_hash_table_lookup(keys, curr->data);
-            cons_show("  %s", key->name);
-            cons_show("    ID          : %s", key->id);
-            auto_char char* format_fp = p_gpg_format_fp_str(key->fp);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, keys);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            ProfPGPKey* pgp_key = (ProfPGPKey*)value;
+            cons_show("  %s", pgp_key->name);
+            cons_show("    ID          : %s", pgp_key->id);
+            auto_char char* format_fp = p_gpg_format_fp_str(pgp_key->fp);
             cons_show("    Fingerprint : %s", format_fp);
-            if (key->secret) {
+            if (pgp_key->secret) {
                 cons_show("    Type        : PUBLIC, PRIVATE");
             } else {
                 cons_show("    Type        : PUBLIC");
             }
-            curr = g_list_next(curr);
         }
-        g_list_free(keylist);
         p_gpg_free_keys(keys);
         return TRUE;
     }
@@ -7237,25 +7236,24 @@ cmd_pgp(ProfWin* window, const char* const command, gchar** args)
             return TRUE;
         }
         GHashTable* pubkeys = p_gpg_pubkeys();
-        GList* jids = g_hash_table_get_keys(pubkeys);
-        if (!jids) {
+        if (!pubkeys || g_hash_table_size(pubkeys) == 0) {
             cons_show("No contacts found with PGP public keys assigned.");
             return TRUE;
         }
 
         cons_show("Assigned PGP public keys:");
-        GList* curr = jids;
-        while (curr) {
-            char* jid = curr->data;
-            ProfPGPPubKeyId* pubkeyid = g_hash_table_lookup(pubkeys, jid);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, pubkeys);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            char* jid = (char*)key;
+            ProfPGPPubKeyId* pubkeyid = (ProfPGPPubKeyId*)value;
             if (pubkeyid->received) {
                 cons_show("  %s: %s (received)", jid, pubkeyid->id);
             } else {
                 cons_show("  %s: %s (stored)", jid, pubkeyid->id);
             }
-            curr = g_list_next(curr);
         }
-        g_list_free(jids);
         return TRUE;
     }
 
@@ -7468,22 +7466,21 @@ cmd_ox(ProfWin* window, const char* const command, gchar** args)
         }
 
         cons_show("OpenPGP keys:");
-        GList* keylist = g_hash_table_get_keys(keys);
-        GList* curr = keylist;
-        while (curr) {
-            ProfPGPKey* key = g_hash_table_lookup(keys, curr->data);
-            cons_show("  %s", key->name);
-            cons_show("    ID          : %s", key->id);
-            auto_char char* format_fp = p_gpg_format_fp_str(key->fp);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, keys);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            ProfPGPKey* pgp_key = (ProfPGPKey*)value;
+            cons_show("  %s", pgp_key->name);
+            cons_show("    ID          : %s", pgp_key->id);
+            auto_char char* format_fp = p_gpg_format_fp_str(pgp_key->fp);
             cons_show("    Fingerprint : %s", format_fp);
-            if (key->secret) {
+            if (pgp_key->secret) {
                 cons_show("    Type        : PUBLIC, PRIVATE");
             } else {
                 cons_show("    Type        : PUBLIC");
             }
-            curr = g_list_next(curr);
         }
-        g_list_free(keylist);
         p_gpg_free_keys(keys);
         return TRUE;
     }
@@ -7491,8 +7488,8 @@ cmd_ox(ProfWin* window, const char* const command, gchar** args)
     else if (g_strcmp0(args[0], "contacts") == 0) {
         GHashTable* keys = ox_gpg_public_keys();
         cons_show("OpenPGP keys:");
-        GList* keylist = g_hash_table_get_keys(keys);
-        GList* curr = keylist;
+        GHashTableIter iter;
+        gpointer key, value;
 
         GSList* roster_list = NULL;
         jabber_conn_status_t conn_status = connection_get_status();
@@ -7502,15 +7499,16 @@ cmd_ox(ProfWin* window, const char* const command, gchar** args)
             roster_list = roster_get_contacts(ROSTER_ORD_NAME);
         }
 
-        while (curr) {
-            ProfPGPKey* key = g_hash_table_lookup(keys, curr->data);
+        g_hash_table_iter_init(&iter, keys);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            ProfPGPKey* pgp_key = (ProfPGPKey*)value;
             PContact contact = NULL;
             if (roster_list) {
                 GSList* curr_c = roster_list;
                 while (!contact && curr_c) {
                     contact = curr_c->data;
                     auto_gchar gchar* xmppuri = g_strdup_printf("xmpp:%s", p_contact_barejid(contact));
-                    if (g_strcmp0(key->name, xmppuri)) {
+                    if (g_strcmp0(pgp_key->name, xmppuri)) {
                         contact = NULL;
                     }
                     curr_c = g_slist_next(curr_c);
@@ -7518,11 +7516,10 @@ cmd_ox(ProfWin* window, const char* const command, gchar** args)
             }
 
             if (contact) {
-                cons_show("%s - %s", key->fp, key->name);
+                cons_show("%s - %s", pgp_key->fp, pgp_key->name);
             } else {
-                cons_show("%s - %s (not in roster)", key->fp, key->name);
+                cons_show("%s - %s (not in roster)", pgp_key->fp, pgp_key->name);
             }
-            curr = g_list_next(curr);
         }
 
     } else if (g_strcmp0(args[0], "start") == 0) {
@@ -9612,7 +9609,7 @@ cmd_register(ProfWin* window, const char* const command, gchar** args)
         auto_char char* err_msg = NULL;
         gboolean res = strtoi_range(port_str, &port, 1, 65535, &err_msg);
         if (!res) {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
             cons_show("");
             port = 0;
             options_destroy(options);
@@ -9682,7 +9679,7 @@ cmd_strophe(ProfWin* window, const char* const command, gchar** args)
             prefs_set_string(PREF_STROPHE_VERBOSITY, args[1]);
             return TRUE;
         } else {
-            cons_show(err_msg);
+            cons_show("%s", err_msg);
         }
     } else if (g_strcmp0(args[0], "sm") == 0) {
         if (g_strcmp0(args[1], "no-resend") == 0) {

src/common.c

@@ -143,7 +143,7 @@ auto_close_gfd(gint* fd)
         return;
 
     if (close(*fd) == EOF)
-        log_error(g_strerror(errno));
+        log_error("%s", g_strerror(errno));
 }
 
 /**
@@ -158,7 +158,7 @@ auto_close_FILE(FILE** fd)
         return;
 
     if (fclose(*fd) == EOF)
-        log_error(g_strerror(errno));
+        log_error("%s", g_strerror(errno));
 }
 
 static gboolean

src/database.c

@@ -65,6 +65,38 @@ static gboolean _check_available_space_for_db_migration(char* path_to_db);
 
 static const int latest_version = 2;
 
+// Helper: close DB handle (if any), warn on busy, and shutdown SQLite
+static void
+_db_teardown(const char* ctx)
+{
+    if (g_chatlog_database) {
+        int rc = sqlite3_close_v2(g_chatlog_database);
+        if (rc != SQLITE_OK) {
+            log_warning("sqlite3_close_v2 in %s returned %d; database may still have active statements.",
+                        ctx ? ctx : "db_teardown", rc);
+        }
+        g_chatlog_database = NULL;
+    }
+    // Safe to call unconditionally; no-op if not initialized.
+    // See: https://www.sqlite.org/c3ref/initialize.html
+    sqlite3_shutdown();
+}
+
+// Helper: prepare a statement and log a contextual error on failure
+static gboolean
+_db_prepare_ctx(const char* query, sqlite3_stmt** stmt, const char* ctx)
+{
+    int rc = sqlite3_prepare_v2(g_chatlog_database, query, -1, stmt, NULL);
+    if (rc != SQLITE_OK) {
+        log_error("SQLite error in %s: (error code: %d) %s",
+                  ctx ? ctx : "sqlite3_prepare_v2",
+                  rc,
+                  sqlite3_errmsg(g_chatlog_database));
+        return FALSE;
+    }
+    return TRUE;
+}
+
 static char*
 _db_strdup(const char* str)
 {
@@ -98,17 +130,19 @@ log_database_init(ProfAccount* account)
 
     auto_char char* filename = _get_db_filename(account);
     if (!filename) {
+        sqlite3_shutdown();
         return FALSE;
     }
 
     ret = sqlite3_open(filename, &g_chatlog_database);
     if (ret != SQLITE_OK) {
-        const char* err_msg = sqlite3_errmsg(g_chatlog_database);
+        const char* err_msg = g_chatlog_database ? sqlite3_errmsg(g_chatlog_database) : "(no handle)";
         log_error("Error opening SQLite database: %s", err_msg);
+        _db_teardown("log_database_init(open)");
         return FALSE;
     }
 
-    char* err_msg;
+    char* err_msg = NULL;
 
     int db_version = _get_db_version();
     if (db_version == latest_version) {
@@ -216,6 +250,7 @@ out:
     } else {
         log_error("Unknown SQLite error in log_database_init().");
     }
+    _db_teardown("log_database_init(out)");
     return FALSE;
 }
 
@@ -223,11 +258,7 @@ void
 log_database_close(void)
 {
     log_debug("log_database_close() called");
-    if (g_chatlog_database) {
-        sqlite3_close(g_chatlog_database);
-        sqlite3_shutdown();
-        g_chatlog_database = NULL;
-    }
+    _db_teardown("log_database_close");
 }
 
 void
@@ -281,8 +312,15 @@ log_database_get_limits_info(const gchar* const contact_barejid, gboolean is_las
 {
     sqlite3_stmt* stmt = NULL;
     const Jid* myjid = connection_get_jid();
-    if (!myjid->str)
-        return NULL;
+    // Always return a valid ProfMessage to avoid NULL dereferences in callers
+    ProfMessage* msg = message_init();
+    if (!myjid || !myjid->str) {
+        // If caller requested the last message and we have no context, fall back to now
+        if (is_last) {
+            msg->timestamp = g_date_time_new_now_utc();
+        }
+        return msg;
+    }
 
     const char* order = is_last ? "DESC" : "ASC";
     auto_sqlite char* query = sqlite3_mprintf("SELECT `archive_id`, `timestamp` FROM `ChatLogs` WHERE "
@@ -293,17 +331,19 @@ log_database_get_limits_info(const gchar* const contact_barejid, gboolean is_las
 
     if (!query) {
         log_error("Could not allocate memory for SQL query in log_database_get_limits_info()");
-        return NULL;
+        if (is_last) {
+            msg->timestamp = g_date_time_new_now_utc();
+        }
+        return msg;
     }
 
-    int rc = sqlite3_prepare_v2(g_chatlog_database, query, -1, &stmt, NULL);
-    if (rc != SQLITE_OK) {
-        log_error("Unknown SQLite error in log_database_get_last_info().");
-        return NULL;
+    if (!_db_prepare_ctx(query, &stmt, "log_database_get_limits_info()")) {
+        if (is_last) {
+            msg->timestamp = g_date_time_new_now_utc();
+        }
+        return msg;
     }
 
-    ProfMessage* msg = message_init();
-
     if (sqlite3_step(stmt) == SQLITE_ROW) {
         char* archive_id = (char*)sqlite3_column_text(stmt, 0);
         char* date = (char*)sqlite3_column_text(stmt, 1);
@@ -313,6 +353,11 @@ log_database_get_limits_info(const gchar* const contact_barejid, gboolean is_las
     }
     sqlite3_finalize(stmt);
 
+    // If nothing was found and caller expects the last message, provide a sane default
+    if (!msg->timestamp && is_last) {
+        msg->timestamp = g_date_time_new_now_utc();
+    }
+
     return msg;
 }
 
@@ -357,9 +402,7 @@ log_database_get_previous_chat(const gchar* const contact_barejid, const gchar*
         return DB_RESPONSE_ERROR;
     }
 
-    int rc = sqlite3_prepare_v2(g_chatlog_database, query, -1, &stmt, NULL);
-    if (rc != SQLITE_OK) {
-        log_error("SQLite error in log_database_get_previous_chat(): (error code: %d) %s", rc, sqlite3_errmsg(g_chatlog_database));
+    if (!_db_prepare_ctx(query, &stmt, "log_database_get_previous_chat()")) {
         return DB_RESPONSE_ERROR;
     }
 
@@ -503,9 +546,7 @@ _add_to_db(ProfMessage* message, char* type, const Jid* const from_jid, const Ji
         }
 
         sqlite3_stmt* lmc_stmt = NULL;
-
-        if (SQLITE_OK != sqlite3_prepare_v2(g_chatlog_database, replace_check_query, -1, &lmc_stmt, NULL)) {
-            log_error("SQLite error in _add_to_db() on selecting original message: %s", sqlite3_errmsg(g_chatlog_database));
+        if (!_db_prepare_ctx(replace_check_query, &lmc_stmt, "_add_to_db(replace_check)")) {
             return;
         }
 
@@ -542,8 +583,7 @@ _add_to_db(ProfMessage* message, char* type, const Jid* const from_jid, const Ji
         }
 
         sqlite3_stmt* stmt;
-
-        if (SQLITE_OK == sqlite3_prepare_v2(g_chatlog_database, duplicate_check_query, -1, &stmt, NULL)) {
+        if (_db_prepare_ctx(duplicate_check_query, &stmt, "_add_to_db(duplicate_check)")) {
             if (sqlite3_step(stmt) == SQLITE_ROW) {
                 log_error("Duplicate stanza-id found for the message. stanza_id: %s; archive_id: %s; sender: %s; content: %s", message->id, message->stanzaid, from_jid->barejid, message->plain);
                 cons_show_error("Got a message with duplicate (server-generated) stanza-id from %s.", from_jid->fulljid);
@@ -599,8 +639,7 @@ _get_db_version(void)
     int current_version = -1;
     const char* query = "SELECT `version` FROM `DbVersion` LIMIT 1";
     sqlite3_stmt* statement;
-
-    if (sqlite3_prepare_v2(g_chatlog_database, query, -1, &statement, NULL) == SQLITE_OK) {
+    if (_db_prepare_ctx(query, &statement, "_get_db_version()")) {
         if (sqlite3_step(statement) == SQLITE_ROW) {
             current_version = sqlite3_column_int(statement, 0);
         }

src/omemo/omemo.c

@@ -532,11 +532,13 @@ omemo_set_device_list(const char* const from, GList* device_list)
                 for (device_id = device_list; device_id != NULL; device_id = device_id->next) {
                     GHashTable* known_identities = g_hash_table_lookup(omemo_ctx.known_devices, jid->barejid);
                     if (known_identities) {
-                        GList* fp = NULL;
-                        for (fp = g_hash_table_get_keys(known_identities); fp != NULL; fp = fp->next) {
-                            if (device_id->data == g_hash_table_lookup(known_identities, fp->data)) {
-                                cons_show("OMEMO: Adding firstusage trust for %s device %d - Fingerprint %s", jid->barejid, device_id->data, omemo_format_fingerprint(fp->data));
-                                omemo_trust(jid->barejid, omemo_format_fingerprint(fp->data));
+                        GHashTableIter iter;
+                        gpointer key, value;
+                        g_hash_table_iter_init(&iter, known_identities);
+                        while (g_hash_table_iter_next(&iter, &key, &value)) {
+                            if (device_id->data == value) {
+                                cons_show("OMEMO: Adding firstusage trust for %s device %d - Fingerprint %s", jid->barejid, device_id->data, omemo_format_fingerprint(key));
+                                omemo_trust(jid->barejid, omemo_format_fingerprint(key));
                             }
                         }
                     }

src/pgp/gpg.c

@@ -345,14 +345,13 @@ p_gpg_list_keys(void)
 
     // TODO: move autocomplete in other place
     autocomplete_clear(key_ac);
-    GList* ids = g_hash_table_get_keys(result);
-    GList* curr = ids;
-    while (curr) {
-        ProfPGPKey* key = g_hash_table_lookup(result, curr->data);
-        autocomplete_add(key_ac, key->id);
-        curr = curr->next;
+    GHashTableIter iter;
+    gpointer key, value;
+    g_hash_table_iter_init(&iter, result);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        ProfPGPKey* pgp_key = (ProfPGPKey*)value;
+        autocomplete_add(key_ac, pgp_key->id);
     }
-    g_list_free(ids);
 
     return result;
 }

src/plugins/autocompleters.c

@@ -141,18 +141,16 @@ autocompleters_complete(const char* const input, gboolean previous)
     while (curr_hash) {
         GHashTable* key_to_ac = curr_hash->data;
 
-        GList* keys = g_hash_table_get_keys(key_to_ac);
-        GList* curr = keys;
-        while (curr) {
-            result = autocomplete_param_with_ac(input, curr->data, g_hash_table_lookup(key_to_ac, curr->data), TRUE, previous);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, key_to_ac);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            result = autocomplete_param_with_ac(input, key, value, TRUE, previous);
             if (result) {
                 g_list_free(ac_hashes);
-                g_list_free(keys);
                 return result;
             }
-            curr = g_list_next(curr);
         }
-        g_list_free(keys);
 
         curr_hash = g_list_next(curr_hash);
     }
@@ -162,22 +160,19 @@ autocompleters_complete(const char* const input, gboolean previous)
     curr_hash = filepath_hashes;
     while (curr_hash) {
         GHashTable* prefixes_hash = curr_hash->data;
-        GList* prefixes = g_hash_table_get_keys(prefixes_hash);
-        GList* curr_prefix = prefixes;
-        while (curr_prefix) {
-            char* prefix = curr_prefix->data;
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, prefixes_hash);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            char* prefix = (char*)key;
             if (g_str_has_prefix(input, prefix)) {
                 result = cmd_ac_complete_filepath(input, prefix, previous);
                 if (result) {
                     g_list_free(filepath_hashes);
-                    g_list_free(prefixes);
                     return result;
                 }
             }
-
-            curr_prefix = g_list_next(curr_prefix);
         }
-        g_list_free(prefixes);
 
         curr_hash = g_list_next(curr_hash);
     }

src/plugins/callbacks.c

@@ -149,15 +149,14 @@ callbacks_remove(const char* const plugin_name)
 {
     GHashTable* command_hash = g_hash_table_lookup(p_commands, plugin_name);
     if (command_hash) {
-        GList* commands = g_hash_table_get_keys(command_hash);
-        GList* curr = commands;
-        while (curr) {
-            char* command = curr->data;
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, command_hash);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            char* command = (char*)key;
             cmd_ac_remove(command);
             cmd_ac_remove_help(&command[1]);
-            curr = g_list_next(curr);
         }
-        g_list_free(commands);
     }
 
     g_hash_table_remove(p_commands, plugin_name);
@@ -165,13 +164,12 @@ callbacks_remove(const char* const plugin_name)
 
     GHashTable* tag_to_win_cb_hash = g_hash_table_lookup(p_window_callbacks, plugin_name);
     if (tag_to_win_cb_hash) {
-        GList* tags = g_hash_table_get_keys(tag_to_win_cb_hash);
-        GList* curr = tags;
-        while (curr) {
-            wins_close_plugin(curr->data);
-            curr = g_list_next(curr);
+        GHashTableIter iter;
+        gpointer key, value;
+        g_hash_table_iter_init(&iter, tag_to_win_cb_hash);
+        while (g_hash_table_iter_next(&iter, &key, &value)) {
+            wins_close_plugin(key);
         }
-        g_list_free(tags);
     }
 
     g_hash_table_remove(p_window_callbacks, plugin_name);

src/plugins/disco.c

@@ -107,10 +107,11 @@ disco_remove_features(const char* plugin_name)
         return;
     }
 
-    GList* plugin_feature_list = g_hash_table_get_keys(plugin_features_set);
-    GList* curr = plugin_feature_list;
-    while (curr) {
-        char* feature = curr->data;
+    GHashTableIter iter;
+    gpointer key, value;
+    g_hash_table_iter_init(&iter, plugin_features_set);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        char* feature = (char*)key;
         if (g_hash_table_contains(features, feature)) {
             void* refcountp = g_hash_table_lookup(features, feature);
             int refcount = GPOINTER_TO_INT(refcountp);
@@ -121,10 +122,7 @@ disco_remove_features(const char* plugin_name)
                 g_hash_table_replace(features, strdup(feature), GINT_TO_POINTER(refcount));
             }
         }
-
-        curr = g_list_next(curr);
     }
-    g_list_free(plugin_feature_list);
 }
 
 GList*

src/plugins/python_plugins.c

@@ -887,8 +887,8 @@ _python_undefined_error(ProfPlugin* plugin, char* hook, char* type)
     g_string_append(err_msg, hook);
     g_string_append(err_msg, "(): return value undefined, expected ");
     g_string_append(err_msg, type);
-    log_error(err_msg->str);
-    cons_show_error(err_msg->str);
+    log_error("%s", err_msg->str);
+    cons_show_error("%s", err_msg->str);
     g_string_free(err_msg, TRUE);
 }
 
@@ -901,8 +901,8 @@ _python_type_error(ProfPlugin* plugin, char* hook, char* type)
     g_string_append(err_msg, hook);
     g_string_append(err_msg, "(): incorrect return type, expected ");
     g_string_append(err_msg, type);
-    log_error(err_msg->str);
-    cons_show_error(err_msg->str);
+    log_error("%s", err_msg->str);
+    cons_show_error("%s", err_msg->str);
     g_string_free(err_msg, TRUE);
 }
 

src/profanity.c

@@ -135,7 +135,7 @@ prof_run(gchar* log_level, gchar* account_name, gchar* config_file, gchar* log_f
                          */
                         min_runtime += waittime;
                     } else {
-                        log_error(err_msg);
+                        log_error("%s", err_msg);
                         g_free(err_msg);
                         commands = NULL;
                     }
@@ -245,7 +245,7 @@ _init(char* log_level, char* config_file, char* log_file, char* theme_name)
     if (prof_log_level == PROF_LEVEL_DEBUG) {
         ProfWin* console = wins_get_console();
         win_println(console, THEME_DEFAULT, "-", "Debug mode enabled! Logging to: ");
-        win_println(console, THEME_DEFAULT, "-", get_log_file_location());
+        win_println(console, THEME_DEFAULT, "-", "%s", get_log_file_location());
     }
     session_init();
     cmd_init();

src/tools/http_upload.c

@@ -311,7 +311,7 @@ http_file_put(void* userdata)
             }
             win_update_entry_message(upload->window, upload->put_url, err_msg);
         }
-        cons_show_error(err_msg);
+        cons_show_error("%s", err_msg);
     } else {
         if (!upload->cancel) {
             auto_gchar gchar* status_msg = g_strdup_printf("Uploading '%s': 100%%", upload->filename);
@@ -327,7 +327,7 @@ http_file_put(void* userdata)
                 if (!fail_msg) {
                     fail_msg = g_strdup(FALLBACK_MSG);
                 }
-                cons_show_error(fail_msg);
+                cons_show_error("%s", fail_msg);
             } else {
                 switch (upload->window->type) {
                 case WIN_CHAT:

src/ui/buffer.c

@@ -140,6 +140,10 @@ void
 buffer_remove_entry(ProfBuff buffer, int entry)
 {
     GSList* node = g_slist_nth(buffer->entries, entry);
+    if (node == NULL) {
+        // Index out of range; nothing to remove
+        return;
+    }
     ProfBuffEntry* e = node->data;
     buffer->lines -= e->_lines;
     _free_entry(e);
@@ -168,6 +172,9 @@ ProfBuffEntry*
 buffer_get_entry(ProfBuff buffer, int entry)
 {
     GSList* node = g_slist_nth(buffer->entries, entry);
+    if (node == NULL) {
+        return NULL;
+    }
     return node->data;
 }
 
@@ -189,6 +196,7 @@ buffer_get_entry_by_id(ProfBuff buffer, const char* const id)
 static ProfBuffEntry*
 _create_entry(const char* show_char, int pad_indent, GDateTime* time, int flags, theme_item_t theme_item, const char* const display_from, const char* const from_jid, const char* const message, DeliveryReceipt* receipt, const char* const id, int y_start_pos, int y_end_pos)
 {
+    assert(time != NULL);
     ProfBuffEntry* e = malloc(sizeof(struct prof_buff_entry_t));
     e->show_char = STRDUP_OR_NULL(show_char);
     e->pad_indent = pad_indent;

src/ui/chatwin.c

@@ -592,8 +592,11 @@ chatwin_db_history(ProfChatWin* chatwin, const gchar* start_time, const gchar* e
 {
     auto_gchar gchar* _end_time = NULL;
     if (!end_time && buffer_size(((ProfWin*)chatwin)->layout->buffer) > 0) {
-        _end_time = g_date_time_format_iso8601(buffer_get_entry(((ProfWin*)chatwin)->layout->buffer, 0)->time);
-        end_time = _end_time;
+        ProfBuffEntry* first = buffer_get_entry(((ProfWin*)chatwin)->layout->buffer, 0);
+        if (first && first->time) {
+            _end_time = g_date_time_format_iso8601(first->time);
+            end_time = _end_time;
+        }
     }
 
     GSList* history = NULL;

src/ui/console.c

@@ -152,7 +152,7 @@ cons_bad_cmd_usage(const char* const cmd)
     g_string_printf(msg, "Invalid usage, see '/help %s' for details.", &cmd[1]);
 
     cons_show("");
-    cons_show(msg->str);
+    cons_show("%s", msg->str);
 
     g_string_free(msg, TRUE);
 }
@@ -773,7 +773,7 @@ cons_show_disco_info(const char* jid, GSList* identities, GSList* features)
             if (identity->category) {
                 identity_str = g_string_append(identity_str, identity->category);
             }
-            cons_show(identity_str->str);
+            cons_show("%s", identity_str->str);
             g_string_free(identity_str, TRUE);
             identities = g_slist_next(identities);
         }
@@ -938,7 +938,7 @@ cons_show_account_list(gchar** accounts)
                 theme_item_t presence_colour = theme_main_presence_attrs(string_from_resource_presence(presence));
                 win_println(console, presence_colour, "-", "%s", accounts[i]);
             } else {
-                cons_show(accounts[i]);
+                cons_show("%s", accounts[i]);
             }
         }
         cons_show("");
@@ -1019,7 +1019,7 @@ cons_show_account(ProfAccount* account)
             }
             curr = curr->next;
         }
-        cons_show(manual->str);
+        cons_show("%s", manual->str);
         g_string_free(manual, TRUE);
     }
     if (g_list_length(account->otr_opportunistic) > 0) {
@@ -1032,7 +1032,7 @@ cons_show_account(ProfAccount* account)
             }
             curr = curr->next;
         }
-        cons_show(opportunistic->str);
+        cons_show("%s", opportunistic->str);
         g_string_free(opportunistic, TRUE);
     }
     if (g_list_length(account->otr_always) > 0) {
@@ -1045,7 +1045,7 @@ cons_show_account(ProfAccount* account)
             }
             curr = curr->next;
         }
-        cons_show(always->str);
+        cons_show("%s", always->str);
         g_string_free(always, TRUE);
     }
 
@@ -2297,7 +2297,7 @@ cons_show_themes(GSList* themes)
     } else {
         cons_show("Available themes:");
         while (themes) {
-            cons_show(themes->data);
+            cons_show("%s", themes->data);
             themes = g_slist_next(themes);
         }
     }
@@ -2315,7 +2315,7 @@ cons_show_scripts(GSList* scripts)
     } else {
         cons_show("Scripts:");
         while (scripts) {
-            cons_show(scripts->data);
+            cons_show("%s", scripts->data);
             scripts = g_slist_next(scripts);
         }
     }

src/ui/core.c

@@ -445,7 +445,7 @@ ui_handle_error(const char* const err_msg)
     GString* msg = g_string_new("");
     g_string_printf(msg, "Error %s", err_msg);
 
-    cons_show_error(msg->str);
+    cons_show_error("%s", msg->str);
 
     g_string_free(msg, TRUE);
 }
@@ -461,7 +461,7 @@ ui_invalid_command_usage(const char* const cmd, void (*setting_func)(void))
         (*setting_func)();
     } else {
         cons_show("");
-        cons_show(msg->str);
+        cons_show("%s", msg->str);
         ProfWin* current = wins_get_current();
         if (current->type == WIN_CHAT) {
             win_println(current, THEME_DEFAULT, "-", "%s", msg->str);

src/ui/inputwin.c

@@ -144,10 +144,14 @@ void
 create_input_window(void)
 {
     /* MB_CUR_MAX is evaluated at runtime depending on the current
-     * locale, therefore we check that our own version is big enough
-     * and bail out if it isn't.
+     * locale; ensure our own compiled-in maximum is sufficient.
+     * Fail gracefully instead of aborting in production.
      */
-    assert(MB_CUR_MAX <= PROF_MB_CUR_MAX);
+    if (MB_CUR_MAX > PROF_MB_CUR_MAX) {
+        log_error("Locale MB_CUR_MAX (%zu) exceeds compiled limit (%d)", (size_t)MB_CUR_MAX, PROF_MB_CUR_MAX);
+        cons_show_error("Unsupported locale. Before running, execute in terminal: export LC_ALL=C.UTF-8");
+        return;
+    }
 #ifdef NCURSES_REENTRANT
     set_escdelay(25);
 #else
@@ -163,6 +167,10 @@ create_input_window(void)
     rl_callback_handler_install(NULL, _inp_rl_linehandler);
 
     inp_win = newpad(1, INP_WIN_MAX);
+    if (!inp_win) {
+        log_error("Failed to allocate input window pad");
+        return;
+    }
     wbkgd(inp_win, theme_attrs(THEME_INPUT_TEXT));
     keypad(inp_win, TRUE);
     wmove(inp_win, 0, 0);
@@ -238,6 +246,9 @@ inp_readline(void)
 void
 inp_win_resize(void)
 {
+    if (!inp_win) {
+        return;
+    }
     int col = getcurx(inp_win);
     int wcols = getmaxx(stdscr);
 
@@ -285,8 +296,10 @@ void
 inp_close(void)
 {
     rl_callback_handler_remove();
-    delwin(inp_win);
-    inp_win = NULL;
+    if (inp_win) {
+        delwin(inp_win);
+        inp_win = NULL;
+    }
     fclose(discard);
     discard = NULL;
 }
@@ -294,6 +307,9 @@ inp_close(void)
 char*
 inp_get_line(void)
 {
+    if (!inp_win) {
+        return NULL;
+    }
     werase(inp_win);
     wmove(inp_win, 0, 0);
     _inp_win_update_virtual();
@@ -318,6 +334,9 @@ inp_set_line(const char* const new_line)
 char*
 inp_get_password(void)
 {
+    if (!inp_win) {
+        return NULL;
+    }
     werase(inp_win);
     wmove(inp_win, 0, 0);
     _inp_win_update_virtual();

src/ui/statusbar.c

@@ -40,6 +40,8 @@
 #include <string.h>
 #include <stdlib.h>
 
+#include "log.h"
+
 #ifdef HAVE_NCURSESW_NCURSES_H
 #include <ncursesw/ncurses.h>
 #elif HAVE_NCURSES_H
@@ -111,16 +113,24 @@ status_bar_init(void)
 
     int row = screen_statusbar_row();
     int cols = getmaxx(stdscr);
+    if (cols <= 0) {
+        log_warning("status_bar_init: invalid cols %d, defaulting to 1", cols);
+        cols = 1;
+    }
     statusbar_win = newwin(1, cols, row, 0);
 
-    status_bar_draw();
+    if (statusbar_win) {
+        status_bar_draw();
+    }
 }
 
 void
 status_bar_close(void)
 {
-    delwin(statusbar_win);
-    statusbar_win = NULL;
+    if (statusbar_win) {
+        delwin(statusbar_win);
+        statusbar_win = NULL;
+    }
     if (statusbar) {
         if (statusbar->time) {
             g_free(statusbar->time);
@@ -145,7 +155,14 @@ status_bar_close(void)
 void
 status_bar_resize(void)
 {
+    if (!statusbar_win) {
+        return;
+    }
     int cols = getmaxx(stdscr);
+    if (cols <= 0) {
+        log_warning("status_bar_resize: invalid cols %d, defaulting to 1", cols);
+        cols = 1;
+    }
     werase(statusbar_win);
     int row = screen_statusbar_row();
     wresize(statusbar_win, 1, cols);
@@ -285,6 +302,9 @@ status_bar_clear_fulljid(void)
 void
 status_bar_draw(void)
 {
+    if (!statusbar_win) {
+        return;
+    }
     werase(statusbar_win);
     wbkgd(statusbar_win, theme_attrs(THEME_STATUS_TEXT));
 
@@ -674,8 +694,13 @@ _display_name(StatusBarTab* tab)
         fullname = g_strconcat(mucwin_title, " conf", NULL);
     } else if (tab->window_type == WIN_PRIVATE) {
         auto_jid Jid* jid = jid_create(tab->identifier);
-        auto_gchar gchar* mucwin_title = mucwin_generate_title(jid->barejid, PREF_STATUSBAR_ROOM_TITLE);
-        fullname = g_strconcat(mucwin_title, "/", jid->resourcepart, NULL);
+        if (jid) {
+            auto_gchar gchar* mucwin_title = mucwin_generate_title(jid->barejid, PREF_STATUSBAR_ROOM_TITLE);
+            fullname = g_strconcat(mucwin_title, "/", jid->resourcepart, NULL);
+        } else {
+            // Fallback: use identifier directly if JID parsing failed
+            fullname = strdup(tab->identifier);
+        }
     } else {
         fullname = strdup("window");
     }

src/ui/titlebar.c

@@ -73,9 +73,16 @@ void
 create_title_bar(void)
 {
     int cols = getmaxx(stdscr);
+    if (cols <= 0) {
+        cols = 1;
+    }
 
     int row = screen_titlebar_row();
     win = newwin(1, cols, row, 0);
+    if (!win) {
+        // Failed to create title bar window; skip initialization to avoid NULL deref
+        return;
+    }
     wbkgd(win, theme_attrs(THEME_TITLE_TEXT));
     title_bar_console();
     title_bar_set_presence(CONTACT_OFFLINE);
@@ -88,13 +95,18 @@ create_title_bar(void)
 void
 free_title_bar(void)
 {
-    delwin(win);
-    win = NULL;
+    if (win) {
+        delwin(win);
+        win = NULL;
+    }
 }
 
 void
 title_bar_update_virtual(void)
 {
+    if (!win) {
+        return;
+    }
     ProfWin* window = wins_get_current();
     if (window->type != WIN_CONSOLE) {
         if (typing_elapsed) {
@@ -114,7 +126,13 @@ title_bar_update_virtual(void)
 void
 title_bar_resize(void)
 {
+    if (!win) {
+        return;
+    }
     int cols = getmaxx(stdscr);
+    if (cols <= 0) {
+        cols = 1;
+    }
 
     werase(win);
 
@@ -131,6 +149,9 @@ title_bar_resize(void)
 void
 title_bar_console(void)
 {
+    if (!win) {
+        return;
+    }
     werase(win);
     if (typing_elapsed) {
         g_timer_destroy(typing_elapsed);
@@ -192,6 +213,9 @@ title_bar_set_typing(gboolean is_typing)
 static void
 _title_bar_draw(void)
 {
+    if (!win) {
+        return;
+    }
     int pos;
     int maxrightpos;
     ProfWin* current = wins_get_current();

src/ui/window.c

@@ -75,12 +75,22 @@ static void _win_print_internal(ProfWin* window, const char* show_char, int pad_
                                 int flags, theme_item_t theme_item, const char* const from, const char* const message, DeliveryReceipt* receipt);
 static void _win_print_wrapped(WINDOW* win, const char* const message, size_t indent, int pad_indent);
 
+// Helper: clamp a subwindow width to a sane range [1, cols-1] if possible
+static int
+_check_subwin_width(int cols, int width)
+{
+    return cols <= 1 ? 1 : CLAMP(width, 1, cols - 1);
+}
+
 int
 win_roster_cols(void)
 {
     int roster_win_percent = prefs_get_roster_size();
     int cols = getmaxx(stdscr);
-    return CEILING((((double)cols) / 100) * roster_win_percent);
+    int width = CEILING((((double)cols) / 100) * roster_win_percent);
+    // Clamp to a sane range to avoid zero/full-width pads
+    width = _check_subwin_width(cols, width);
+    return width;
 }
 
 int
@@ -88,7 +98,10 @@ win_occpuants_cols(void)
 {
     int occupants_win_percent = prefs_get_occupants_size();
     int cols = getmaxx(stdscr);
-    return CEILING((((double)cols) / 100) * occupants_win_percent);
+    int width = CEILING((((double)cols) / 100) * occupants_win_percent);
+    // Clamp to a sane range to avoid zero/full-width pads
+    width = _check_subwin_width(cols, width);
+    return width;
 }
 
 static ProfLayout*
@@ -144,6 +157,7 @@ win_create_console(void)
 ProfWin*
 win_create_chat(const char* const barejid)
 {
+    assert(barejid != NULL);
     ProfChatWin* new_win = malloc(sizeof(ProfChatWin));
     new_win->window.type = WIN_CHAT;
     new_win->window.scroll_state = WIN_SCROLL_INNER;
@@ -175,6 +189,7 @@ win_create_chat(const char* const barejid)
 ProfWin*
 win_create_muc(const char* const roomjid)
 {
+    assert(roomjid != NULL);
     ProfMucWin* new_win = malloc(sizeof(ProfMucWin));
     int cols = getmaxx(stdscr);
 
@@ -233,6 +248,8 @@ win_create_muc(const char* const roomjid)
 ProfWin*
 win_create_config(const char* const roomjid, DataForm* form, ProfConfWinCallback submit, ProfConfWinCallback cancel, const void* userdata)
 {
+    assert(roomjid != NULL);
+    assert(form != NULL);
     ProfConfWin* new_win = malloc(sizeof(ProfConfWin));
     new_win->window.type = WIN_CONFIG;
     new_win->window.scroll_state = WIN_SCROLL_INNER;
@@ -251,6 +268,7 @@ win_create_config(const char* const roomjid, DataForm* form, ProfConfWinCallback
 ProfWin*
 win_create_private(const char* const fulljid)
 {
+    assert(fulljid != NULL);
     ProfPrivateWin* new_win = malloc(sizeof(ProfPrivateWin));
     new_win->window.type = WIN_PRIVATE;
     new_win->window.scroll_state = WIN_SCROLL_INNER;
@@ -281,6 +299,8 @@ win_create_xmlconsole(void)
 ProfWin*
 win_create_plugin(const char* const plugin_name, const char* const tag)
 {
+    assert(plugin_name != NULL);
+    assert(tag != NULL);
     ProfPluginWin* new_win = malloc(sizeof(ProfPluginWin));
     new_win->window.type = WIN_PLUGIN;
     new_win->window.scroll_state = WIN_SCROLL_INNER;
@@ -297,6 +317,7 @@ win_create_plugin(const char* const plugin_name, const char* const tag)
 ProfWin*
 win_create_vcard(vCard* vcard)
 {
+    assert(vcard != NULL);
     ProfVcardWin* new_win = malloc(sizeof(ProfVcardWin));
     new_win->window.type = WIN_VCARD;
     new_win->window.scroll_state = WIN_SCROLL_INNER;
@@ -348,7 +369,7 @@ win_get_title(ProfWin* window)
         const ProfConfWin* confwin = (ProfConfWin*)window;
         assert(confwin->memcheck == PROFCONFWIN_MEMCHECK);
         auto_gchar gchar* mucwin_title = mucwin_generate_title(confwin->roomjid, PREF_TITLEBAR_MUC_TITLE);
-        if (confwin->form->modified) {
+        if (confwin->form && confwin->form->modified) {
             return g_strconcat(mucwin_title, " config *", NULL);
         }
         return g_strconcat(mucwin_title, " config", NULL);
@@ -556,7 +577,25 @@ win_show_subwin(ProfWin* window)
     }
 
     ProfLayoutSplit* layout = (ProfLayoutSplit*)window->layout;
+    // If a subwindow already exists (e.g. repeated call), destroy it to avoid leaks
+    if (layout->subwin) {
+        delwin(layout->subwin);
+        layout->subwin = NULL;
+    }
+
+    // Ensure minimum width to avoid creating a zero-width pad
+    if (subwin_cols <= 0) {
+        subwin_cols = 1;
+    }
+
     layout->subwin = newpad(PAD_SIZE, subwin_cols);
+    if (layout->subwin == NULL) {
+        // Failed to allocate subwindow; keep base window resized to full width
+        log_error("Failed to create subwindow pad (cols=%d)", subwin_cols);
+        wresize(layout->base.win, PAD_SIZE, cols);
+        win_redraw(window);
+        return;
+    }
     wbkgd(layout->subwin, theme_attrs(THEME_TEXT));
     wresize(layout->base.win, PAD_SIZE, cols - subwin_cols);
     win_redraw(window);
@@ -910,6 +949,11 @@ win_refresh_with_subwin(ProfWin* window)
     int row_end = screen_mainwin_row_end();
     ProfLayoutSplit* layout = (ProfLayoutSplit*)window->layout;
 
+    // Safety: if subwindow is not active, nothing to refresh
+    if (layout == NULL || layout->subwin == NULL) {
+        return;
+    }
+
     if (window->type == WIN_MUC) {
         subwin_cols = win_occpuants_cols();
     } else if (window->type == WIN_CONSOLE) {
@@ -2038,7 +2082,14 @@ win_print_loading_history(ProfWin* window)
     gboolean is_buffer_empty = buffer_size(window->layout->buffer) == 0;
 
     if (!is_buffer_empty) {
-        timestamp = buffer_get_entry(window->layout->buffer, 0)->time;
+        ProfBuffEntry* first = buffer_get_entry(window->layout->buffer, 0);
+        if (first && first->time) {
+            timestamp = first->time;
+        } else {
+            // Fallback to current time if entry/time is unavailable
+            timestamp = g_date_time_new_now_local();
+            is_buffer_empty = TRUE; // ensure we unref fallback timestamp below
+        }
     } else {
         timestamp = g_date_time_new_now_local();
     }
@@ -2238,7 +2289,7 @@ void
 win_handle_command_exec_result_note(ProfWin* window, const char* const type, const char* const value)
 {
     assert(window != NULL);
-    win_println(window, THEME_DEFAULT, "!", value);
+    win_println(window, THEME_DEFAULT, "!", "%s", value);
 }
 
 void

src/ui/window_list.c

@@ -407,8 +407,10 @@ wins_get_by_string(const char* str)
         if (barejid) {
             ProfChatWin* chatwin = wins_get_chat(barejid);
             if (chatwin) {
+                free(barejid);
                 return (ProfWin*)chatwin;
             }
+            free(barejid);
         }
     }
 
@@ -603,6 +605,9 @@ wins_new_xmlconsole(void)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_xmlconsole();
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
     autocomplete_add(wins_ac, "xmlconsole");
     autocomplete_add(wins_close_ac, "xmlconsole");
@@ -614,6 +619,9 @@ wins_new_chat(const char* const barejid)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_chat(barejid);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
 
     autocomplete_add(wins_ac, barejid);
@@ -637,6 +645,9 @@ wins_new_muc(const char* const roomjid)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_muc(roomjid);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
     autocomplete_add(wins_ac, roomjid);
     autocomplete_add(wins_close_ac, roomjid);
@@ -651,6 +662,9 @@ wins_new_config(const char* const roomjid, DataForm* form, ProfConfWinCallback s
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_config(roomjid, form, submit, cancel, userdata);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
 
     return newwin;
@@ -661,6 +675,9 @@ wins_new_private(const char* const fulljid)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_private(fulljid);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
     autocomplete_add(wins_ac, fulljid);
     autocomplete_add(wins_close_ac, fulljid);
@@ -675,6 +692,9 @@ wins_new_plugin(const char* const plugin_name, const char* const tag)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_plugin(plugin_name, tag);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
     autocomplete_add(wins_ac, tag);
     autocomplete_add(wins_close_ac, tag);
@@ -686,6 +706,9 @@ wins_new_vcard(vCard* vcard)
 {
     int result = _wins_get_next_available_num(keys);
     ProfWin* newwin = win_create_vcard(vcard);
+    if (!newwin) {
+        return NULL;
+    }
     _wins_htable_insert(windows, GINT_TO_POINTER(result), newwin);
 
     return newwin;

src/xmpp/capabilities.c

@@ -171,16 +171,15 @@ caps_get_features(void)
 {
     GList* result = NULL;
 
-    GList* features_as_list = g_hash_table_get_keys(prof_features);
-    GList* curr = features_as_list;
-    while (curr) {
-        result = g_list_append(result, strdup(curr->data));
-        curr = g_list_next(curr);
+    GHashTableIter iter;
+    gpointer key, value;
+    g_hash_table_iter_init(&iter, prof_features);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        result = g_list_append(result, strdup((char*)key));
     }
-    g_list_free(features_as_list);
 
     GList* plugin_features = plugins_get_disco_features();
-    curr = plugin_features;
+    GList* curr = plugin_features;
     while (curr) {
         result = g_list_append(result, strdup(curr->data));
         curr = g_list_next(curr);

src/xmpp/connection.c

@@ -148,7 +148,7 @@ connection_init(void)
     if (string_to_verbosity(v, &verbosity, &err_msg)) {
         xmpp_ctx_set_verbosity(conn.xmpp_ctx, verbosity);
     } else {
-        cons_show(err_msg);
+        cons_show("%s", err_msg);
     }
     conn.xmpp_conn = xmpp_conn_new(conn.xmpp_ctx);
 
@@ -638,22 +638,18 @@ gboolean
 connection_supports(const char* const feature)
 {
     gboolean ret = FALSE;
-    GList* jids = g_hash_table_get_keys(conn.features_by_jid);
+    GHashTableIter iter;
+    gpointer key, value;
 
-    GList* curr = jids;
-    while (curr) {
-        char* jid = curr->data;
-        GHashTable* features = g_hash_table_lookup(conn.features_by_jid, jid);
+    g_hash_table_iter_init(&iter, conn.features_by_jid);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        GHashTable* features = (GHashTable*)value;
         if (features && g_hash_table_lookup(features, feature)) {
             ret = TRUE;
             break;
         }
-
-        curr = g_list_next(curr);
     }
 
-    g_list_free(jids);
-
     return ret;
 }
 
@@ -664,22 +660,17 @@ connection_jid_for_feature(const char* const feature)
         return NULL;
     }
 
-    GList* jids = g_hash_table_get_keys(conn.features_by_jid);
+    GHashTableIter iter;
+    gpointer key, value;
 
-    GList* curr = jids;
-    while (curr) {
-        char* jid = curr->data;
-        GHashTable* features = g_hash_table_lookup(conn.features_by_jid, jid);
+    g_hash_table_iter_init(&iter, conn.features_by_jid);
+    while (g_hash_table_iter_next(&iter, &key, &value)) {
+        GHashTable* features = (GHashTable*)value;
         if (features && g_hash_table_lookup(features, feature)) {
-            g_list_free(jids);
-            return jid;
+            return (const char*)key;
         }
-
-        curr = g_list_next(curr);
     }
 
-    g_list_free(jids);
-
     return NULL;
 }
 
@@ -1034,7 +1025,7 @@ _connection_handler(xmpp_conn_t* const xmpp_conn, const xmpp_conn_event_t status
                 conn.sm_state = xmpp_conn_get_sm_state(conn.xmpp_conn);
                 if (send_queue_len > 0 && prefs_get_boolean(PREF_STROPHE_SM_RESEND)) {
                     conn.queued_messages = calloc(send_queue_len + 1, sizeof(*conn.queued_messages));
-                    for (int n = 0; n < send_queue_len && conn.queued_messages[n]; ++n) {
+                    for (int n = 0; n < send_queue_len; ++n) {
                         conn.queued_messages[n] = xmpp_conn_send_queue_drop_element(conn.xmpp_conn, XMPP_QUEUE_OLDEST);
                     }
                 } else if (send_queue_len > 0) {
@@ -1189,12 +1180,13 @@ connection_debug_print_features()
             continue;
         }
 
-        GList* feature_keys = g_hash_table_get_keys(features);
-        for (GList* l = feature_keys; l != NULL; l = l->next) {
-            const char* feature = (const char*)l->data;
+        GHashTableIter feature_iter;
+        gpointer feature_key, feature_value;
+        g_hash_table_iter_init(&feature_iter, features);
+        while (g_hash_table_iter_next(&feature_iter, &feature_key, &feature_value)) {
+            const char* feature = (const char*)feature_key;
             log_debug("%s:\t%s", jid, feature);
         }
-        g_list_free(feature_keys);
     }
 
     log_debug("=== End of Features ===");

src/xmpp/form.c

@@ -437,18 +437,7 @@ form_get_form_type_field(DataForm* form)
 gboolean
 form_tag_exists(DataForm* form, const char* const tag)
 {
-    GList* tags = g_hash_table_get_keys(form->tag_to_var);
-    GList* curr = tags;
-    while (curr) {
-        if (g_strcmp0(curr->data, tag) == 0) {
-            g_list_free(tags);
-            return TRUE;
-        }
-        curr = g_list_next(curr);
-    }
-
-    g_list_free(tags);
-    return FALSE;
+    return g_hash_table_contains(form->tag_to_var, tag);
 }
 
 form_field_type_t

src/xmpp/iq.c

@@ -2532,9 +2532,6 @@ _disco_items_result_handler(xmpp_stanza_t* const stanza)
     }
 
     xmpp_stanza_t* child = xmpp_stanza_get_children(query);
-    if (child == NULL) {
-        return;
-    }
 
     while (child) {
         const char* stanza_name = xmpp_stanza_get_name(child);

src/xmpp/message.c

@@ -868,7 +868,7 @@ _handle_error(xmpp_stanza_t* const stanza)
     g_string_append(log_msg, " error=");
     g_string_append(log_msg, err_msg);
 
-    log_info(log_msg->str);
+    log_info("%s", log_msg->str);
 
     g_string_free(log_msg, TRUE);
 

src/xmpp/ox.c

@@ -326,7 +326,7 @@ _ox_metadata_result(xmpp_stanza_t* const stanza, void* const userdata)
 
         if (fingerprint) {
             if (strlen(fingerprint) == KEYID_LENGTH) {
-                cons_show(fingerprint);
+                cons_show("%s", fingerprint);
             } else {
                 cons_show("OX: Wrong char size of public key");
                 log_error("[OX] Wrong chat size of public key %s", fingerprint);

src/xmpp/presence.c

@@ -455,7 +455,7 @@ _presence_error_handler(xmpp_stanza_t* const stanza)
     g_string_append(log_msg, " error=");
     g_string_append(log_msg, err_msg);
 
-    log_info(log_msg->str);
+    log_info("%s", log_msg->str);
 
     g_string_free(log_msg, TRUE);
 

tests/functionaltests/functionaltests.c

@@ -15,10 +15,10 @@
  * functional tests run less frequently than unit tests.
  *
  * Tests are organized into groups for better maintainability and parallel execution:
- *   Group 1: Connect, Ping, Rooms, Software
- *   Group 2: Message, Receipts, Roster, Chat Session
- *   Group 3: Presence, Disconnect
- *   Group 4: MUC, Carbons
+ *   Group 1: Connect, Ping, Rooms, Software, Last Activity  (19 tests)
+ *   Group 2: Message, Receipts, Roster, DB History           (22 tests)
+ *   Group 3: Chat Session, Presence, Disconnect              (22 tests)
+ *   Group 4: MUC, Carbons                                    (21 tests)
  *
  * Parallel execution:
  *   ./functionaltests        - run all tests sequentially
@@ -52,6 +52,8 @@
 #include "test_software.h"
 #include "test_muc.h"
 #include "test_disconnect.h"
+#include "test_lastactivity.h"
+#include "test_history.h"
 
 /* Macro to wrap each test with setup/teardown functions */
 #define PROF_FUNC_TEST(test) cmocka_unit_test_setup_teardown(test, init_prof_test, close_prof_test)
@@ -69,9 +71,16 @@ main(int argc, char* argv[])
         }
     }
 
+    char group_env[16];
+    snprintf(group_env, sizeof(group_env), "%d", group);
+    setenv("PROF_TEST_GROUP", group_env, 1);
+    
+    fprintf(stderr, "[PROF_TEST] Starting functional tests, group=%d\n", group);
+
     /* ============================================================
-     * GROUP 1: Connect, Ping, Rooms, Software
+     * GROUP 1: Connect, Ping, Rooms, Software, Last Activity
      * Basic XMPP session establishment and server queries
+     * (19 tests)
      * ============================================================ */
     const struct CMUnitTest group1_tests[] = {
         /* Connection tests - verify login, roster, bookmarks */
@@ -98,11 +107,16 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(display_software_version_result_when_from_domainpart),
         PROF_FUNC_TEST(show_message_in_chat_window_when_no_resource),
         PROF_FUNC_TEST(display_software_version_result_in_chat),
+
+        /* Last Activity - XEP-0012 */
+        PROF_FUNC_TEST(responds_to_last_activity_request),
+        PROF_FUNC_TEST(last_activity_request_to_contact),
     };
 
     /* ============================================================
-     * GROUP 2: Message, Receipts, Roster, Chat Session
+     * GROUP 2: Message, Receipts, Roster, DB History
      * Core messaging and contact management
+     * (23 tests)
      * ============================================================ */
     const struct CMUnitTest group2_tests[] = {
         /* Basic message send/receive */
@@ -122,6 +136,29 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(sends_remove_item_nick),
         PROF_FUNC_TEST(sends_nick_change),
 
+        /* Database persistence - message write+read round-trip */
+        PROF_FUNC_TEST(message_db_history_on_reopen),
+        PROF_FUNC_TEST(message_db_history_multiple),
+        PROF_FUNC_TEST(message_db_history_contact_isolation),
+        PROF_FUNC_TEST(message_db_history_special_chars),
+        PROF_FUNC_TEST(message_db_history_outgoing),
+        PROF_FUNC_TEST(message_db_history_dialog),
+        PROF_FUNC_TEST(message_db_history_empty),
+        PROF_FUNC_TEST(message_db_history_long_message),
+        PROF_FUNC_TEST(message_db_history_newline),
+        PROF_FUNC_TEST(message_db_history_service_chars),
+#ifdef HAVE_HISTORY_VERIFY
+        PROF_FUNC_TEST(message_db_history_verify),
+#endif
+        PROF_FUNC_TEST(message_db_history_lmc),
+    };
+
+    /* ============================================================
+     * GROUP 3: Chat Session, Presence, Disconnect
+     * Session routing, status management, clean teardown
+     * (22 tests)
+     * ============================================================ */
+    const struct CMUnitTest group3_tests[] = {
         /* Chat session management - bare/full JID routing */
         PROF_FUNC_TEST(sends_message_to_barejid_when_contact_offline),
         PROF_FUNC_TEST(sends_message_to_barejid_when_contact_online),
@@ -129,13 +166,8 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(sends_subsequent_messages_to_fulljid),
         PROF_FUNC_TEST(resets_to_barejid_after_presence_received),
         PROF_FUNC_TEST(new_session_when_message_received_from_different_fulljid),
-    };
 
-    /* ============================================================
-     * GROUP 3: Presence, Disconnect
-     * Online/away/xa/dnd/chat status management
-     * ============================================================ */
-    const struct CMUnitTest group3_tests[] = {
+        /* Presence - online/away/xa/dnd/chat status management */
         PROF_FUNC_TEST(presence_online),
         PROF_FUNC_TEST(presence_online_with_message),
         PROF_FUNC_TEST(presence_away),
@@ -159,6 +191,7 @@ main(int argc, char* argv[])
     /* ============================================================
      * GROUP 4: MUC, Carbons
      * Multi-user chat and message synchronization
+     * (21 tests)
      * ============================================================ */
     const struct CMUnitTest group4_tests[] = {
         /* MUC room join with various options - XEP-0045 */
@@ -182,6 +215,10 @@ main(int argc, char* argv[])
         PROF_FUNC_TEST(shows_first_message_in_console_when_window_not_focussed),
         PROF_FUNC_TEST(shows_no_message_in_console_when_window_not_focussed),
 
+        /* MUC moderation - XEP-0045 room admin */
+        PROF_FUNC_TEST(sends_affiliation_list_request),
+        PROF_FUNC_TEST(sends_kick_request),
+
         /* Message Carbons - XEP-0280 (message sync across devices) */
         PROF_FUNC_TEST(send_enable_carbons),
         PROF_FUNC_TEST(connect_with_carbons_enabled),
@@ -197,9 +234,9 @@ main(int argc, char* argv[])
         const struct CMUnitTest* tests;
         size_t count;
     } groups[] = {
-        { "Group 1: Connect/Ping/Rooms/Software", group1_tests, ARRAY_SIZE(group1_tests) },
-        { "Group 2: Message/Receipts/Roster/Session", group2_tests, ARRAY_SIZE(group2_tests) },
-        { "Group 3: Presence/Disconnect", group3_tests, ARRAY_SIZE(group3_tests) },
+        { "Group 1: Connect/Ping/Rooms/Software/LastActivity", group1_tests, ARRAY_SIZE(group1_tests) },
+        { "Group 2: Message/Receipts/Roster/DBHistory", group2_tests, ARRAY_SIZE(group2_tests) },
+        { "Group 3: Session/Presence/Disconnect", group3_tests, ARRAY_SIZE(group3_tests) },
         { "Group 4: MUC/Carbons", group4_tests, ARRAY_SIZE(group4_tests) },
     };
     const int num_groups = ARRAY_SIZE(groups);

tests/functionaltests/proftest.c

@@ -17,6 +17,9 @@
 
 #include "proftest.h"
 
+/* Number of parallel test groups for CI builds */
+#define TEST_GROUPS 4
+
 char *config_orig;
 char *data_orig;
 
@@ -136,8 +139,14 @@ _create_logs_dir(void)
 void
 _cleanup_dirs(void)
 {
+    const char *group_env = getenv("PROF_TEST_GROUP");
+    int group = group_env ? atoi(group_env) : 0;
+    int dir_id = (group >= 1 && group <= TEST_GROUPS) ? group : stub_port;
+    
+    printf("[PROF_TEST] Cleaning up directories for group %d (dir_id %d)\n", group, dir_id);
+    
     char cmd[512];
-    snprintf(cmd, sizeof(cmd), "rm -rf ./tests/functionaltests/files/%d", stub_port);
+    snprintf(cmd, sizeof(cmd), "rm -rf ./test-files/%d", dir_id);
     int res = system(cmd);
     if (res == -1) {
         assert_true(FALSE);
@@ -221,30 +230,74 @@ prof_start(void)
     /* Set non-blocking mode for reading */
     int flags = fcntl(fd, F_GETFL, 0);
     fcntl(fd, F_SETFL, flags | O_NONBLOCK);
+    
+    /* Brief wait for process to initialize */
+    usleep(50000);  /* 50ms */
 }
 
 int
 init_prof_test(void **state)
 {
+    /* Get test group from environment for static resource allocation */
+    const char *group_env = getenv("PROF_TEST_GROUP");
+    int group = group_env ? atoi(group_env) : 0;
+    
+    /* Get build index for port offset (for parallel CI builds) */
+    const char *build_env = getenv("PROF_BUILD_INDEX");
+    int build_idx = build_env ? atoi(build_env) : 0;
+    
+    /* Calculate port base: each build uses a different range of TEST_GROUPS ports.
+     * Build 0 (local/default): 5230-5233, Full: 5230-5233, Minimal: 5234-5237, etc.
+     * Build 0 and Full share the same range because build 0 is for local runs or sequential run (no parallel builds),
+     * while Full/Minimal/NoEncrypt/Default are used in CI where they run in parallel. */
+    int port_base = 5230 + ((build_idx > 0 ? build_idx - 1 : 0) * TEST_GROUPS);
+    
+    /* Static resource allocation to avoid conflicts in parallel execution.
+     * Group 1-4: use static port assignment.
+     * Group 0 (all groups): use dynamic allocation as fallback. */
     gboolean started = FALSE;
-    for (int p = 5230; p < 5250; ++p) {
-        int ret = stbbr_start(STBBR_LOGDEBUG, p, 0);
-        if (ret == 0) {
-            stub_port = p;
+    
+    if (group >= 1 && group <= TEST_GROUPS) {
+        /* Static allocation: each group gets a dedicated port */
+        stub_port = port_base + group - 1;
+        printf("[PROF_TEST] Build %d, Group %d: trying port %d\n", build_idx, group, stub_port);
+        
+        if (stbbr_start(STBBR_LOGDEBUG, stub_port, 0) == 0) {
             started = TRUE;
-            break;
+            printf("[PROF_TEST] Started stabber on port %d\n", stub_port);
+        } else {
+            printf("[PROF_TEST] Failed to start stabber on port %d\n", stub_port);
         }
     }
+    
+    /* Fallback to dynamic allocation if static failed or group=0 */
     if (!started) {
-        assert_true(FALSE); // could not start stabber on any port in range
+        printf("[PROF_TEST] Using dynamic port allocation\n");
+        for (int p = port_base; p < port_base + 20; ++p) {
+            if (stbbr_start(STBBR_LOGDEBUG, p, 0) == 0) {
+                stub_port = p;
+                started = TRUE;
+                printf("[PROF_TEST] Started stabber on port %d\n", stub_port);
+                break;
+            }
+        }
+    }
+    
+    if (!started) {
+        fprintf(stderr, "[PROF_TEST] ERROR: could not start stabber on any port\n");
         return -1;
     }
 
-    // Generate unique XDG paths based on stub_port for parallel execution
+    /* Generate unique XDG paths based on group for parallel execution.
+     * Use ./test-files/ in current (build) directory for out-of-tree builds compatibility. */
+    int dir_id = (group >= 1 && group <= TEST_GROUPS) ? group : stub_port;
     snprintf(xdg_config_home, sizeof(xdg_config_home),
-             "./tests/functionaltests/files/%d/xdg_config_home", stub_port);
+             "./test-files/%d/xdg_config_home", dir_id);
     snprintf(xdg_data_home, sizeof(xdg_data_home),
-             "./tests/functionaltests/files/%d/xdg_data_home", stub_port);
+             "./test-files/%d/xdg_data_home", dir_id);
+    
+    printf("[PROF_TEST] Group %d using directories: config=%s, data=%s\n", 
+           group, xdg_config_home, xdg_data_home);
 
     // Give stabber server thread time to start listening
     usleep(100000); // 100ms
@@ -401,6 +454,16 @@ prof_output_regex(const char *pattern)
         usleep(50000);  /* 50ms */
     }
     
+    /* Timeout reached - log diagnostic info */
+    fprintf(stderr, "Timeout waiting for regex '%s' after %d seconds. Last output:\n", pattern, expect_timeout);
+    size_t len = strlen(output_buffer);
+    if (len > 500) {
+        fprintf(stderr, "...%s", output_buffer + len - 500);
+    } else {
+        fprintf(stderr, "%s", output_buffer);
+    }
+    fprintf(stderr, "\n");
+    
     regfree(&regex);
     return 0;
 }

tests/functionaltests/test_history.c

@@ -0,0 +1,475 @@
+/*
+ * test_history.c
+ *
+ * Functional test for database message persistence.
+ * Verifies that a received chat message is written to the database
+ * and loaded back as history when the chat window is reopened.
+ *
+ * These tests only exercise the public log_database API through normal
+ * profanity UI operations, so they work with any storage backend.
+ */
+
+#include <glib.h>
+#include <stdio.h>
+#include <string.h>
+#include "prof_cmocka.h"
+#include <stdlib.h>
+#include <string.h>
+
+#include <stabber.h>
+
+#include "proftest.h"
+
+/*
+ * Test: message written to DB is loaded as history on chat window reopen.
+ *
+ * Flow:
+ *   1. Connect and enable /history on (enables PREF_CHLOG + PREF_HISTORY)
+ *   2. Receive a chat message while on the console window — the message
+ *      body is NOT rendered to the terminal (only a console notification
+ *      "<< chat message: ... (win N)" appears), but the message IS
+ *      written to the database via chat_log_msg_in()
+ *   3. Close the auto-created chat window (destroying its in-memory buffer)
+ *   4. Reopen the chat window with /msg — chatwin_new() calls
+ *      _chatwin_history() which reads from log_database_get_previous_chat()
+ *   5. Assert the message body appears in the terminal output, proving
+ *      it was persisted to and read back from the database
+ */
+void
+message_db_history_on_reopen(void **state)
+{
+    prof_connect();
+
+    /* Enable chat logging and history display */
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Receive a message while on the console window.
+     * The body text is NOT printed to the visible terminal — only the
+     * console notification appears.  The message is logged to the DB. */
+    stbbr_send(
+        "<message id='hist-db-test-1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>persistence-roundtrip-check-42</body>"
+        "</message>");
+
+    /* Wait for the console notification (proves message was received).
+     * buddy1@localhost is in the roster as "Buddy1", and PREF_RESOURCE_MESSAGE
+     * is on by default, so the display name is "Buddy1/phone". */
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    /* Close the chat window that was auto-created for the incoming message.
+     * This destroys its in-memory buffer so the text is gone from UI. */
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    /* Reopen the chat window — chatwin_new() will load history from DB.
+     * The message body should now appear on screen for the first time. */
+    prof_input("/msg buddy1@localhost");
+
+    /* The history-loaded message must contain the body we sent earlier.
+     * Since the body was never rendered to the terminal before (it was
+     * only in the hidden window's ncurses buffer which was destroyed),
+     * finding it now proves the database write+read round-trip works. */
+    assert_true(prof_output_exact("persistence-roundtrip-check-42"));
+}
+
+/*
+ * Test: multiple messages from the same contact are all preserved.
+ *
+ * Uses different resources so each console notification is unique and
+ * we can reliably synchronise on each delivery before proceeding.
+ */
+void
+message_db_history_multiple(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Three messages from different resources → distinct notifications */
+    stbbr_send(
+        "<message id='multi1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>db-multi-first-aaa</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    stbbr_send(
+        "<message id='multi2' to='stabber@localhost' "
+        "from='buddy1@localhost/laptop' type='chat'>"
+        "<body>db-multi-second-bbb</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/laptop (win 2)"));
+
+    stbbr_send(
+        "<message id='multi3' to='stabber@localhost' "
+        "from='buddy1@localhost/tablet' type='chat'>"
+        "<body>db-multi-third-ccc</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/tablet (win 2)"));
+
+    /* Close and reopen */
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    prof_input("/msg buddy1@localhost");
+
+    /* All three must be present in history */
+    assert_true(prof_output_exact("db-multi-first-aaa"));
+    assert_true(prof_output_exact("db-multi-second-bbb"));
+    assert_true(prof_output_exact("db-multi-third-ccc"));
+}
+
+/*
+ * Test: messages are stored per-contact — buddy1's history does not
+ * leak into buddy2's window.
+ *
+ * 1. Receive from buddy1 and buddy2 while on console (bodies hidden)
+ * 2. Close all chat windows
+ * 3. Open buddy1 → verify buddy1's body present, buddy2's body absent
+ */
+void
+message_db_history_contact_isolation(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Receive from buddy1 */
+    stbbr_send(
+        "<message id='iso1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>isolation-buddy1-only-xyzzy</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    /* Receive from buddy2 */
+    stbbr_send(
+        "<message id='iso2' to='stabber@localhost' "
+        "from='buddy2@localhost/phone' type='chat'>"
+        "<body>isolation-buddy2-only-plugh</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy2/phone (win 3)"));
+
+    /* Close all chat windows at once */
+    prof_input("/close all");
+    assert_true(prof_output_exact("Closed 2 windows."));
+
+    /* Open buddy1 — history should contain ONLY buddy1's message */
+    prof_input("/msg buddy1@localhost");
+    assert_true(prof_output_exact("isolation-buddy1-only-xyzzy"));
+
+    /* buddy2's body was never printed to the terminal (received on
+     * console), so finding it now would mean cross-contact leakage */
+    prof_timeout(3);
+    assert_false(prof_output_exact("isolation-buddy2-only-plugh"));
+    prof_timeout_reset();
+}
+
+/*
+ * Test: special characters survive the DB write+read round-trip.
+ *
+ * The XMPP body uses XML entities (&amp; &lt; &gt; &quot;) which the
+ * XML parser decodes before storage.  The DB must preserve the decoded
+ * characters and return them unchanged.
+ */
+void
+message_db_history_special_chars(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    stbbr_send(
+        "<message id='spec1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>chars: &amp; &lt;tag&gt; &quot;quoted&quot;</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    prof_input("/msg buddy1@localhost");
+
+    /* The decoded text must appear exactly as-is */
+    assert_true(prof_output_exact("chars: & <tag> \"quoted\""));
+}
+
+/*
+ * Test: outgoing message (sent via /msg) persists in DB.
+ *
+ * NOTE: The outgoing body IS rendered to the terminal when sent. Since
+ * prof_output_exact searches the cumulative buffer, the assertion alone
+ * does not conclusively prove DB persistence. However, combined with
+ * the incoming tests, this verifies the end-to-end outgoing write path
+ * and catches crashes in the outgoing DB code.
+ */
+void
+message_db_history_outgoing(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Send outgoing — opens and focuses chat window */
+    prof_input("/msg buddy1@localhost db-outgoing-sent-42");
+    assert_true(prof_output_regex("me: .+db-outgoing-sent-42"));
+
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    /* Reopen — history should load the outgoing message */
+    prof_input("/msg buddy1@localhost");
+    assert_true(prof_output_exact("db-outgoing-sent-42"));
+}
+
+/*
+ * Test: a dialog (outgoing + incoming) is fully preserved in history.
+ *
+ * Sends an outgoing message, then closes the window. A reply arrives
+ * while on the console (body never rendered). After reopen, both sides
+ * of the conversation appear — proving the incoming read from DB works
+ * and the outgoing write path completed without error.
+ */
+void
+message_db_history_dialog(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Phase 1: send outgoing (renders to terminal) */
+    prof_input("/msg buddy1@localhost dialog-out-msg-42");
+    assert_true(prof_output_regex("me: .+dialog-out-msg-42"));
+
+    /* Return to console */
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    /* Phase 2: receive reply on console (body NOT in terminal buffer) */
+    stbbr_send(
+        "<message id='dlg-in' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>dialog-in-reply-77</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    /* Close the auto-created window */
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    /* Phase 3: reopen — history should have both directions */
+    prof_input("/msg buddy1@localhost");
+
+    /* Incoming body conclusively proves DB round-trip */
+    assert_true(prof_output_exact("dialog-in-reply-77"));
+    /* Outgoing body is consistent with DB persistence */
+    assert_true(prof_output_exact("dialog-out-msg-42"));
+}
+
+/*
+ * Test: opening a chat window for a contact with no prior messages
+ * does not crash and the window is usable.
+ */
+void
+message_db_history_empty(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* buddy2 has never exchanged messages — history is empty */
+    prof_input("/msg buddy2@localhost");
+    assert_true(prof_output_exact("buddy2@localhost"));
+
+    /* Verify the window is functional by sending a message */
+    prof_input("empty-history-smoke-test");
+    assert_true(prof_output_regex("me: .+empty-history-smoke-test"));
+}
+
+/*
+ * Test: a long message (1000+ characters) is not truncated by the DB.
+ */
+void
+message_db_history_long_message(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Build a 1020-character body: 1000 x 'A' + unique suffix */
+    char body[1100];
+    memset(body, 'A', 1000);
+    strcpy(body + 1000, "-long-db-end-MARKER");
+
+    char xml[1500];
+    snprintf(xml, sizeof(xml),
+        "<message id='long1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>%s</body>"
+        "</message>", body);
+    stbbr_send(xml);
+
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    prof_input("/msg buddy1@localhost");
+    assert_true(prof_output_exact("-long-db-end-MARKER"));
+}
+
+/*
+ * Test: message body containing embedded newlines (LF) is stored and
+ * loaded correctly.
+ *
+ * Uses XML character reference &#10; for literal newline in body.
+ */
+void
+message_db_history_newline(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    stbbr_send(
+        "<message id='nl1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>nl-first-line-7k&#10;nl-second-line-9m&#10;nl-third-line-2p</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    prof_input("/msg buddy1@localhost");
+    /* Each fragment must survive the round-trip */
+    assert_true(prof_output_exact("nl-first-line-7k"));
+    assert_true(prof_output_exact("nl-second-line-9m"));
+    assert_true(prof_output_exact("nl-third-line-2p"));
+}
+
+/*
+ * Test: characters that could break storage format (backslash, pipe,
+ * percent, braces, brackets, equals) survive DB round-trip.
+ */
+void
+message_db_history_service_chars(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    stbbr_send(
+        "<message id='svc1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>svc: a\\b c|d e%f {g} [h] i=j</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    prof_input("/close 2");
+    assert_true(prof_output_exact("Closed window 2"));
+
+    prof_input("/msg buddy1@localhost");
+    assert_true(prof_output_exact("svc: a\\b c|d e%f {g} [h] i=j"));
+}
+
+#ifdef HAVE_HISTORY_VERIFY
+/*
+ * Test: /history verify reports no issues after normal message writes.
+ */
+void
+message_db_history_verify(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Write a few messages to create non-trivial DB state */
+    stbbr_send(
+        "<message id='ver1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>verify-msg-one</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    stbbr_send(
+        "<message id='ver2' to='stabber@localhost' "
+        "from='buddy2@localhost/phone' type='chat'>"
+        "<body>verify-msg-two</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy2/phone (win 3)"));
+
+    /* Run verify — should find no issues */
+    prof_input("/history verify");
+    assert_true(prof_output_exact("Verification complete: no issues found."));
+}
+#endif /* HAVE_HISTORY_VERIFY */
+
+/*
+ * Test: LMC (Last Message Correction, XEP-0308) — incoming correction
+ * replaces the original in DB history.
+ *
+ * Both messages arrive while focused on the console so their bodies
+ * are never rendered to the terminal. After reopen, only the corrected
+ * text should appear — the original should be absent.
+ */
+void
+message_db_history_lmc(void **state)
+{
+    prof_connect();
+
+    prof_input("/history on");
+    assert_true(prof_output_regex("Chat history enabled\\."));
+
+    /* Original message (body never displayed — received on console) */
+    stbbr_send(
+        "<message id='lmc-orig-1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>lmc-before-correction-aaa</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy1/phone (win 2)"));
+
+    /* Correction replacing the original (XEP-0308).
+     * Use buddy2 message as sync barrier to ensure correction is processed. */
+    stbbr_send(
+        "<message id='lmc-corr-1' to='stabber@localhost' "
+        "from='buddy1@localhost/phone' type='chat'>"
+        "<body>lmc-after-correction-zzz</body>"
+        "<replace id='lmc-orig-1' xmlns='urn:xmpp:message-correct:0'/>"
+        "</message>");
+
+    /* Sync barrier: send from buddy2, wait for its notification */
+    stbbr_send(
+        "<message id='lmc-sync' to='stabber@localhost' "
+        "from='buddy2@localhost/phone' type='chat'>"
+        "<body>lmc-sync-barrier</body>"
+        "</message>");
+    assert_true(prof_output_exact("<< chat message: Buddy2/phone (win 3)"));
+
+    /* Close buddy1 and buddy2 windows */
+    prof_input("/close all");
+    assert_true(prof_output_exact("Closed 2 windows."));
+
+    /* Reopen buddy1 — should have corrected text only */
+    prof_input("/msg buddy1@localhost");
+    assert_true(prof_output_exact("lmc-after-correction-zzz"));
+
+    /* Original body was never in the terminal buffer (received on console).
+     * Its absence in history proves the correction was applied in the DB. */
+    prof_timeout(3);
+    assert_false(prof_output_exact("lmc-before-correction-aaa"));
+    prof_timeout_reset();
+}

tests/functionaltests/test_history.h

@@ -0,0 +1,14 @@
+void message_db_history_on_reopen(void **state);
+void message_db_history_multiple(void **state);
+void message_db_history_contact_isolation(void **state);
+void message_db_history_special_chars(void **state);
+void message_db_history_outgoing(void **state);
+void message_db_history_dialog(void **state);
+void message_db_history_empty(void **state);
+void message_db_history_long_message(void **state);
+void message_db_history_newline(void **state);
+void message_db_history_service_chars(void **state);
+#ifdef HAVE_HISTORY_VERIFY
+void message_db_history_verify(void **state);
+#endif
+void message_db_history_lmc(void **state);

tests/functionaltests/test_lastactivity.c

@@ -0,0 +1,63 @@
+/*
+ * test_lastactivity.c
+ * Functional tests for Last Activity (XEP-0012)
+ */
+#include <glib.h>
+#include "prof_cmocka.h"
+#include <stdlib.h>
+#include <string.h>
+
+#include <stabber.h>
+
+#include "proftest.h"
+
+void
+responds_to_last_activity_request(void **state)
+{
+    prof_connect();
+
+    // Send incoming last activity request
+    stbbr_send(
+        "<iq id='last1' type='get' to='stabber@localhost/profanity' from='buddy1@localhost/mobile'>"
+            "<query xmlns='jabber:iq:last'/>"
+        "</iq>"
+    );
+
+    // Verify that CProof responds with last activity info
+    // The 'seconds' attribute indicates idle time
+    assert_true(stbbr_received(
+        "<iq id='last1' type='result' to='buddy1@localhost/mobile'>"
+            "<query xmlns='jabber:iq:last' seconds='*'/>"
+        "</iq>"
+    ));
+}
+
+void
+last_activity_request_to_contact(void **state)
+{
+    prof_connect();
+
+    stbbr_send(
+        "<presence to='stabber@localhost' from='buddy1@localhost/mobile'>"
+            "<priority>10</priority>"
+            "<status>I'm here</status>"
+        "</presence>"
+    );
+    assert_true(prof_output_exact("Buddy1 (mobile) is online, \"I'm here\""));
+
+    // Register response for last activity query
+    stbbr_for_query("jabber:iq:last",
+        "<iq id='*' type='result' from='buddy1@localhost/mobile' to='stabber@localhost/profanity'>"
+            "<query xmlns='jabber:iq:last' seconds='120'/>"
+        "</iq>"
+    );
+
+    prof_input("/lastactivity get buddy1@localhost/mobile");
+
+    // Verify the request was sent
+    assert_true(stbbr_received(
+        "<iq id='*' to='buddy1@localhost/mobile' type='get'>"
+            "<query xmlns='jabber:iq:last'/>"
+        "</iq>"
+    ));
+}

tests/functionaltests/test_lastactivity.h

@@ -0,0 +1,7 @@
+/*
+ * test_lastactivity.h
+ * Header for Last Activity tests (XEP-0012)
+ */
+
+void responds_to_last_activity_request(void **state);
+void last_activity_request_to_contact(void **state);

tests/functionaltests/test_muc.c

@@ -393,3 +393,83 @@ shows_no_message_in_console_when_window_not_focussed(void **state)
     assert_false(prof_output_regex("testroom@conference\\.localhost \\(win 2\\)"));
     prof_timeout_reset();
 }
+
+void
+sends_affiliation_list_request(void **state)
+{
+    prof_connect();
+
+    stbbr_for_presence_to("testroom@conference.localhost/stabber",
+        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<x xmlns='http://jabber.org/protocol/muc#user'>"
+                "<item role='moderator' jid='stabber@localhost/profanity' affiliation='owner'/>"
+            "</x>"
+            "<status code='110'/>"
+        "</presence>"
+    );
+
+    prof_input("/join testroom@conference.localhost");
+    assert_true(prof_output_regex("-> You have joined the room as stabber, role: moderator, affiliation: owner"));
+
+    prof_input("/affiliation owner list");
+
+    assert_true(stbbr_received(
+        "<iq id='*' to='testroom@conference.localhost' type='get'>"
+            "<query xmlns='http://jabber.org/protocol/muc#admin'>"
+                "<item affiliation='owner'/>"
+            "</query>"
+        "</iq>"
+    ));
+}
+
+void
+sends_kick_request(void **state)
+{
+    prof_connect();
+
+    // Enable MUC presence messages to see occupant join/leave
+    prof_input("/presence room all");
+    assert_true(prof_output_regex("All presence updates will appear"));
+
+    stbbr_for_presence_to("testroom@conference.localhost/stabber",
+        "<presence id='*' lang='en' to='stabber@localhost/profanity' from='testroom@conference.localhost/stabber'>"
+            "<c hash='sha-1' xmlns='http://jabber.org/protocol/caps' node='http://profanity-im.github.io' ver='*'/>"
+            "<x xmlns='http://jabber.org/protocol/muc#user'>"
+                "<item role='moderator' jid='stabber@localhost/profanity' affiliation='admin'/>"
+            "</x>"
+            "<status code='110'/>"
+        "</presence>"
+    );
+
+    prof_input("/join testroom@conference.localhost");
+    assert_true(prof_output_regex("-> You have joined the room as stabber, role: moderator, affiliation: admin"));
+
+    // Simulate another user in the room
+    stbbr_send(
+        "<presence to='stabber@localhost/profanity' from='testroom@conference.localhost/baduser'>"
+            "<x xmlns='http://jabber.org/protocol/muc#user'>"
+                "<item role='participant' jid='baduser@localhost/phone' affiliation='none'/>"
+            "</x>"
+        "</presence>"
+    );
+    sleep(1);
+    assert_true(prof_output_regex("baduser has joined"));
+
+    // Register success response for kick
+    stbbr_for_query("http://jabber.org/protocol/muc#admin",
+        "<iq id='*' type='result' from='testroom@conference.localhost'/>"
+    );
+
+    prof_input("/kick baduser \"spamming\"");
+
+    assert_true(stbbr_received(
+        "<iq id='*' to='testroom@conference.localhost' type='set'>"
+            "<query xmlns='http://jabber.org/protocol/muc#admin'>"
+                "<item nick='baduser' role='none'>"
+                    "<reason>spamming</reason>"
+                "</item>"
+            "</query>"
+        "</iq>"
+    ));
+}

tests/functionaltests/test_muc.h

@@ -12,3 +12,5 @@ void shows_me_message_from_self(void **state);
 void shows_all_messages_in_console_when_window_not_focussed(void **state);
 void shows_first_message_in_console_when_window_not_focussed(void **state);
 void shows_no_message_in_console_when_window_not_focussed(void **state);
+void sends_affiliation_list_request(void **state);
+void sends_kick_request(void **state);