fix(ui): measure dead pad space from the cursor, not the requested lines

_win_print_internal now calls _win_ensure_pad_capacity() with getcury() plus the estimated message height, so deriving 'dead' from lines_needed counted that lookahead reservation as dead space. Compute it from getcury(win) directly so the reclaim keys off the real cursor-vs-buffer gap.
fix(ui): reclaim pad by dead space instead of absolute height
2026-06-23 14:18:37 +03:00 · 2026-06-20 10:37:29 +00:00
1 changed files with 5 additions and 4 deletions
--- a/src/ui/window.c
+++ b/src/ui/window.c
@@ -43,7 +43,7 @@
 #include "ai/ai_client.h"

 static const int PAD_MIN_HEIGHT = 100;
-static const int PAD_THRESHOLD = 12000; // above buffer cap (~9000): reclaims dead pad space, never fires while scrolling
+static const int PAD_DEAD_SPACE_LIMIT = 2000; // reclaim once the pad holds this much dead space (cursor past live buffer); size-independent, so it never fires while scrolling
 static gboolean _in_redraw = FALSE;

 static void
@@ -56,9 +56,10 @@ _win_ensure_pad_capacity(ProfWin* window, WINDOW* win, int lines_needed)
    int cur_height = getmaxy(win);
    int cur_width = getmaxx(win);
    if (lines_needed >= cur_height - 1) {
-        // If we are getting too large, trigger a redraw to clean up old lines
-        // but only if we are not already in a redraw process.
-        if (window && cur_height >= PAD_THRESHOLD && !_in_redraw) {
+        // redraw to reclaim dead pad space (cursor far past live buffer, e.g. a long
+        // append-only session); dead space never accrues while scrolling, only here
+        int dead = window ? getcury(win) - window->layout->buffer->lines : 0;
+        if (window && dead > PAD_DEAD_SPACE_LIMIT && !_in_redraw) {
            win_redraw(window);
        } else {
            // resize to required lines + some buffer for next messages
Author	SHA1	Message	Date
jabber.developer2	36512d9dde	fix(ui): measure dead pad space from the cursor, not the requested lines All checks were successful CI Code / Check coding style (pull_request) Successful in 31s Details CI Code / Check spelling (pull_request) Successful in 19s Details CI Code / Code Coverage (pull_request) Successful in 3m24s Details CI Code / Linux (debian) (pull_request) Successful in 4m42s Details CI Code / Linux (ubuntu) (pull_request) Successful in 4m49s Details CI Code / Linux (arch) (pull_request) Successful in 6m37s Details _win_print_internal now calls _win_ensure_pad_capacity() with getcury() plus the estimated message height, so deriving 'dead' from lines_needed counted that lookahead reservation as dead space. Compute it from getcury(win) directly so the reclaim keys off the real cursor-vs-buffer gap.	2026-06-23 14:18:37 +03:00
jabber.developer2	e33874e6b5	fix(ui): reclaim pad by dead space instead of absolute height All checks were successful CI Code / Check spelling (pull_request) Successful in 17s Details CI Code / Check coding style (pull_request) Successful in 31s Details CI Code / Code Coverage (pull_request) Successful in 3m23s Details CI Code / Linux (debian) (pull_request) Successful in 4m52s Details CI Code / Linux (ubuntu) (pull_request) Successful in 5m1s Details CI Code / Linux (arch) (pull_request) Successful in 6m50s Details Variant A (PAD_THRESHOLD=12000) bounds the pad but still re-enters win_redraw() from the print path on every message once the live buffer renders >= the threshold — reachable with a single oversized message (huge paste, narrow terminal, crafted incoming), reintroducing the per-message redraw storm. Trigger the reclaim redraw on dead space (getcury - buffer->lines) instead of absolute pad height. After a redraw the cursor equals buffer->lines, so dead space is 0 regardless of buffer size: the reclaim can never fire while scrolling, and an oversized message no longer storms (and is shown in full rather than clipped). Dead space only accrues in a long append-only session that trimmed old entries — exactly when reclaiming is wanted.	2026-06-20 10:37:29 +00:00