CI: Separate build and test steps

Per XEP-0030 section 3.1: 'if an entity has no associated items,
it MUST return an empty <query/> element.'

The client should display 'No service discovery items for X' when
receiving an empty result, not silently ignore it.

Previous version introduced in commit f28655c5c (2016-05-08) which added an early
return when child == NULL, preventing the message from being shown.

.github/workflows/ci-code.yml

@@ -29,10 +29,10 @@ jobs:
     name: Linux
     steps:
       - uses: actions/checkout@v4
+      - name: Build
+        run: docker build -f Dockerfile.${{ matrix.flavor }} -t profanity .
       - name: Run tests
-        run: |
-          docker build -f Dockerfile.${{ matrix.flavor }} -t profanity .
-          docker run profanity ./ci-build.sh
+        run: docker run profanity ./ci-build.sh
 
   code-style:
     runs-on: ubuntu-latest
@@ -107,7 +107,7 @@ jobs:
     name: Code Coverage
     steps:
       - uses: actions/checkout@v4
-      - name: Build and run coverage
-        run: |
-          docker build -f Dockerfile.arch -t profanity-cov .
-          docker run profanity-cov ./ci-build.sh --coverage-only
+      - name: Build
+        run: docker build -f Dockerfile.arch -t profanity-cov .
+      - name: Run coverage
+        run: docker run profanity-cov ./ci-build.sh --coverage-only

CONTRIBUTING.md

@@ -152,7 +152,7 @@ We have a static analyzer `check-cwe134.sh` that detects CWE-134 format string v
 ./check-cwe134.sh
 ```
 
-This checks for unsafe patterns where user-controlled data could be passed directly as a format string to functions like `cons_show`, `log_error`, `win_println`, etc. Always use `"%s"` format specifier when printing user data.
+This checks for unsafe patterns where data could be passed directly as a format string to functions like `printf`, `cons_show`, etc. Never pass a raw string for formatting; use `"%s"` format specifier instead.
 
 ### Finding typos
 

Dockerfile.arch

@@ -1,9 +1,10 @@
-FROM archlinux
+FROM archlinux:latest
 
 ENV TERM=xterm
 ENV CC="ccache gcc"
 
-RUN pacman -Syu --noconfirm
+RUN pacman -Syyu --noconfirm
+
 # reflector is optional - if it fails due to network issues, continue with default mirrorlist
 RUN pacman -S --needed --noconfirm reflector && \
     (reflector --latest 20 --protocol https --sort rate --save /etc/pacman.d/mirrorlist || true)

ci-build.sh

@@ -86,7 +86,6 @@ extract_test_count() {
 # and checks that the test framework reports the failure correctly
 verify_test_failure_detection()
 {
-    echo
     echo "==> Verifying test failure detection..."
     
     # Create a simple failing test

src/xmpp/iq.c

@@ -2532,9 +2532,6 @@ _disco_items_result_handler(xmpp_stanza_t* const stanza)
     }
 
     xmpp_stanza_t* child = xmpp_stanza_get_children(query);
-    if (child == NULL) {
-        return;
-    }
 
     while (child) {
         const char* stanza_name = xmpp_stanza_get_name(child);

tests/functionaltests/test_lastactivity.c

@@ -23,7 +23,7 @@ responds_to_last_activity_request(void **state)
         "</iq>"
     );
 
-    // Verify profanity responds with last activity info
+    // Verify that CProof responds with last activity info
     // The 'seconds' attribute indicates idle time
     assert_true(stbbr_received(
         "<iq id='last1' type='result' to='buddy1@localhost/mobile'>"