devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

WIP: fix(database): make v2->v3 chatlog migration deterministic and FK-safe #129

Draft
jabber.developer2 wants to merge 1 commits from fix/issue-128-migrate-v3-dedup into master
pull from: fix/issue-128-migrate-v3-dedup
merge into: devs:master
Conversation 0 Commits 1 Files Changed 1 +32 -3
jabber.developer2 commented 2026-05-27 11:23:27 +00:00
Collaborator
Copy Link

Closes #128.

_migrate_to_v3 deduped duplicate archive_id rows via a bare-column GROUP BY (arbitrary survivor — in practice the older row, dropping the latest) and copied rows with SELECT * (positional column binding).

This PR:

  • keeps MAX(id) per archive_id group ("latest insert wins") instead of GROUP BY's implementation-defined pick;
  • NULLs out replaces_db_id / replaced_by_db_id pointing at dropped rows, so no dangling XEP-0308 (LMC) links survive (the "Broken LMC reference" condition verify_integrity flags);
  • lists columns explicitly instead of SELECT *, with a schema-side note to keep the two in sync.

Only affects users upgrading from a v2 DB — already-v3 databases and live inserts are unchanged.

Verified with a local sqlite3 migration test (deterministic survivor, FK sweep, preserved valid FKs); kept local / out of CI as a one-shot migration check.

Closes #128. `_migrate_to_v3` deduped duplicate `archive_id` rows via a bare-column `GROUP BY` (arbitrary survivor — in practice the older row, dropping the latest) and copied rows with `SELECT *` (positional column binding). This PR: - keeps `MAX(id)` per `archive_id` group ("latest insert wins") instead of `GROUP BY`'s implementation-defined pick; - NULLs out `replaces_db_id` / `replaced_by_db_id` pointing at dropped rows, so no dangling XEP-0308 (LMC) links survive (the "Broken LMC reference" condition `verify_integrity` flags); - lists columns explicitly instead of `SELECT *`, with a schema-side note to keep the two in sync. Only affects users upgrading from a v2 DB — already-v3 databases and live inserts are unchanged. Verified with a local `sqlite3` migration test (deterministic survivor, FK sweep, preserved valid FKs); kept local / out of CI as a one-shot migration check.
jabber.developer2 added 1 commit 2026-05-27 11:23:27 +00:00
fix(database): make v2->v3 chatlog migration deterministic and FK-safe
All checks were successful
CI Code / Check spelling (pull_request) Successful in 18s
Details
CI Code / Check coding style (pull_request) Successful in 34s
Details
CI Code / Linux (debian) (pull_request) Successful in 4m45s
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 4m53s
Details
CI Code / Code Coverage (pull_request) Successful in 6m57s
Details
CI Code / Linux (arch) (pull_request) Successful in 10m19s
Details
d9f1c25c7c 
_migrate_to_v3 deduplicated duplicate archive_id rows with a bare-column
GROUP BY, which lets SQLite keep an arbitrary row per group (in practice the
older row, dropping the latest), and copied rows with SELECT *, which relies
on positional column matching between the v2 and v3 schemas.

- Keep MAX(id) per archive_id group ("latest insert wins") instead of
  GROUP BY's implementation-defined pick.
- Sweep replaces_db_id / replaced_by_db_id after dedupe, NULLing references
  to dropped rows so the migrated table carries no dangling XEP-0308 (LMC)
  links (the "Broken LMC reference" condition verify_integrity flags).
- List columns explicitly instead of SELECT * so the copy cannot mis-bind,
  and note at the schema that column changes must be mirrored here.

Refs #128
jabber.developer2 changed title from fix(database): make v2->v3 chatlog migration deterministic and FK-safe to WIP: fix(database): make v2->v3 chatlog migration deterministic and FK-safe 2026-05-27 11:23:30 +00:00
jabber.developer2 force-pushed fix/issue-128-migrate-v3-dedup from d9f1c25c7c to 25e9bc6e93 2026-06-19 08:43:24 +00:00 Compare
All checks were successful
CI Code / Check spelling (pull_request) Successful in 16s
Required
Details
CI Code / Check coding style (pull_request) Successful in 31s
Required
Details
CI Code / Code Coverage (pull_request) Successful in 3m12s
Required
Details
CI Code / Linux (debian) (pull_request) Successful in 4m40s
Required
Details
CI Code / Linux (arch) (pull_request) Successful in 6m54s
Required
Details
CI Code / Linux (ubuntu) (pull_request) Successful in 7m3s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/issue-128-migrate-v3-dedup:fix/issue-128-migrate-v3-dedup
git checkout fix/issue-128-migrate-v3-dedup
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#129
No description provided.
Delete Branch "fix/issue-128-migrate-v3-dedup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?