WIP: fix(database): make v2->v3 chatlog migration deterministic and FK-safe #129

Draft

jabber.developer2 wants to merge 1 commits from fix/issue-128-migrate-v3-dedup into master

Author	SHA1	Message	Date
jabber.developer2	25e9bc6e93	fix(database): make v2->v3 chatlog migration deterministic and FK-safe All checks were successful CI Code / Check spelling (pull_request) Successful in 16s Details CI Code / Check coding style (pull_request) Successful in 31s Details CI Code / Code Coverage (pull_request) Successful in 3m12s Details CI Code / Linux (debian) (pull_request) Successful in 4m40s Details CI Code / Linux (arch) (pull_request) Successful in 6m54s Details CI Code / Linux (ubuntu) (pull_request) Successful in 7m3s Details _migrate_to_v3 deduplicated duplicate archive_id rows with a bare-column GROUP BY, which lets SQLite keep an arbitrary row per group (in practice the older row, dropping the latest), and copied rows with SELECT , which relies on positional column matching between the v2 and v3 schemas. - Keep MAX(id) per archive_id group ("latest insert wins") instead of GROUP BY's implementation-defined pick. - Sweep replaces_db_id / replaced_by_db_id after dedupe, NULLing references to dropped rows so the migrated table carries no dangling XEP-0308 (LMC) links (the "Broken LMC reference" condition verify_integrity flags). - List columns explicitly instead of SELECT so the copy cannot mis-bind, and note at the schema that column changes must be mirrored here. Refs #128	2026-06-19 08:43:23 +00:00

Author

SHA1

Message

Date

jabber.developer2

25e9bc6e93

fix(database): make v2->v3 chatlog migration deterministic and FK-safe

CI Code / Check spelling (pull_request) Successful in 16s

Details

CI Code / Check coding style (pull_request) Successful in 31s

Details

CI Code / Code Coverage (pull_request) Successful in 3m12s

Details

CI Code / Linux (debian) (pull_request) Successful in 4m40s

Details

CI Code / Linux (arch) (pull_request) Successful in 6m54s

Details

CI Code / Linux (ubuntu) (pull_request) Successful in 7m3s

Details

_migrate_to_v3 deduplicated duplicate archive_id rows with a bare-column
GROUP BY, which lets SQLite keep an arbitrary row per group (in practice the
older row, dropping the latest), and copied rows with SELECT *, which relies
on positional column matching between the v2 and v3 schemas.

- Keep MAX(id) per archive_id group ("latest insert wins") instead of
  GROUP BY's implementation-defined pick.
- Sweep replaces_db_id / replaced_by_db_id after dedupe, NULLing references
  to dropped rows so the migrated table carries no dangling XEP-0308 (LMC)
  links (the "Broken LMC reference" condition verify_integrity flags).
- List columns explicitly instead of SELECT * so the copy cannot mis-bind,
  and note at the schema that column changes must be mirrored here.

Refs #128

2026-06-19 08:43:23 +00:00

WIP: fix(database): make v2->v3 chatlog migration deterministic and FK-safe #129

1 Commits