devs/cproof
1
2
Fork 1
Code Issues 43 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Refactor and fix memory leak in theme_init #6

Manually merged
jabber.developer merged 3 commits from fix/theme-mem-leak into master 2025-06-24 15:37:14 +00:00
Conversation 0 Commits 3 Files Changed 2 +9 -15
jabber.developer commented 2025-06-24 13:54:23 +00:00
Owner
Copy Link
  • I ran valgrind when using my new feature
<!-- For completed items, change [ ] to [x]. --> - [x] I ran valgrind when using my new feature
jabber.developer added 3 commits 2025-06-24 13:54:24 +00:00
fix: Remove unnecessary theme_init call (mem leak) 7d1e1c726d 
Simple `ui_resize` is sufficient for rerendering all the elements.
Other calls create complexity, slow down the applications and even introduce mem leaks.

`ui_resize` technique is already used widely, including `cmd_editor` case.

Fixes #4
ref: Remove unnecessary variable bold_items 83c569de37 
The variable was introduced in 976e5aa. First used to detect bold characters, it was later replaced by another solution in 850ac3c.
ref(theme): ensure clean reinitialization and explicitly initialize static vars
Some checks failed
CI / Check spelling (pull_request) Successful in 18s
Details
CI / Check coding style (pull_request) Failing after 28s
Details
CI / Linux (debian) (pull_request) Successful in 9m39s
Details
CI / Linux (ubuntu) (pull_request) Successful in 9m59s
Details
CI / Linux (fedora) (pull_request) Successful in 10m38s
Details
CI / Linux (arch) (pull_request) Successful in 16m6s
Details
1c0f39db54 
Improves code robustness by calling _theme_close() in theme_init() when the
theme was already initialized, preventing potential memory leaks or
inconsistent state.

Closes #4
admin force-pushed fix/theme-mem-leak from 1c0f39db54 to d5d5dc5180 2025-06-24 14:22:57 +00:00 Compare
jabber.developer manually merged commit 43bab6ff8f into master 2025-06-24 15:37:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin jabber.developer jabber.developer2
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: devs/cproof#6
No description provided.
Delete Branch "fix/theme-mem-leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?