7601 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
jabber.developer2	522db05090	style(ui,window): format code and tidy comments ... Whitespace and comment formatting only; no functional changes.	2025-11-04 08:26:35 +03:00
jabber.developer2	221a95b7b4	refactor(ui,window): post-review cleanups in window module ... Apply code style and structure simplifications suggested during review; no functional changes.	2025-11-04 08:26:21 +03:00
jabber.developer2	89f75575a5	docs(ui,window): update comments related to metrics handling ... Adjust comments to better reflect metrics-related behavior; no functional changes.	2025-11-04 08:26:06 +03:00
jabber.developer2	ccb4bbac4a	docs(ui,window): update comments around buffer handling ... Clarify buffer-related behavior and notes in the window module comments; no functional changes.	2025-11-04 08:25:54 +03:00
jabber.developer2	6a47efa049	fix(ui,window): manage unread indicators and paging state accurately ... Add logic to track unread message indicators and the paged state in the UI window component, ensuring correct clearing and display of unread markers while navigating. Files: src/ui/window.c, src/ui/titlebar.c, src/ui/win_types.h	2025-11-04 08:25:31 +03:00
jabber.developer2	33543d2543	fix(ui,window): prevent buffer updates while viewing history to avoid scroll lock ... When the user scrolls back to view message history, suppress printing and buffer writes to keep the viewport stable and prevent the scroll position from jumping or getting stuck. Files: src/ui/window.c	2025-11-04 08:25:17 +03:00
Jabber Developer	74cfd32c1e	Improve arch build: sort mirrors by speed in reflector	2025-10-29 20:45:37 +01:00
Jabber Developer	fe6912a30c	Fix arch build by adding pacman-key --init and updating gtk2 to gtk3	2025-10-29 20:27:55 +01:00
Jabber Developer	266f5aa046	feat(api): add get_current_window call ... Add prof_get_current_window API to retrieve the title of the currently active window, matching the titlebar display. The feature is especially useful to track currently used plugin window.	2025-10-20 19:00:48 +02:00
Jabber Developer	3738be4af1	fix: prevent autoping disable on false negative ping support check ... Remove autodisable logic (prefs_set_autoping(0)) and early return in autoping to treat intermittent false negatives from connection_supports(XMPP_FEATURE_PING). Add one-time error display with debug features print for monitoring; warn on first failing check without aborting to maintain functionality while investigating root cause.	2025-10-14 12:42:00 +02:00
Jabber Developer	ad95edb2b9	feat: make /log level work with non-default files	2025-10-13 20:47:34 +02:00
Jabber Developer	fac1e224bc	fix(scroll): handle edge case of extremely long messages ... Prior commit (6ad8a190) did not properly handle overflow by long (9000 lines) message, to address this issue, multiple changes were made: - Add lines recalculation on win_redraw - Move `prof_buff_t` struct to header file so its lines could be externally changed - Call win_redraw once overflow is detected: it allows to recalculate sizes in lines and apply changes to the buffer	2025-10-08 13:00:32 +02:00
Jabber Developer	6ad8a19053	fix(buffer): use dynamic buffer size to prevent unnecessary buffer cleanups ... Refactor buffer trimming logic to use dynamic line counts (_lines per entry) against PAD_SIZE (10k) instead of fixed entry count (MAX_BUFFER_SIZE=200). This prevents premature cleanups for short messages, reduces scrolling disruptions during history loads, and scales better with rendered content size. Delete oldest/newest entry from opposite end only when total lines approach ncurses pad limit, minimizing unnecessary deletions. Simplify overflow warning log by removing unused MAX_BUFFER_SIZE reference. Update buffer.c header for improved DX: - Add detailed module overview explaining role (in-memory UI buffer vs. DB persistence), key features (trimming, metadata), and integration (ncurses). - Shorten copyright/license boilerplate to concise pointer (LICENSE ref). - Add fork notice; preserve original copyrights per GPLv3. Partially addresses #36 (stuck scroll mitigation via fewer cleanups) Related to #36	2025-10-07 15:12:20 +02:00
Jabber Developer	40dd773c6a	docs(apidocs/c): improve profapi.h and profhooks.h comments ... - Enhanced file-level comments with concise descriptions - Added usage examples and aligned with Python prof module style - Updated function comments to remove tables, improve clarity - Replaced Profanity with CProof, preserved paths and method names	2025-09-23 14:07:32 +02:00
Jabber Developer	8849d9b79e	docs: move callbacks down ... To improve readability of the docs	2025-09-22 23:05:45 +02:00
Jabber Developer	92cb930810	docs: Fix indentation	2025-09-17 01:37:10 +02:00
Jabber Developer	9fd62e2304	ci: restructure and optimize execution conditions ... - The code tests will ignore doc changes and vice versa. - The CI is split in 2 parts for clarity	2025-09-17 01:00:30 +02:00
Jabber Developer	c94263486f	docs(python): fix formatting to ensure correct parsing ... Fixes issues introduced in 052e168, 4cdcf9a, and other commits from PR #31.	2025-09-17 00:34:37 +02:00
Jabber Developer	353b6bdb11	Merge branch 'build/add-api-docs-gen-tests'	2025-09-15 16:54:33 +02:00
Jabber Developer	105c496ab1	docs(sphinx): fix conf.py and index.rst to resolve warnings ... - Removed unnecessary list item (*) from :ref:`genindex`. - Added blank line after :ref:`genindex` to terminate markup block. - Rebranded configs	2025-09-15 16:12:47 +02:00
Jabber Developer	cb6f302208	docs(prof.py): add CommandCallback, TimedCallback, WindowCallback protocols ... - Defined callback protocols for register_command, register_timed, win_create. - Fixed Sphinx callable warnings with proper type hints. - Align docs with the code	2025-09-15 15:47:10 +02:00
Jabber Developer	4cdcf9a8eb	docs(plugin): update plugin.py to align with formatting required by Sphinx ... - Replace Profanity with CProof in all docstrings and examples. - Remove Python 2 and unicode references, using Python 3 str types. - Add type hints for all parameters and return types. - Use :: for code blocks with blank lines to fix Sphinx errors. - Improve wording for clarity and integrated examples into docstrings. - Organize functions into logical sections with RST comments. - Use double backticks for inline literals to resolve Sphinx warnings.	2025-09-15 11:53:49 +02:00
Jabber Developer	7e4c60e2c3	ci(Doxygen): Enable warning as error ... To ensure that CI builds fails to reflect issues within the documentations	2025-09-10 19:38:24 +02:00
Jabber Developer	e998d5e7ef	docs: fix C API documentation ... `barejid` parameter was used instead of the intended `roomjid`, leading to warnings during compilation.	2025-09-10 19:35:21 +02:00
Jabber Developer	3ffeda1531	ci: Disable Doxygen HTML generation ... Since only XML is being used during website build process, generation of HTML involves unnecessary computations.	2025-09-10 19:32:34 +02:00
Jabber Developer	a4cead7fe8	ci: Update doxygen config file via doxygen -u	2025-09-10 19:30:24 +02:00
Jabber Developer	052e168e9b	docs(prof.py): overhaul documentation to align with Google Python Style Guide ... - Updated project references from Profanity to CProof. - Removed Python 2 and unicode references. - Added type hints for all parameters and return types. - Organized functions into logical sections with RST comments for Sphinx. - Improved wording for clarity and precision based on source code analysis. - Ensured compliance with Google Python Style Guide for readable docstrings. Related to #30	2025-09-10 19:05:33 +02:00
Jabber Developer	c94cd0b549	ci: add GitHub Actions workflow to test C and Python API doc generation ... Introduce separate jobs to test C (Doxygen) and Python (Sphinx) API documentation generation. Ensures build failures are caught early, as API changes often produce warnings that developers miss without automated checks.	2025-09-10 19:05:32 +02:00
Jabber Developer	4780fdd4a1	tests: update cmocka include in forced encryption tests ... Includes were updated in 988d366, but the change did not propagate to forced_encryption.c due to the gap between the upstream Profanity and the CProof.	2025-09-10 15:50:26 +02:00
Steffen Jaeckel	9b1cb6ab85	If config keyfile does not exist, create it. ... Fixes #1911 Alternative to #2056 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit b12521ca21)	2025-09-10 14:20:08 +02:00
Michael Vetter	f419e65fad	Update issue templates ... According to the new way: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates (cherry picked from commit 5dcbd84f75)	2025-09-10 14:18:01 +02:00
Michael Vetter	110b3d27b4	Rename issue template ... Seems like GH changed how the templates work. (cherry picked from commit f1e12a33cf)	2025-09-10 14:17:15 +02:00
Steffen Jaeckel	75b378cf54	Don't use memchr() on strings potentially shorter than 4 bytes. ... When running profanity under Valgrind with slashguard enabled, the following error could occur: ``` [...] ==4021347== Invalid read of size 1 ==4021347== at 0x4851F49: memchr (vg_replace_strmem.c:986) ==4021347== by 0x45CEAD: _inp_slashguard_check (inputwin.c:183) ==4021347== by 0x45CEAD: inp_readline (inputwin.c:225) ==4021347== by 0x431184: prof_run (profanity.c:121) ==4021347== by 0x42C609: main (main.c:176) ==4021347== Address 0xe850883 is 0 bytes after a block of size 3 alloc'd ==4021347== at 0x48477C4: malloc (vg_replace_malloc.c:446) [...] ``` `memchr()` requires the complete memory that shall be searched to be accessible. Using `strchr()` could work for shorter strings, but we only want to search in the first 4 chars. Instead of somehow working around those limitations, simply search manually in the first 4 bytes. Fixes: 3c56b289 ("Add slashguard feature") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 7f48452d84)	2025-09-10 14:16:19 +02:00
Steffen Jaeckel	988d3663d1	Introduce tests/prof_cmocka.h ... As 9f2abc75 accidentally got the ordering of some of the includes wrong, I decided to propose my initial solution again. Additional to that, I've opened a MR against CMocka to solve this on their side, since I believe that the current way this is done is not sustainable [0]. [0] https://gitlab.com/cmocka/cmocka/-/merge_requests/91 Fixes: 9f2abc75 ("Fix tests with gcc15 (uintptr_t)") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> CProof note: our new tests need to also be updated.	2025-09-10 14:11:03 +02:00
Steffen Jaeckel	d3fa1c2f78	Tidy up some code ... * less allocations * less duplicate code Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 9d335729a0)	2025-09-10 14:07:41 +02:00
Steffen Jaeckel	1a385b8cd2	Refactor slashguard ... Fixes #2054 Fixes: 95c2199c ("Some more memory improvements") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 40aafd06e7)	2025-09-10 14:05:30 +02:00
Steffen Jaeckel	39aab45162	Fix memory leak. ... Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit e0f107f75e)	2025-09-10 14:01:22 +02:00
Steffen Jaeckel	0d5123e69a	Trampoline Python unref again. ... In the past `Py_XDECREF()` was a macro. Preserve compat to ancient Python versions by having a trampoline which calls `Py_XDECREF()`. Fixes: #2043 Fixes: c0da36c4 ("Rage-cleanup.") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 3299dd8fc6)	2025-09-10 14:00:51 +02:00
Steffen Jaeckel	36f183d6a4	Separate entries visually in my-prof.supp ... Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 3370f8a7f1)	2025-09-10 14:00:07 +02:00
Martin Dosch	6b6576b31c	Fix typo in examples. ... (cherry picked from commit 5696bf77c7) Author: Martin Dosch <martin@mdosch.de>	2025-09-10 13:58:57 +02:00
Andreas Stieger	1ae78400a4	Fix tests with gcc15 (uintptr_t) ... fixes: error: ‘uintptr_t’ undeclared, defined in header ‘<stdint.h> (cherry picked from commit 9f2abc75ad) Author: Andreas Stieger <Andreas.Stieger@gmx.de>	2025-09-10 13:57:36 +02:00
Jabber Developer	ea8a758ecf	Merge branch 'fix/correct-autocompletion'	2025-09-02 14:20:23 +02:00
Jabber Developer	2808def933	fix(chatwin): Fix LMC autocompletion to suggest corrected message content ... - Modified chatwin_outgoing_msg to call _chatwin_set_last_message for corrected messages, using replace_id per XEP-0308. - Updated _chatwin_set_last_message to skip redundant and invalid free/strdup for same pointers. - Added null checks in _chatwin_set_last_message for safety. - Fixes autocompletion suggesting original message content instead of corrected content. Fixes #24	2025-09-02 00:29:13 +02:00
Jabber Developer	741dc4c275	fix(ui.h): cons_show_qrcode declaration. Minor change ... Prior to the change declaration did not include parameters, leading to errors within static analyzers and potential issues with compilation.	2025-09-01 23:29:26 +02:00
Jabber Developer	65cf9ddb9c	fix(cmd_sub): Prevent crash with malformed JID in /sub command ... Added null check for jidp in cmd_sub to handle jid_create returning NULL. Crash occurred when processing malformed JID inputs like @example.com. Ensures robust handling of invalid JIDs. Fixes #22	2025-09-01 23:29:26 +02:00
Jabber Developer	51d2355d97	fix(cmd_caps): Prevent crash in /caps with malformed JID input ... - Added null check for `jid` in `cmd_caps` to handle `jid_create` returning NULL. - Crash occurred when processing malformed inputs like `@example.com` in `/caps`. - Ensures robust handling of invalid JID strings in `WIN_CHAT` and `WIN_CONSOLE` cases. Fixes #20	2025-09-01 21:28:19 +02:00
Jabber Developer	e33c7a477d	docs(rebranding): update readme	2025-09-01 16:57:10 +02:00
Jabber Developer	f4405d114a	Add unit tests for forced encryption check function	2025-08-27 16:48:27 +02:00
Jabber Developer	442bfb6ce1	feat: Add /force-encryption command and update message handling ... Implement /force-encryption command to configure forced encryption settings with on|off and policy resend-to-confirm|block options. The changes enhance user experience by clarifying encryption requirements and providing actionable commands. Users can now press Enter again to confirm unencrypted messages in resend-to-confirm mode.	2025-08-25 21:11:27 +02:00
Jabber Developer	a3e23c3514	Temporarily disable Fedora tests ... They are failing on our runners due to issues with dependency resolution.	2025-08-07 03:27:14 +02:00