- otr: strip the OTR whitespace tag by shifting the full remaining tail
  (including the trailing NUL) instead of tag_length bytes, which duplicated
  the body for messages longer than the tag (#8).
- xmpp: snapshot resource name/status/priority/presence before
  connection_add_available_resource() transfers ownership of the Resource, so
  the later reads can no longer become a use-after-free (#9).
- omemo: propagate _omemo_finalize_identity_load failure on connect — mark the
  context unloaded, log it, surface a cons_show_error, and stop instead of
  silently leaving OMEMO unavailable (#10).

Refs #112

@@ -10068,0 +10066,4 @@
+        int index;
+        auto_gchar gchar* err_msg = NULL;
+        if (!strtoi_range(args[1], &index, 0, INT_MAX, &err_msg)) {
+            cons_show("%s", err_msg);

@@ -692,12 +692,13 @@ get_file_paths_recursive(const char* path, GSList** contents)
 gchar*
 get_random_string(int length)
 {
+    g_assert(length >= 0);

@@ -161,0 +163,4 @@
+static inline gsize
+g_diff_to_gsize(const void* end, const void* start)
+{
+    g_assert(end >= start);

@@ -279,3 +279,3 @@
                     tag_length = 32;
                 }
-                memmove(whitespace_base, whitespace_base + tag_length, tag_length);
+                // Shift the remainder of the message (including the trailing NUL)

@@ -622,3 +622,3 @@
 
     if (g_strcmp0(xmpp_presence->jid->barejid, my_jid->barejid) == 0) {
-        connection_add_available_resource(resource);
+        // Snapshot everything we read from `resource` before ownership is

@@ -120,3 +120,3 @@
 _mkdir_recursive(const char* dir)
 {
-    int i;
+    size_t i;